Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp4047398rwn; Sun, 11 Sep 2022 04:09:57 -0700 (PDT) X-Google-Smtp-Source: AA6agR4dRlN9t2UceJzcV5lRqCIvQDsHypz904SH0EI00Rq0alWZFuR5pSk1TFHp4QYghYqFwVS5 X-Received: by 2002:a17:907:7215:b0:741:416f:fb59 with SMTP id dr21-20020a170907721500b00741416ffb59mr15934506ejc.150.1662894597036; Sun, 11 Sep 2022 04:09:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662894597; cv=none; d=google.com; s=arc-20160816; b=tKOX72RFB892P7iYA+C388x4xO+n8sPnng0uWswfGTOzn9tPFO6wzcAaqYiB/HwKhH 472KbAI4hRkX2CiXt03H/KtKKONYN8ZutcqoUcVx997L1wTkyAQ/h4HT3OAtClzUaO5V OHdI7Jg5k8KXPG+ndV623vri40EwPGXNJqBCWKOb3AJ+PSn/pVkYG8JRI4M/QhX6vJ27 rQput9k/6ck8IiuEeiBAi1uAk5o0z2+BzQxYIqIdfDIkwlfdafr2rq79neTinLbl999k IFTRpgYpgKjCQTVy3oIoWPO0m4GHd0/Di6JMQSiTRlTzBtJpTF8FWUFtT+4WJPVbdrT4 gcoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=USDvEaR9KG1B871wiabGAqJETGBO4KGWzVY0Nv0OlAs=; b=XtfL159e93l7riMVy9aBK0u16uRu7CQuOzgBQQ8JPgWb0DPoOohH87hmyl4al41MUk g4X873RrDfUpJSWnFf9MxoIGRzXoCEHAbVU2e2bAcECu5yzmTNyg2dLDfgELQlDWaUq2 2+UZ4gfFwYdQfAsQuoL9L3BC/Nmwo6sWSz5F54vh0pbvb4efKKaVnvqVn35S8cr2KH6D e4UQJE2RK6I+13xKoAEAlBSYCvjBHSpLKG772bkTbO6OmbqRvmvZKrqQyRvATIHihVqf Rg9vD/1wfLKs7qC3VPGySOawg3dQZvV7CmoT5DZt8/ZagndQVimprVlQzu0Z/2R4cy5E CAxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VXfEAyS9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds3-20020a0564021cc300b00451440a2f34si3656044edb.60.2022.09.11.04.09.20; Sun, 11 Sep 2022 04:09:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VXfEAyS9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230272AbiIKKru (ORCPT + 99 others); Sun, 11 Sep 2022 06:47:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230301AbiIKKrX (ORCPT ); Sun, 11 Sep 2022 06:47:23 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFAE42A969 for ; Sun, 11 Sep 2022 03:47:18 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id bq9so10912753wrb.4 for ; Sun, 11 Sep 2022 03:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date; bh=USDvEaR9KG1B871wiabGAqJETGBO4KGWzVY0Nv0OlAs=; b=VXfEAyS9YcF1cQyuWRGAF1k9gOEzkVnrNBm5zjTVCc+OuDCUNXR6poIRx/VRr656ZO Hm/5JFPO5Zk5AobQV3FNYdQW1baSsXB2Hwrt46MncIMfnGNVH+TpC16PNG6XCBApiRy4 hGMXpGH8AX4+WQu2r6/ZCyEOY3Ei4vjrf8yO6aUF5bU8KXgZnd9gIs2/ba2LF5sbONPM qLQACScQRNZ3PlwyZyJ4lymKrffM6LdoIRBcWppxXPhFv2DGCMG1zL1Fa1Aoed5YKJtv vzPSbMeA0kB8vVk0+0nHYl4aCRj1m9Lz5CVjQtzpk5njTZNX98PM+gEjerVZ469au0xU Y/Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=USDvEaR9KG1B871wiabGAqJETGBO4KGWzVY0Nv0OlAs=; b=1zZXjtzESctsSlQ7X0ZjsweiU01I4rkOf2jAjPzt7hsFWmVd7Ej9cRXMxR/epPdRpg R5gezo6RfHjxoin0i+muaQRhzsPZIYzqzmQpsn9fdUQchu1IxMUX30oV7I+XfMEODG5K cqQUBZOsHT6t2kSFx1ePDqcExfYyGfJxvUhX0JAsK57XRCxiEmipK3I3cU6XaEynhd8E R6m2ShfAyGLv2VlvcG1QUUqDVOqs+NLYKk8OLwPtih0LBAqnkj+J+vXRxmTC6jnete+V lYmPzqlw6SMZv/1tpsddvNsR0HYysiCgvJBr055UczE79wPgkDSmoQ4e7Ig3tjxNcIeS uVYg== X-Gm-Message-State: ACgBeo1HyvinN3Jr5gLZhS+JylkQQsM33yAanlNX3MtbWkm/q/T2VAVv 3u4iglhaXK3swKFvRuF1CZY= X-Received: by 2002:adf:e781:0:b0:228:b44c:d0f7 with SMTP id n1-20020adfe781000000b00228b44cd0f7mr11589202wrm.243.1662893237576; Sun, 11 Sep 2022 03:47:17 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57ba2cf5.dip0.t-ipconnect.de. [87.186.44.245]) by smtp.gmail.com with ESMTPSA id r15-20020a5d694f000000b00228c792aaaasm4613391wrw.100.2022.09.11.03.47.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 03:47:17 -0700 (PDT) Date: Sun, 11 Sep 2022 12:47:15 +0200 From: Philipp Hortmann To: Forest Bond , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 10/12] staging: vt6655: Cleanup and rename function MACvSetCurrTXDescAddr Message-ID: <88dcbac76f6bad8b4eb68a3cb37cd4f9684294a0.1662890990.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rename function MACvSetCurrTXDescAddr to vt6655_mac_set_curr_tx_desc_addr and iTxType to tx_type to avoid CamelCase which is not accepted by checkpatch.pl. Remove unnecessary line break. Signed-off-by: Philipp Hortmann --- drivers/staging/vt6655/card.c | 4 ++-- drivers/staging/vt6655/mac.c | 7 +++---- drivers/staging/vt6655/mac.h | 3 +-- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index d137b4b45e3b..c680925b9c92 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -409,9 +409,9 @@ void CARDvSafeResetTx(struct vnt_private *priv) } /* set MAC TD pointer */ - MACvSetCurrTXDescAddr(TYPE_TXDMA0, priv, priv->td0_pool_dma); + vt6655_mac_set_curr_tx_desc_addr(TYPE_TXDMA0, priv, priv->td0_pool_dma); - MACvSetCurrTXDescAddr(TYPE_AC0DMA, priv, priv->td1_pool_dma); + vt6655_mac_set_curr_tx_desc_addr(TYPE_AC0DMA, priv, priv->td1_pool_dma); /* set MAC Beacon TX pointer */ iowrite32((u32)priv->tx_beacon_dma, priv->port_offset + MAC_REG_BCNDMAPTR); diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c index d6614be79e39..0ff98468b2e0 100644 --- a/drivers/staging/vt6655/mac.c +++ b/drivers/staging/vt6655/mac.c @@ -653,12 +653,11 @@ void MACvSetCurrAC0DescAddrEx(struct vnt_private *priv, iowrite8(DMACTL_RUN, io_base + MAC_REG_AC0DMACTL); } -void MACvSetCurrTXDescAddr(int iTxType, struct vnt_private *priv, - u32 curr_desc_addr) +void vt6655_mac_set_curr_tx_desc_addr(int tx_type, struct vnt_private *priv, u32 curr_desc_addr) { - if (iTxType == TYPE_AC0DMA) + if (tx_type == TYPE_AC0DMA) MACvSetCurrAC0DescAddrEx(priv, curr_desc_addr); - else if (iTxType == TYPE_TXDMA0) + else if (tx_type == TYPE_TXDMA0) MACvSetCurrTx0DescAddrEx(priv, curr_desc_addr); } diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h index fff9dc72e2c0..0224f710d603 100644 --- a/drivers/staging/vt6655/mac.h +++ b/drivers/staging/vt6655/mac.h @@ -558,8 +558,7 @@ bool MACbShutdown(struct vnt_private *priv); void MACvInitialize(struct vnt_private *priv); void vt6655_mac_set_curr_rx_0_desc_addr(struct vnt_private *priv, u32 curr_desc_addr); void vt6655_mac_set_curr_rx_1_desc_addr(struct vnt_private *priv, u32 curr_desc_addr); -void MACvSetCurrTXDescAddr(int iTxType, struct vnt_private *priv, - u32 curr_desc_addr); +void vt6655_mac_set_curr_tx_desc_addr(int tx_type, struct vnt_private *priv, u32 curr_desc_addr); void MACvSetCurrTx0DescAddrEx(struct vnt_private *priv, u32 curr_desc_addr); void MACvSetCurrAC0DescAddrEx(struct vnt_private *priv, -- 2.37.3