Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <834eafc7-adb8-4977-a8c0-e34c44a583f3@linaro.org>
Date:   Sun, 11 Sep 2022 13:27:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [RFC PATCH 04/10] dt-bindings: arm: apple: Add t6001/t6002 Mac
 Studio compatibles
Content-Language: en-US
To:     Janne Grunau <j@jannau.net>
Cc:     asahi@lists.linux.dev, Mark Kettenis <kettenis@openbsd.org>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Hector Martin <marcan@marcan.st>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Sven Peter <sven@svenpeter.dev>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220909135103.98179-1-j@jannau.net>
 <20220909135103.98179-5-j@jannau.net>
 <25b42684-1bee-b7f6-a89d-ed0b0ea7428b@linaro.org>
 <20220910113714.GC4024@jannau.net>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220910113714.GC4024@jannau.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/09/2022 13:37, Janne Grunau wrote:
>>>    The compatible property should follow this format:
>>>  
>>> @@ -79,8 +81,15 @@ properties:
>>>            - enum:
>>>                - apple,j314c # MacBook Pro (14-inch, M1 Max, 2021)
>>>                - apple,j316c # MacBook Pro (16-inch, M1 Max, 2021)
>>> +              - apple,j375c # Mac Studio (M1 Max, 2022)
>>>            - const: apple,t6001
>>>            - const: apple,arm-platform
>>
>> Blank line.
> 
> Added. The other entries in this list are not separated by blank lines.  
> What would preferred to fix this? A whitespace only patch or can just 
> add those additional blank lines in this change?

Both would work for me.

Best regards,
Krzysztof