Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp4107037rwn; Sun, 11 Sep 2022 05:25:10 -0700 (PDT) X-Google-Smtp-Source: AA6agR7EkOwczZLTGLkscFKh6hRi7sernFTWe9XKKIhsu3v7Bhp3h28RmLtiDXVZANL0xDQy+9Xv X-Received: by 2002:a05:6402:414d:b0:451:73f0:e113 with SMTP id x13-20020a056402414d00b0045173f0e113mr3599466eda.207.1662899109933; Sun, 11 Sep 2022 05:25:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662899109; cv=none; d=google.com; s=arc-20160816; b=UXvnFJEKRR3WuJv3Xon+FzTnE1UGNDtY0qFiJrUFc3J0J+AbABktBbXgalIebk/N3w s6kqrVCE1pUMsBw/fiz8Oy8bOtHhAb6FFoUJevjWpiJtgkRA++5tknpsYMwI4yStpPe1 tj/Qu5W91Xj++0UmeJd3ARaSrYcUGWGCpTsBe9rpML4JoeuOu2z+dFbfj460Bffr8JeP u0D79IMzwGfNFzeFFF6Jl5ar1oOop2eVoA0VdGf1fd449vZZcix6nf8E09sgumDboCfA JJ2ejwScfh2z6hYiELKS+zvQhkSvi2tPYCSzNNINKof78aETWNdjyqrsH01ujuzDH6ok 659w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ct1Fd3KxfGLYUnS6pekZ1EtMpRHW3F+LfdPHYXgTnSo=; b=UtMN32BLkHoLyAuiYnjsQZqJQe189BLNDH93ReJ1mtQWykX94NQChEN+utoOHZsZnQ IcPxmux16g3uQ4pL8WI/xfSD3PByrDwOUn+hArIlzlcGLDCR+CBymqpMCv32nn7tytM9 EXDnuOIJZScm9kOhftYUVBCwTl7lcjK95WDN69Xli5HrK68i4K59Z/DiMDWFaUaUur8L 9r53qdBdEPdIYN7lFS6I8Efc7TW3KYM0FgSYM+9ziq+n+0NreupqhYU98SUzOnch57FH 8gcsHnNMkc31JVR39+dniKwZDnhHmc3mpnB/9b6J25cQLBFvXlCZUW1SADPCVZ/Ukimr cysQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Le+32p1D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s5-20020a170906c30500b0073dced72063si4436552ejz.570.2022.09.11.05.24.44; Sun, 11 Sep 2022 05:25:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Le+32p1D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230182AbiIKL53 (ORCPT + 99 others); Sun, 11 Sep 2022 07:57:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230136AbiIKL51 (ORCPT ); Sun, 11 Sep 2022 07:57:27 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 595762C13F for ; Sun, 11 Sep 2022 04:57:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1CD9EB80B34 for ; Sun, 11 Sep 2022 11:57:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68F24C433D6; Sun, 11 Sep 2022 11:57:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662897443; bh=mGFSKvyr3J8oywtPSjgu8i64jOtXdSIc9VRry4m1+dQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Le+32p1D6J8gwxQyKiNSm6+En8DaCH38zHSsByO5Vfd+igNTUanZFqy+yuZLUwKc4 j/G/oiovInlKYsI2Vr2mu/YbeBFssFt3/2cVDjwDCrN4hfbVvT5lw/7dE6SVZRV5O9 iJ60Cfe7+NvBF3jlTez9Pw7NfCp2xzIqhmoaUcRq7vF5REFf2OQQ286Yx1SZpbpse1 2AayTjKZJo2VofVXuvH4gmywi8ghq0uXH1C+YIWe0kLDvPjEsSjNnw0s16eCX0qTw7 mn6r6Ydhyf5YzuVv3p4hIYSqzW4JQcH6U45PCpT7scxJgtVKGvzN2T4qmqHRSl/MPG MP24UuHLPcwEw== From: SeongJae Park To: Xin Hao Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm/damon: simplify scheme create in damon_lru_sort_apply_parameters Date: Sun, 11 Sep 2022 11:57:18 +0000 Message-Id: <20220911115718.51465-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220911005917.835-1-xhao@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xin, On Sun, 11 Sep 2022 08:59:17 +0800 Xin Hao wrote: > In damon_lru_sort_apply_parameters(), we can use damon_set_schemes() to > replace the way of creating the first 'scheme' in original code, this > makes the code look cleaner. > > Signed-off-by: Xin Hao Reviewed-by: SeongJae Park Thanks, SJ [...]