Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 11 Sep 2022 20:29:56 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Andrey Konovalov <andreyknvl@gmail.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        kasan-dev <kasan-dev@googlegroups.com>,
        "Sang, Oliver" <oliver.sang@intel.com>
Subject: Re: [PATCH v5 3/4] mm: kasan: Add free_meta size info in struct
 kasan_cache
Message-ID: <Yx3UxJWEXzyWhuqy@feng-clx>
References: <20220907071023.3838692-1-feng.tang@intel.com>
 <20220907071023.3838692-4-feng.tang@intel.com>
 <CA+fCnZeT_mYndXDYoi0LHCcDkOK4V1TR_omE6CKdbMf6iDwP+w@mail.gmail.com>
 <Yx1caGQ8R2alhOKh@feng-clx>
 <CA+fCnZd1bDe9oQcCZjN+NTxs8qF3fzRoXcSZvyeCNxoX6U-wsg@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CA+fCnZd1bDe9oQcCZjN+NTxs8qF3fzRoXcSZvyeCNxoX6U-wsg@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8MH3s0Wd9/Q2sOKdw4D5cO1lUOcMRHHEpvS7w9E2/f9vl+Rs5VqlfEqHhnX4?=
 =?us-ascii?Q?CGisvIgst0j8RQ+GUzRtS7oGiqAOWTpyPeJ8axNozxVO6Grr1PhmkIfx5qrz?=
 =?us-ascii?Q?Xm6OZIwclqVlYymBWIK2z0B9BU4u9n1ggiLj1T0ZRUNID9nSc3BhTAn0Iv3q?=
 =?us-ascii?Q?TXwv9UPEIaeVH9XvXy2K8jyTKbeN25nbhutnz1Hp3JA09TlV5Bjr0G9tfNPG?=
 =?us-ascii?Q?b2Koz/JTCFqSHf8I1QQVgkWWRGcUigRsACN1ssWZniGeal7F6vCow9ZrjKR6?=
 =?us-ascii?Q?bcaQC0FEua7F/tG/5M5rl5NGcK+H/Rvqg+gfkOsD5Uwmve4R+fcfIabZ8iei?=
 =?us-ascii?Q?8pniXX4kc6TL6IymY6qAcQs+O/U1vs8/bes6eHBLL7vQfwS5YfarWS/PKywo?=
 =?us-ascii?Q?PP4mn2GXLXQQk3n14frl5uGTT3PmBseoqhpp1XMovsGwE1f96IWQHwA1amJI?=
 =?us-ascii?Q?916mdVsc73LAbfvEiMiVGf1CvieD5i4ouKyNwQdYaIt1x4BVLvmietNxfSwq?=
 =?us-ascii?Q?J4RFg5/yWVgyZNsPzjts3wQ7feaCGKh8KAtrvJn0qLcFCTu6tF+uHJL5cSg8?=
 =?us-ascii?Q?dTMrlU3MSg9h+D/GUeeKv/EbdKeNUgP3bokJDBWDVaZKzwZ8pLnFyypIVorU?=
 =?us-ascii?Q?YCO7IazmZ0sz8WL8aWRNgkzVc+7X7fd5tyuQM9vwjwOoJNNRn2RVoVRxAS6l?=
 =?us-ascii?Q?QNgsh9Mh9eZ98OVqKmgmg0JazAL9PUmaGQYs/HsvNMIcLll5T8Oif+H2SpMV?=
 =?us-ascii?Q?tT28hTRPHsLE3vMMl5wuJZzQkp1l62tePA1RQx4RTFuLlOUh3iidR/4sd645?=
 =?us-ascii?Q?lBCvpq2PmRn7QdBSifKL3jjHFW/pHaj9hF4MokBVeBB3AUdjp4ltenX3iK0j?=
 =?us-ascii?Q?QVynPc5Sf2L7SLP5jyRZ8SX63l9wBsltMj9s4seU39G1OpP+tz7uu5Khu+Kl?=
 =?us-ascii?Q?Eld06l1Ov0YX+PMIPKGKdXClKK1B330ensnr6iua8jEsNtr6KP3nqKya1xm+?=
 =?us-ascii?Q?IBWn6K4LQAfqDhLce/DX9qmKgWQ398SpkAtysmSeXiQNibcwuZDdAIs4QBxd?=
 =?us-ascii?Q?I/VRc9N5HbZ+58Y0re3ToLBky4ENrTFvMA2dAdZaOJtTS+W6XUHk4d1OT1BU?=
 =?us-ascii?Q?0oKhqUjU4K8AT2Ef1qIdaZlYMGuYf+8OrHfGKhABKmSPmajECMy9PcCkbmDK?=
 =?us-ascii?Q?KE4suI5pkJ1OUywxaSTG48nAx48qRtDyWyHZ10uDMGlDRyjjRXJxOyyL8xdy?=
 =?us-ascii?Q?aqAmVf0Uh37dWFzhDlYbrR1k29SEPkgI7OKQ8CbaOhVkXrje1b6R1rHCvdFY?=
 =?us-ascii?Q?vAf8WHFKkiKAJj6xEPimcWOLMnOPxO7Pa6sY0ucJiy4Bo0/ZJI1Hwu8PrX9y?=
 =?us-ascii?Q?q7l/FUMvFG/Owx0hpO2a5p+If47em56iuBOZQZ8sJzZ2h7izvasVF31M/Foe?=
 =?us-ascii?Q?WXDM+InlUeH3oxjTLi8P2ywow8LyqWdEu13nix9aQpPr9muLI5i5IZX0xqc8?=
 =?us-ascii?Q?+8GO0dWkmRl2oQj+4qkvSJMtwzBQhj4X4l80jlnmhIkgAD6T6xlnqTgjAZrF?=
 =?us-ascii?Q?Xju+p5CtdxK6cRPf5idpfRWWErwagcJz7pc58DLp?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0055d72c-a916-4980-a7d3-08da93f16939
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2022 12:30:28.9540
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eHOOHYDsRvtBzlP2noPKtELeTybb0iBVPA5v6QD8tdOzAz7XTNH4wYIr2vypDzO8KlW6dr8nVi7f8AJCE70v9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4541
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 11, 2022 at 07:51:54PM +0800, Andrey Konovalov wrote:
> On Sun, Sep 11, 2022 at 5:57 AM Feng Tang <feng.tang@intel.com> wrote:
> >
> > Hi Andrey,
> >
> > Thanks for reviewing this series!
> >
> > On Sun, Sep 11, 2022 at 07:14:55AM +0800, Andrey Konovalov wrote:
> > > On Wed, Sep 7, 2022 at 9:11 AM Feng Tang <feng.tang@intel.com> wrote:
> > > >
> > > > When kasan is enabled for slab/slub, it may save kasan' free_meta
> > > > data in the former part of slab object data area in slab object
> > > > free path, which works fine.
> > > >
> > > > There is ongoing effort to extend slub's debug function which will
> > > > redzone the latter part of kmalloc object area, and when both of
> > > > the debug are enabled, there is possible conflict, especially when
> > > > the kmalloc object has small size, as caught by 0Day bot [1]
> > > >
> > > > For better information for slab/slub, add free_meta's data size
> > > > into 'struct kasan_cache', so that its users can take right action
> > > > to avoid data conflict.
> > > >
> > > > [1]. https://lore.kernel.org/lkml/YuYm3dWwpZwH58Hu@xsang-OptiPlex-9020/
> > > > Reported-by: kernel test robot <oliver.sang@intel.com>
> > > > Signed-off-by: Feng Tang <feng.tang@intel.com>
> > > > Acked-by: Dmitry Vyukov <dvyukov@google.com>
> > > > ---
> > > >  include/linux/kasan.h | 2 ++
> > > >  mm/kasan/common.c     | 2 ++
> > > >  2 files changed, 4 insertions(+)
> > > >
> > > > diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> > > > index b092277bf48d..293bdaa0ba09 100644
> > > > --- a/include/linux/kasan.h
> > > > +++ b/include/linux/kasan.h
> > > > @@ -100,6 +100,8 @@ static inline bool kasan_has_integrated_init(void)
> > > >  struct kasan_cache {
> > > >         int alloc_meta_offset;
> > > >         int free_meta_offset;
> > > > +       /* size of free_meta data saved in object's data area */
> > > > +       int free_meta_size_in_object;
> > >
> > > I thinks calling this field free_meta_size is clear enough. Thanks!
> >
> > Yes, the name does look long. The "in_object" was added to make it
> > also a flag for whether the free meta is saved inside object's data
> > area.
> >
> > For 'free_meta_size', the code logic in slub should be:
> >
> >   if (info->free_meta_offset == 0 &&
> >         info->free_meta_size >= ...)
> 
> I'd say you can keep the current logic and just rename the field to
> make it shorter. But up to you, I'm fine with either approach. Thanks!

OK, I don't have strong opinion either. As the comment for that
member clearly stats it's for inside-data size info, we could use
the shorter name.

Thanks,
Feng