Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: hTkFQDrU1o7RwuYb1Sl6dtiKoc3Z5YXbX6oKPJliRnagFIDQnh13fLJwLiGXlRcGfTfs0XSjO9
 fWJKoNxTw/iFzayQULXDiiOWqwCDphtgCeFoX+0fnLoueu5p98Y+tGCpMDVtY1Ebv9ztCoAsJm
 KJoE1FERUmbd58fYJvGcD+VHsAruAKrd+5wYhNjalKbD7cw2uEWlmEzdKaCWn+KssWFq+hVo57
 HdY1wfaciCE3hKlvjQm1GeOYTAFcheotr73W7I/CibyUYzb27HJGZcJxXgpTdUT4zUDsZAtEfX
 mx3KMYZ3nP/Z1sxagVXVlE5T
IronPort-SDR: 1mnUHHepEJLCFhb8lnxdId8plX1yCiq/hhjjVsCoheQF0c2Umr6xneRT5A5o81Vj2jhFSe+KZy
 PlvcysCHuBcIhDTGHvL9X9bjv5dyd29N9t2VpZWypCxpzWtonML2ns4IMUDQZ50VEsg9+yBaHl
 sy5cj+zrHGWKOZe37p/idBc2yrvrhoKgefeRBSNt8qEFC7BCPH7vkXRvkEzDYPbyg/aKBJCyld
 bTVVBmuvrMsBpc4vKSq7J0/1PoXoguPkzf9hH8HY0wgnukJVHukmJepAy80GGfFevvVUwoPHEN
 uLo=
WDCIronportException: Internal
Message-ID: <0ad5f339-de31-2849-34a1-928ae65cc696@opensource.wdc.com>
Date:   Sun, 11 Sep 2022 20:54:46 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.2
Subject: Re: [PATCH v2] powerpc: select HAVE_PATA_PLATFORM in PPC instead of
 creating a PPC dependency
To:     Arnd Bergmann <arnd@arndb.de>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Cc:     "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220909090343.21886-1-lukas.bulwahn@gmail.com>
 <21359abe-c3c9-4aa8-8ebf-75ff64cb1935@www.fastmail.com>
 <2379456e-4f18-d619-10bf-022327de0463@csgroup.eu>
 <4b33bffc-2b6d-46b4-9f1d-d18e55975a5a@www.fastmail.com>
Content-Language: en-US
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <4b33bffc-2b6d-46b4-9f1d-d18e55975a5a@www.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 2022/09/09 20:31, Arnd Bergmann wrote:
> On Fri, Sep 9, 2022, at 1:19 PM, Christophe Leroy wrote:
>> Le 09/09/2022 =C3=A0 13:09, Arnd Bergmann a =C3=A9crit=C2=A0:
>>> On Fri, Sep 9, 2022, at 11:03 AM, Lukas Bulwahn wrote:
>>>
>>> I don't see a single powerpc machine that creates a
>>>   name=3D"pata_platform" platform_device. I suspect this was
>>> only needed bwfore 2007 commit 9cd55be4d223 ("[POWERPC] pasemi:
>>> Move electra-ide to pata_of_platform"), so the "|| PPC"
>>> bit should just get removed without adding the HAVE_PATA_PLATFORM
>>> bit.
>>
>> But that was added in 2008 by commit 61f7162117d4 ("libata:=20
>> pata_of_platform: OF-Platform PATA device driver")
>=20
> Ah, I see. In that case, I think we should probably just always
> allow PATA_OF_PLATFORM to be enabled regardless of
> HAVE_PATA_PLATFORM, something like
>=20
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 1c9f4fb2595d..c93d97455744 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -1102,8 +1102,7 @@ config PATA_PCMCIA
>  	  If unsure, say N.
> =20
>  config PATA_PLATFORM
> -	tristate "Generic platform device PATA support"
> -	depends on EXPERT || PPC || HAVE_PATA_PLATFORM
> +	tristate "Generic platform device PATA support" if EXPERT || HAVE_PAT=
A_PLATFORM

Shouldn't this be:

	tristate "Generic platform device PATA support" if EXPERT || PPC

?

And while at it, it would be nice to add "|| COMPILE_TEST" too.

>  	help
>  	  This option enables support for generic directly connected ATA
>  	  devices commonly found on embedded systems.
> @@ -1112,7 +1111,8 @@ config PATA_PLATFORM
> =20
>  config PATA_OF_PLATFORM
>  	tristate "OpenFirmware platform device PATA support"
> -	depends on PATA_PLATFORM && OF
> +	depends on OF
> +	select PATA_PLATFORM
>  	help
>  	  This option enables support for generic directly connected ATA
>  	  devices commonly found on embedded systems with OpenFirmware
>=20
> and then also drop the "select HAVE_PATA_PLATFORM" from
> arm64 and arm/versatile.
>=20
> Or we can go one step further, and either split out the
> 'pata_platform_driver' into a separate file from
> '__pata_platform_probe', or merge pata_of_platform.c
> back into pata_platform.c.
>=20
>       Arnd

--=20
Damien Le Moal
Western Digital Research