Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220910190303.682897-1-mwen@igalia.com>
In-Reply-To: <20220910190303.682897-1-mwen@igalia.com>
From:   Dave Airlie <airlied@gmail.com>
Date:   Sun, 11 Sep 2022 22:29:52 +1000
Message-ID: <CAPM=9txFJcKivJn=k2_n=PJt646vcvBN=5m3zxXojYew1E4gaQ@mail.gmail.com>
Subject: Re: [PATCH v2] drm/vkms: fix 32bit compilation error by replacing macros
To:     Melissa Wen <mwen@igalia.com>
Cc:     rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com,
        Dave Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, igormtorrente@gmail.com,
        kernel test robot <lkp@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, 11 Sept 2022 at 05:03, Melissa Wen <mwen@igalia.com> wrote:
>
> Replace vkms_formats macro for fixed-point operations with functions
> from drm/drm_fixed.h to do the same job and fix 32-bit compilation
> errors.
>
> v2:
> - don't cast results to s32 (Igor)
> - add missing drm_fixp2int conversion (Igor)

btw I've applied this in drm-next, as otherwise I can't build my
32-bit arm build.

Dave.