Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: dca/WEYOpMgd5J2vtZltinpb8KwqgWN4TIGPzxEv0JUWyW6Q9up5acpBVhXRKceTIxY9g9xKRv
 bw523sj2vqXl9xqnJbMgpVhNZnjq4B8NuCi+ZETa0/BcxL/jY6WVAoGHToyoUsSeGOEgQnLSI2
 dB0wfBsKvLAM5eO4P/JUzZEs0WE//xbJmRdPIKJspKBeRiIMHOtBFtH1E8eTyI4yaxiMky99ZQ
 Ph3IJUMGQ5xntmCQIrb8Jyq4D3Jae3KDV5A+P0xHxISPFVVAdlVTFlbsrpvxz2vQ0Y2tjgfv7P
 DnrKM4iiqgs0P0ACb8qu8FKM
IronPort-SDR: CoSAOp//LA6y6q8Z5Zm8ZV8lFvA20rUm+7u97hOqbrsQrQ3bj6wbMuqQJXaACOqBBsTIXBbw66
 aINI7PbPewmQNeRTITPXmWZhPotSXSJn4l9XbEKsQJnqxDNVbtBsbFyowhTtXd9x8z1kN8uVdF
 I8ZteOVAZRMyqI802/uNhUhjiYVEBBvKEVjWB7zUZSGvYbeACst+mdyCmmjN2yzoFLoaluAhS2
 P97ISyySZN8Yj27jXeYh4ekxHLGzdQ2Ytku9W4iHWqnSoSO+bxn+xLAMMCPSsZpe33Rpa3bmen
 VLk=
WDCIronportException: Internal
Message-ID: <99d7c533-f19e-a52a-e532-2a07cd78e9b9@opensource.wdc.com>
Date:   Sun, 11 Sep 2022 23:18:40 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.2.2
Subject: Re: [PATCH v2] powerpc: select HAVE_PATA_PLATFORM in PPC instead of
 creating a PPC dependency
Content-Language: en-US
To:     Arnd Bergmann <arnd@arndb.de>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Cc:     "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220909090343.21886-1-lukas.bulwahn@gmail.com>
 <21359abe-c3c9-4aa8-8ebf-75ff64cb1935@www.fastmail.com>
 <2379456e-4f18-d619-10bf-022327de0463@csgroup.eu>
 <4b33bffc-2b6d-46b4-9f1d-d18e55975a5a@www.fastmail.com>
 <0ad5f339-de31-2849-34a1-928ae65cc696@opensource.wdc.com>
 <c4f3d527-7e70-4077-b40b-129144d79374@www.fastmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <c4f3d527-7e70-4077-b40b-129144d79374@www.fastmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/09/11 21:41, Arnd Bergmann wrote:
> On Sun, Sep 11, 2022, at 1:54 PM, Damien Le Moal wrote:
>> On 2022/09/09 20:31, Arnd Bergmann wrote:
>>>  
>>>  config PATA_PLATFORM
>>> -	tristate "Generic platform device PATA support"
>>> -	depends on EXPERT || PPC || HAVE_PATA_PLATFORM
>>> +	tristate "Generic platform device PATA support" if EXPERT || HAVE_PATA_PLATFORM
>>
>> Shouldn't this be:
>>
>> 	tristate "Generic platform device PATA support" if EXPERT || PPC
>>
>> ?
>>
>> And while at it, it would be nice to add "|| COMPILE_TEST" too.
> 
> The idea was that this can be selected by CONFIG_PATA_OF_PLATFORM
> in any configuration that has CONFIG_OF enabled. Since PPC
> has CONFIG_OF enabled unconditionally, there is no need to
> make this option visible separately.
> 
> Same for compile-testing: since CONFIG_OF can be enabled on
> any architecture, PATA_OF_PLATFORM is already covered by
> allmodconfig builds anywhere. The separate HAVE_PATA_PLATFORM
> is only needed for machines that want the non-OF pata-platform
> module (sh, m68k-mac, mips-sibyte arm-s3c-simtec).

Got it. Thanks for the details.

> 
>        Arnd

-- 
Damien Le Moal
Western Digital Research