Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e8ce8fb4-baac-b3a5-5d6d-418e20c8d2d9@igalia.com>
Date:   Sun, 11 Sep 2022 11:36:00 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH V2] efi: efibc: Guard against allocation failure
Content-Language: en-US
To:     ardb@kernel.org,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        linux-efi@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, kernel-dev@igalia.com,
        kernel@gpiccoli.net, matt@codeblueprint.co.uk, mjg59@srcf.ucam.org
References: <20220909194214.186731-1-gpiccoli@igalia.com>
 <04d65bd7-a6b2-bb14-fd69-632542ae9e86@wanadoo.fr>
From:   "Guilherme G. Piccoli" <gpiccoli@igalia.com>
In-Reply-To: <04d65bd7-a6b2-bb14-fd69-632542ae9e86@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/09/2022 01:56, Christophe JAILLET wrote:
> [...]
>>   	wdata = kmalloc(MAX_DATA_LEN * sizeof(efi_char16_t), GFP_KERNEL);
> Hi,
> 
> even if mostly useless in this case, kmalloc_array()?
> 
> Or certainly maybe even better, kstrndup()?
> 
> CJ
> 

Thanks! It's up to Ard, I could rework with this change if makes sense.
Cheers,


Guilherme