Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp4311983rwn; Sun, 11 Sep 2022 09:15:23 -0700 (PDT) X-Google-Smtp-Source: AA6agR7IPGQVEqIsFsTf6g6s/o3WwPs7XXAKqZXn8NhLsJP4jr1AzG7UT80QQSe13nWhsXDp5wlX X-Received: by 2002:a05:6402:84d:b0:435:a764:9aad with SMTP id b13-20020a056402084d00b00435a7649aadmr20165496edz.332.1662912923280; Sun, 11 Sep 2022 09:15:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662912923; cv=none; d=google.com; s=arc-20160816; b=wsYDroxbmOwI+TU7v3hWt7pbSQoEUf9d4B0JgprTDazPB742Opszc2nwfGJqRf54d5 m2bZ+pr69Xkwe9AS3rfjdWDNrcFeRqyzvYdUbW1KiGmQ8pjEOc8HtlIt+wDdfG7HTT8L IesZ19PWNVEON2FkfgoyRepnMz7KBrXqXErBvgO6v57ofryXie+Bwa7wPblPx8Cx82l3 B1mF6jhAv9sl5JB2wvKEcbDyfMHD1guimKEDkS0QSAQkPKhZkfhOVCpQzZtatIk47IML J4bbFF0RafFhXIRH/c2fCgLklpEpU13fo5s2PpABDlcJbucaUfa0mp/yMFc/ETfN9bug RySw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OXqvDfMO3yo4jyLaEpdKmbXpj6kJzDaw7s0LNfWous0=; b=QsQMFo0MPsKEIW+oj79TYFupOTrVFFwRKkf8YTWQGci8R5mB7VIkun2Ym4XMVqPKf1 hQGzE4hoL4gZ2dkPBv0fOIdUIOEPtjHYbelpacX8krwqDKCsu/ohO5IBKWjEQhlM0g6U 7+2cgsWjBI1NqsjLUqTPRBa61reRtXYUXax5vYK8OC6lHG5c2FiYXUzXA+F1LrisdMPf mLPjPMZNkDizfNujV5js0thNxdVldOiK0NRFSpgUV8gtXd8nWyk7Ufx9K3LPHdvG2cHE ffNbqoRjTl0mUFMJQzf/gDJ0nQKhDDy3DV+BgCPVp9QRYNk+sj9o4+aVpwkMJ/KbwlrR iNqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=lMrN9+3w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr11-20020a170907720b00b0073d6c94fc3dsi4641769ejc.162.2022.09.11.09.14.57; Sun, 11 Sep 2022 09:15:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=lMrN9+3w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229665AbiIKQI6 (ORCPT + 99 others); Sun, 11 Sep 2022 12:08:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbiIKQI4 (ORCPT ); Sun, 11 Sep 2022 12:08:56 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4B342A738; Sun, 11 Sep 2022 09:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OXqvDfMO3yo4jyLaEpdKmbXpj6kJzDaw7s0LNfWous0=; b=lMrN9+3wyfjxun3GCFnAAivwQ0 lDnXt4umgwhm0yW4JX+yRLJ1jaM26SZmJZ4XztpXr6hp45ajPs3tD30aHV8Q2g2pH1tdFTBWuJeEl KKAshW0GzHEiOecsKR4wyDseSBJCByvXszz7IyevSAdHG+5Z/SJNJZv5mAQVxwAM8i49TNd+ZJwoL Qa49blWO8g+OOUSS+ot0tFb9OKg3xZHUv0JLhKW9atYcYEeYqm+k9xzXHLA4XCjWN9vRiO6EIXGbd ETJXuIWvzg3F7cEdcioGDE3JtZJg3aqEXT/+n1TcdIGFmqJvSA8PHGdgiVLOwtjhMnyVtMbL47KBy lanGTTEA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXPVq-00FB0o-Kr; Sun, 11 Sep 2022 16:08:50 +0000 Date: Sun, 11 Sep 2022 17:08:50 +0100 From: Matthew Wilcox To: Pasha Tatashin Cc: akpm@linux-foundation.org, corbet@lwn.net, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, rick.p.edgecombe@intel.com Subject: Re: [PATCH 2/3] mm/page_table_check: Do WARN_ON instead of BUG_ON by default Message-ID: References: <20220911095923.3614387-1-pasha.tatashin@soleen.com> <20220911095923.3614387-3-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220911095923.3614387-3-pasha.tatashin@soleen.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 11, 2022 at 09:59:22AM +0000, Pasha Tatashin wrote: > Currently, page_table_check when detects errors panics kernel. Instead, > print a warning, and panic only when specifically requested via kernel > parameter: > > page_table_check=panic Why are the page table checks so special that they deserve their own command line parameter? Why shouldn't this be controlled by the usual panic_on_warn option?