Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Colin Foster <colin.foster@in-advantage.com>
To:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Russell King <linux@armlinux.org.uk>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>, UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Lee Jones <lee@kernel.org>
Subject: [RFC v1 net-next 6/8] net: dsa: felix: populate mac_capabilities for all ports
Date:   Sun, 11 Sep 2022 13:02:42 -0700
Message-Id: <20220911200244.549029-7-colin.foster@in-advantage.com>
In-Reply-To: <20220911200244.549029-1-colin.foster@in-advantage.com>
References: <20220911200244.549029-1-colin.foster@in-advantage.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8GT62Il9qja0vOQCC3bil2WAsBpgbRgd/AvUm5yW7/ASw9OGOk9xddKSi7IJ?=
 =?us-ascii?Q?ap0/MaO7IWWXsqdCF/xXuqfW4gw8UkjGVdYobI3QCWVSDqWftASVX9pkKWnh?=
 =?us-ascii?Q?Nc7CKSzYDnBigDWBLdo9TR2H49kZNXEoiNDFFygnc3yNu6QyiU4JOX9Atn4v?=
 =?us-ascii?Q?Zs/Zvcuuj/hNPMNbyX/cpMIIcWCx7aM+9thFIecuePHfKedTaFPKeSnf7piA?=
 =?us-ascii?Q?QCm50lrS9ki3+WYTVtScbAOZb+tp/eUICjFkdjaNO4XHD3e7GfUwtoefYW+P?=
 =?us-ascii?Q?0kjN1baXHZebWxRBX0uumFq/cQiemqQ8iz8F2Rx0wttrTaQ78p89PzljA9sM?=
 =?us-ascii?Q?cysyGd8raFDofx3TrnWdV6MQWygjWdWy0lQHWCApQkvXEYosjPfzTKaKlpSn?=
 =?us-ascii?Q?SKeCzxFF1dG9mmRhROoTC/MXugoFBn+yjgHHspusLGN+wOFwJoMzvswmh/jq?=
 =?us-ascii?Q?ZkTn3HMgT15i8sv5EkuOH0K1SfXeZAGhPl/FCN2DPqgQsCQvX8m99bVXRQMr?=
 =?us-ascii?Q?DL5HHxoJP1zel+nfQqDBCYx1ifQwzmH+0riCnF74kTHharqdGyTUqsnykdcP?=
 =?us-ascii?Q?JxEsP/QSAJB+Jvg1J4HpVMcLWEGa780TILn1OU0AoTviahrq04S3acP3B5SB?=
 =?us-ascii?Q?aY02WrjTTHE9gBbbXlhXyr699VMiTVrEq2PF4mHVnsRRe8zGoilSIurpT6ms?=
 =?us-ascii?Q?+4I44WuBYz3kDTN5OhnoJdCtkuOKYHgGWCppYVDaeWxw+t+7+btsxMvmb4HB?=
 =?us-ascii?Q?pK81BzZotVjNgqGLAdJXU0W+LgcxHfmv1eZEINnfZ3xNnI5Eo6sju4hrifDh?=
 =?us-ascii?Q?I/wG5BhI3zKMGrHGOn93vSno/H3HnvjsgPI4DZ6NkElZ/m2Mani7HAX8EPEN?=
 =?us-ascii?Q?SxO8Dt2yVYfoPJwwhBGmo0xTgTF6imdJ1ejz/8ASsxFZuQ/VHsgyGtbt3UVq?=
 =?us-ascii?Q?D8cdX2a4phzx3dSoorqvB/ef9seijnQkp/WtJFNNBgo1i0+DCZW/wEt8sNLL?=
 =?us-ascii?Q?EMy2vsPP88GW3QLSSFVY6wYFTm2Lgmc/XuyqsMTIZzgKh2yjExW5AC9D9BCy?=
 =?us-ascii?Q?Aa/dVuAorhLeUYiQvtcCct4mduqCpbyaG9CsVPCLmFUgt65R+od7LiKJqHkm?=
 =?us-ascii?Q?18BhvUF8W9l1IbSmgFSsPgXzh12cQV/jLu4G6Px+22SqAwSUF5n8myTtQxU5?=
 =?us-ascii?Q?kOox2rlb/l90xkKCwrLG44gyXFPc4KNx2e4HHG+QzC51hyw8wnkqMF6fuZJS?=
 =?us-ascii?Q?zjWhJ6Wbrbffp0lxvBfIbZ/XC9IxWWzmMPNRrL8R2dih1KVjM6eNOScDWDK7?=
 =?us-ascii?Q?oHIfcLuer6z0QPZDLaptX1sTUTPVgjp/GOEvSNrwa8x3nZ68kC5t7OPmQNge?=
 =?us-ascii?Q?831yjAyX5x0kYxxju+lQHyt1KhT3rED8Eo1Dj0nHJq7hMuqCAF/WNBe3EhqU?=
 =?us-ascii?Q?v40Ef1oJQANO3UPlu1wxyRuRnujBPfwnH1eo+/Cryy91PIxFQgBHW7hAyYGm?=
 =?us-ascii?Q?9kggLXYeXGNfMeHhIMZZ4of6qsU8xCCMMcaOH+aULYXg9qXs1K2VrkVU8puY?=
 =?us-ascii?Q?HJkZ0fw9DVyPkwMZiQ7dv0nqz4t6J6aJY/kuuSoFElm2PuWLlDBz5jOhTHz4?=
 =?us-ascii?Q?yg=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5eacb02b-e21c-485c-648d-08da94309f10
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2022 20:02:57.5901
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PiWjnK30hWU5kETeR2rm4SPeoa9D7QO1OZ+0C1djtkW3Ckw4iv4P71wyRnW9aLsSb3i1MThrYPV61AlVuTBLVKhRgWHDENBdFo6EC8WMsNw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5335
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

phylink_generic_validate() requires that mac_capabilities is correctly
populated. While no existing drivers have used phylink_generic_validate(),
the ocelot_ext.c driver will. Populate this element so the use of existing
functions is possible.

Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
---

v1 from previous RFC:
    * New patch

---
 drivers/net/dsa/ocelot/felix.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index 95a5c5d0815c..201bf3bdd67d 100644
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -958,6 +958,9 @@ static void felix_phylink_get_caps(struct dsa_switch *ds, int port,
 
 	__set_bit(ocelot->ports[port]->phy_mode,
 		  config->supported_interfaces);
+
+	config->mac_capabilities = MAC_SYM_PAUSE | MAC_ASYM_PAUSE | MAC_10 |
+				   MAC_100 | MAC_1000FD | MAC_2500FD;
 }
 
 static void felix_phylink_validate(struct dsa_switch *ds, int port,
-- 
2.25.1