Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <850b8cf5-27b6-9b12-a5af-bdd4b5b3d9a4@amd.com>
Date:   Mon, 12 Sep 2022 08:51:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3 3/6] dma-buf: Enable signaling on fence for selftests
Content-Language: en-US
To:     Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220909170845.4946-1-Arvind.Yadav@amd.com>
 <20220909170845.4946-4-Arvind.Yadav@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220909170845.4946-4-Arvind.Yadav@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wk50bzZOUnJOVlErNld1LzcrdTV5ZG15ZExHaGtWanBlekhpZEpBOWlsWDFn?=
 =?utf-8?B?QXoyK0xFTThNMHdqWmphMy9DdGVwdkxlWHpWZU44dDk0Qzl4bGFPKytRVitF?=
 =?utf-8?B?MzczcjlCT3VKczBib2FuMWFycXdnb29obnZNU3o2MjVsazdyUVp3Rkk2MEs5?=
 =?utf-8?B?RG5oc2FrU3FZZVJ0R0RYUGhMT2NRZ0Ztd1RQSG03TFBaUUxmZG4xNGdUSDRB?=
 =?utf-8?B?WHRKNkpEeVZNcFNma1NRTHNRS1dJN0htYU9XSmpDa253RTlzcjQwVHRzRHR1?=
 =?utf-8?B?M25jWWt2dFNyR2MzWlB1OStkR1Bxa0JJOVA4eDBiZExYTFpNN0E4YVUwRzFM?=
 =?utf-8?B?YmN3UTVYY0JxWnhNVXZOSXd4TDdKWVgrcDNtaDlvVXFqN1l4OUR5SDBNVGY2?=
 =?utf-8?B?b21nVVB4cFRtZ2Z0VmY3L2d4Wlhvdi9NdWU3NUxXNENGRDUwaGNwaC80ZGNv?=
 =?utf-8?B?YTBHL3VCbzJZUk92WkZJQjhLWVpEc1ZoMTh0ZGZ6eE9vbUJlaXhZbWYrTURi?=
 =?utf-8?B?NGQwTGY0RlZnMzQzR0d1aHZlSjkvNzUzMzZURXI3L1pjU3FkQlZMdmYxQXU3?=
 =?utf-8?B?ZTZWTGdCUGc1d0FmRkNiL2xxS3lab0FOaTF2SnRkclVpUUwrZlFoVUVFUEkr?=
 =?utf-8?B?NlNVOG51RXN2TC9Xcml0MXJqN3JMQ2k4TkIzNlkxS1FBTGZWUllxMUVVNklz?=
 =?utf-8?B?WDBBaFZMcldaOTNXTGxtOUwzS0xBSVNqV0x5WS94eFpwS1lHejZIYThtR3ZD?=
 =?utf-8?B?WmtQL3k0dzZ3YU5kVEpIdXE0V1VMMGhlVDg0Z0FkVngzOXpSZ1orQUc1a2t2?=
 =?utf-8?B?bFRQTVhqcUhuSFFDaFpNUGlDYlJadlBJY2JNYlZDWFkrLzhsL1pqZ09RWVhC?=
 =?utf-8?B?dUlLRmMrTFRJSEc2bUJBaEN1NWM3ek1NNGZOVk9XdDAraVNjMEJZd011M2JD?=
 =?utf-8?B?NUk3aFhUa2NVUHhnNXJnTlluSTdsdnl5a0pFY0NwdHFUMjBsRHJvYU9DNXUv?=
 =?utf-8?B?ZktxVjVuM01IdDlpU25Sb0w1cTc5VXZ3MFA0ZE5lTnhaQmZ0VVlwdDFxVXdx?=
 =?utf-8?B?Wk5CMFVPencwMitJNU1lR1lxWC9zSXFIOGZ1M0VXdENrNzVyYjY0cVlIUW1v?=
 =?utf-8?B?TWNOdUdaZ09ScDBYZE9KRkJCTFBTcGtmYVVTV2RmckEyN1hiMzFhUzBxZlJB?=
 =?utf-8?B?TmpoTzhKTjRycEtaU0RBcm43STI0TjFlbmtLU1BGc243WU0vajhWdlIxWm1T?=
 =?utf-8?B?bjhOMkFSZDluWG9xU3FaWUtGdDlEOHY5ODJnUXozMDB0TWtPemdIREFmYnNu?=
 =?utf-8?B?ZEdiVEpZR29NRWdpRjRkUTczdjBXOUtLSlkyWlQyTi9xbUlkWStYZFdDeXFB?=
 =?utf-8?B?aVpwTmNRMDVEV3ZSZEJmemZMLytWSndpY0VBNU1sUlFRWGkyYmh1UlZzVDUy?=
 =?utf-8?B?WFJaTFZJTE02TzM1RC9oaWRqQWYyNlAyb1F5RGtJYTJsUDlFcU5Db25PNjRW?=
 =?utf-8?B?b01YL3hmWlNxVHN4dTJPU2crNVVvczBOQWZoSDgrUzBrQmowNFFYSzVQdjhp?=
 =?utf-8?B?UTkzZGxjSGFLMEJkSDlYQkZyaHozREJhdUJXc3l2TVJ5K2FVNGpHK01iYTR1?=
 =?utf-8?B?M1J5elNhY1FVMW1NZFBZWFhiK3NwZEZKUFVRcndxVU1pWGQwNVlRZWtwL24x?=
 =?utf-8?B?Q3Vkd3VUWElNUDlxTnI5WklmN1hjc1pRRGduK3BKZVo1bi9rTlZENDR2MjJN?=
 =?utf-8?B?VHZNR0lYMXJNTlJxTlJtbWtESllKZmpXdVZqSWhZTlZudVEwNkVzNitqaVIr?=
 =?utf-8?B?cWlIbUtUdEU5S09IYWhUQmZMWFJKY05venZpZXVHNitxcW5ZREFPbC9lV241?=
 =?utf-8?B?NDBLRy9PZmNSUlVMelg5WjFIUTNuL0Y1Nm5GWlJVR0FDcStQT1g3Yk5ueE5U?=
 =?utf-8?B?MUpHTkxWbHZoOHhOaHk3OHd4QXd3NTlKOWJqU3dhM2laK0I4U0NIamVVUTlO?=
 =?utf-8?B?b2x5QTVONnFjZlp1YXJ1UCszb2VRWWZnS0FDdzFuWHkrWU5VOVFLSS9ITFpR?=
 =?utf-8?B?VWFSbzE4c1V3UTc0MUNUTUFOeGI5aFdpeGx5cWlRblFZSDl4TEdWTHVKSTJ0?=
 =?utf-8?B?MnNsSmIrVFdHMzR2ZWxDcno5Znhrc2NqZWc2UTBZYUlCNDdrM24wcjdDZ0My?=
 =?utf-8?Q?HYodj0aWeU8xp7gbDNDJhHoN+opQmqiqpvE8lZPGYMBv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92b628e6-0e5f-468a-8e0c-08da948b3308
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 06:51:20.5160
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pDj1gKPOZ3VctiqAWDf3aFP78Laa1VruQhKlRnLm3zqO7OOLBeGtVXsMr0Bn88tb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6794
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 09.09.22 um 19:08 schrieb Arvind Yadav:
> Here's enabling software signaling on fence for selftest.
>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>
> Changes in v1 :
> 1- Addressing Christian's comment to remove unnecessary callback.
> 2- Replacing CONFIG_DEBUG_WW_MUTEX_SLOWPATH instead of CONFIG_DEBUG_FS.
> 3- The version of this patch is also changed and previously
> it was [PATCH 4/4]
>
> Changes in v2 :
> 1- #ifdef CONFIG_DEBUG_WW_MUTEX_SLOWPATH removed
>
> ---
>   drivers/dma-buf/st-dma-fence-chain.c  |  4 ++++
>   drivers/dma-buf/st-dma-fence-unwrap.c | 22 ++++++++++++++++++++++
>   drivers/dma-buf/st-dma-fence.c        | 16 ++++++++++++++++
>   drivers/dma-buf/st-dma-resv.c         | 10 ++++++++++
>   4 files changed, 52 insertions(+)
>
> diff --git a/drivers/dma-buf/st-dma-fence-chain.c b/drivers/dma-buf/st-dma-fence-chain.c
> index 8ce1ea59d31b..0a9b099d0518 100644
> --- a/drivers/dma-buf/st-dma-fence-chain.c
> +++ b/drivers/dma-buf/st-dma-fence-chain.c
> @@ -87,6 +87,8 @@ static int sanitycheck(void *arg)
>   	if (!chain)
>   		err = -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(chain);
> +
>   	dma_fence_signal(f);
>   	dma_fence_put(f);
>   
> @@ -143,6 +145,8 @@ static int fence_chains_init(struct fence_chains *fc, unsigned int count,
>   		}
>   
>   		fc->tail = fc->chains[i];
> +
> +		dma_fence_enable_sw_signaling(fc->chains[i]);
>   	}
>   
>   	fc->chain_length = i;
> diff --git a/drivers/dma-buf/st-dma-fence-unwrap.c b/drivers/dma-buf/st-dma-fence-unwrap.c
> index 4105d5ea8dde..f0cee984b6c7 100644
> --- a/drivers/dma-buf/st-dma-fence-unwrap.c
> +++ b/drivers/dma-buf/st-dma-fence-unwrap.c
> @@ -102,6 +102,8 @@ static int sanitycheck(void *arg)
>   	if (!f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f);
> +
>   	array = mock_array(1, f);
>   	if (!array)
>   		return -ENOMEM;
> @@ -124,12 +126,16 @@ static int unwrap_array(void *arg)
>   	if (!f1)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f1);
> +
>   	f2 = mock_fence();
>   	if (!f2) {
>   		dma_fence_put(f1);
>   		return -ENOMEM;
>   	}
>   
> +	dma_fence_enable_sw_signaling(f2);
> +
>   	array = mock_array(2, f1, f2);
>   	if (!array)
>   		return -ENOMEM;
> @@ -164,12 +170,16 @@ static int unwrap_chain(void *arg)
>   	if (!f1)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f1);
> +
>   	f2 = mock_fence();
>   	if (!f2) {
>   		dma_fence_put(f1);
>   		return -ENOMEM;
>   	}
>   
> +	dma_fence_enable_sw_signaling(f2);
> +
>   	chain = mock_chain(f1, f2);
>   	if (!chain)
>   		return -ENOMEM;
> @@ -204,12 +214,16 @@ static int unwrap_chain_array(void *arg)
>   	if (!f1)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f1);
> +
>   	f2 = mock_fence();
>   	if (!f2) {
>   		dma_fence_put(f1);
>   		return -ENOMEM;
>   	}
>   
> +	dma_fence_enable_sw_signaling(f2);
> +
>   	array = mock_array(2, f1, f2);
>   	if (!array)
>   		return -ENOMEM;
> @@ -248,12 +262,16 @@ static int unwrap_merge(void *arg)
>   	if (!f1)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f1);
> +
>   	f2 = mock_fence();
>   	if (!f2) {
>   		err = -ENOMEM;
>   		goto error_put_f1;
>   	}
>   
> +	dma_fence_enable_sw_signaling(f2);
> +
>   	f3 = dma_fence_unwrap_merge(f1, f2);
>   	if (!f3) {
>   		err = -ENOMEM;
> @@ -296,10 +314,14 @@ static int unwrap_merge_complex(void *arg)
>   	if (!f1)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f1);
> +
>   	f2 = mock_fence();
>   	if (!f2)
>   		goto error_put_f1;
>   
> +	dma_fence_enable_sw_signaling(f2);
> +
>   	f3 = dma_fence_unwrap_merge(f1, f2);
>   	if (!f3)
>   		goto error_put_f2;
> diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
> index c8a12d7ad71a..fb6e0a6ae2c9 100644
> --- a/drivers/dma-buf/st-dma-fence.c
> +++ b/drivers/dma-buf/st-dma-fence.c
> @@ -102,6 +102,8 @@ static int sanitycheck(void *arg)
>   	if (!f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f);
> +
>   	dma_fence_signal(f);
>   	dma_fence_put(f);
>   
> @@ -117,6 +119,8 @@ static int test_signaling(void *arg)
>   	if (!f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f);
> +
>   	if (dma_fence_is_signaled(f)) {
>   		pr_err("Fence unexpectedly signaled on creation\n");
>   		goto err_free;
> @@ -190,6 +194,8 @@ static int test_late_add_callback(void *arg)
>   	if (!f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f);
> +
>   	dma_fence_signal(f);
>   
>   	if (!dma_fence_add_callback(f, &cb.cb, simple_callback)) {
> @@ -282,6 +288,8 @@ static int test_status(void *arg)
>   	if (!f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f);
> +
>   	if (dma_fence_get_status(f)) {
>   		pr_err("Fence unexpectedly has signaled status on creation\n");
>   		goto err_free;
> @@ -308,6 +316,8 @@ static int test_error(void *arg)
>   	if (!f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f);
> +
>   	dma_fence_set_error(f, -EIO);
>   
>   	if (dma_fence_get_status(f)) {
> @@ -337,6 +347,8 @@ static int test_wait(void *arg)
>   	if (!f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f);
> +
>   	if (dma_fence_wait_timeout(f, false, 0) != -ETIME) {
>   		pr_err("Wait reported complete before being signaled\n");
>   		goto err_free;
> @@ -379,6 +391,8 @@ static int test_wait_timeout(void *arg)
>   	if (!wt.f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(wt.f);
> +
>   	if (dma_fence_wait_timeout(wt.f, false, 1) != -ETIME) {
>   		pr_err("Wait reported complete before being signaled\n");
>   		goto err_free;
> @@ -458,6 +472,8 @@ static int thread_signal_callback(void *arg)
>   			break;
>   		}
>   
> +		dma_fence_enable_sw_signaling(f1);
> +
>   		rcu_assign_pointer(t->fences[t->id], f1);
>   		smp_wmb();
>   
> diff --git a/drivers/dma-buf/st-dma-resv.c b/drivers/dma-buf/st-dma-resv.c
> index 813779e3c9be..15dbea1462ed 100644
> --- a/drivers/dma-buf/st-dma-resv.c
> +++ b/drivers/dma-buf/st-dma-resv.c
> @@ -45,6 +45,8 @@ static int sanitycheck(void *arg)
>   	if (!f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f);
> +
>   	dma_fence_signal(f);
>   	dma_fence_put(f);
>   
> @@ -69,6 +71,8 @@ static int test_signaling(void *arg)
>   	if (!f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f);
> +
>   	dma_resv_init(&resv);
>   	r = dma_resv_lock(&resv, NULL);
>   	if (r) {
> @@ -114,6 +118,8 @@ static int test_for_each(void *arg)
>   	if (!f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f);
> +
>   	dma_resv_init(&resv);
>   	r = dma_resv_lock(&resv, NULL);
>   	if (r) {
> @@ -173,6 +179,8 @@ static int test_for_each_unlocked(void *arg)
>   	if (!f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f);
> +
>   	dma_resv_init(&resv);
>   	r = dma_resv_lock(&resv, NULL);
>   	if (r) {
> @@ -244,6 +252,8 @@ static int test_get_fences(void *arg)
>   	if (!f)
>   		return -ENOMEM;
>   
> +	dma_fence_enable_sw_signaling(f);
> +
>   	dma_resv_init(&resv);
>   	r = dma_resv_lock(&resv, NULL);
>   	if (r) {