Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0658c1ee-ba64-711d-241b-8fc6f510a50e@amd.com>
Date:   Mon, 12 Sep 2022 08:44:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3 1/6] dma-buf: Remove the signaled bit status check
Content-Language: en-US
To:     Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220909170845.4946-1-Arvind.Yadav@amd.com>
 <20220909170845.4946-2-Arvind.Yadav@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220909170845.4946-2-Arvind.Yadav@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dE13R2l1WFRKUk5QaTdhaTBrc0JWb2ZLSGk1eDV5UnZFRDNWQitBaXMrbmJj?=
 =?utf-8?B?b1d5d2pDSlV0WHFuRTlGUnVTTVc2NGdCRHdBZWVNWUZ3dmo4V3BVbE5FZkEz?=
 =?utf-8?B?cG5BYUVqOUpLUnRsVGgrdHhoZHA0TG5rd3dWajM2eHNBV0NQa21Vc0ZIWFpP?=
 =?utf-8?B?WFJEbE9WenhFdVJhcGdwakxLNVVsbUhpcUZ1Q3MwaXFtYlVDdnBTSzVWZDRa?=
 =?utf-8?B?TmcrdmdYVFNmbkw4ZFlSblVESjZ1QWR2M0pxYTRMeVowQXR3ckJXTkw5dmVH?=
 =?utf-8?B?M1NtR0lHcWRhVmlkRlBnd0EweVlwWS9UNFpzUWJLK1J6c1A4bWhLTm1QVHlQ?=
 =?utf-8?B?WTFjTHBSeWdvcTZ4dW1YeTVnRUJXaGdrZjFLZGZKWUgvQjY3OUJGMFZtMHFY?=
 =?utf-8?B?Vi9DRC9ibDhTSG1XeThSemYzV05OaFM1YWFhSExndDIwZ04yVTVnaXh3L1J3?=
 =?utf-8?B?KzU2QmJUU3FqaHNSTnFmWnhTYS8xbjlDZDFNVlhTL0MrZ2w4andWeDlDQXln?=
 =?utf-8?B?bmVQMnh3MFZyc1lKdzg4L1A0TXNKMlhvQm9yU3dqOEpNdXVabjdEaFF1VFFy?=
 =?utf-8?B?SEtNbTRwZ1Y5a2lWdWlnSmpnT2JiOEVsYnMrYmlhNnVsL09MNFhZM09qNmJL?=
 =?utf-8?B?WWdYT3B3MGthS0pKRUlpSmRCNDUyZmZaWlBXTmxvWllpWXBkMDVLV29jTDZt?=
 =?utf-8?B?ME5tY2dqcHVzT2lrc1NmSy9tcVJCQ3BzOXNUcklWUnVEZ0tnNDgrbm40VmNP?=
 =?utf-8?B?SlZ2Mmh6OVZkYVpkTEdqSFE4VmkralZ3WVBEcUpPR2RBOUhJSHlRWEZlSTZo?=
 =?utf-8?B?V2h3RkJHcm5zaWIxMWhPbGFWMUNRMzI3ckxKRW1BSzV1Vjk0OTJBUG83dTRI?=
 =?utf-8?B?V2JOWVo3d0pOOEw4NDFlNzVYa2l0QmIwdWpwYnNmZDVialpYTlAvanNXRXZq?=
 =?utf-8?B?bEhaRFV5WFZvRFlwNE9aS2kvMlpzZmFDSWpEOGdET29Tb2ZvN2tnbzZiR3Bs?=
 =?utf-8?B?a25Rb3VVaUtFcE5CNitZdGl6TlhWUzhxRVcwRkhGYVFnMjdzL2lIQkdkZkVO?=
 =?utf-8?B?aFVyb0lVMG5jL052VDM3eXZvZEc4NXJSRU52R2N4Y1JSVkttRWgrc1VQTlU2?=
 =?utf-8?B?NUkzU3ZGRUdZRjh5ejJyK1VaK2ZkZ2plblpYS290QUlsUmN2ZEwwNmdQYnY4?=
 =?utf-8?B?RnI2d1YycHUvQ0ozeEdCbXJmck5MTEIyQ1hUc1ozQWNGMDRoTm5qOExVMm8v?=
 =?utf-8?B?b2RvUWdSdUpDcktCWkpUK1c0cWhwNkVJK0dLMzZJREJlVGtLUDl1UVlRdHdr?=
 =?utf-8?B?OXV6UU9IckgvRHQ0NUZZQ2J6dSs3VDZDV2hqd3M0WkhrUHhHdEFlMERmSlQx?=
 =?utf-8?B?d3JGaVlKVEFUcE9IamRMamh0RVlxODhma3NmWk41Vm5ORzl4WFNwQW5Tb01n?=
 =?utf-8?B?Zm02YVAzbUdJNkRsV0VkZjZvamFCQzI3R2dibzl0c25ZVmpOeC9QMEN0T2VD?=
 =?utf-8?B?czdpcWsrZVRhTG9pUWZnNkJjT2xWQUdQczAwUFg0eWhnVmxBaW0yZVZlb2hL?=
 =?utf-8?B?Rk5sY25tYS8rU1RYcTliSThBU25RVXloV255VEMvRlVYQTBmQmVkZlBORWtQ?=
 =?utf-8?B?QmtjaG1HZjNqT29mM3JRc0xRKzZIY0s5ak5OSzN0OVhocHFJUzdWajcyMGpx?=
 =?utf-8?B?MWdpYi9hTGVhdjQ1d3pCUzhId3h6VlpUSHdpL01ZMXFCVUlXOGJBYk9RWC9m?=
 =?utf-8?B?KzlTZUZtb1ROUllTSUYrcmVFd3FtdGxNUkZFRzQxc3NNWFlmODhYRTBacnVu?=
 =?utf-8?B?UWxTRFBoRHBWaGQycEN0MkFMQ0dmUXEwQytDVXdkZ0tGZ3lyNWNRVk5uRG5H?=
 =?utf-8?B?QjQ1TEZNOTdvOUlFMVlqdVNFcVpzMTl3NlVWNmZxbS8zZXBpUFV2T3I2YzBj?=
 =?utf-8?B?L2dMSTJvNlpiYmcrSFRGV3htZzJwRThLTGx5YTMrV2hzVDF1VEZFNkh2NG56?=
 =?utf-8?B?bTFWaGx4TEJNd29DZ2dLQ3dBdU1mRmloRUE3WjZoUTU0S3NqSTRwVW5mdkJ0?=
 =?utf-8?B?bFVNU2dOdmh4VUgwNHBXVmtnSTRuSytCU2hhQm5JQmpwbUs1bS8xZ0lGNVRl?=
 =?utf-8?B?VDkyWVkreXZDektyQWQ5NmNvVnhOTFcyZDhxeXF3ZlZQQTlVV0tqRlI4MTZV?=
 =?utf-8?Q?orr8p55zofqAb6q8t1bnxrnAX1K/G4jKSLnrxLkpTaX6?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19ba2985-6291-4f28-fa1b-08da948a4066
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 06:44:33.5890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xzDQ7fmXc1va/OIwPd0tCFjSs8FQePDWDTpLV801PXhTHtD8OCc5PvzPA87O8UzW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5405
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 09.09.22 um 19:08 schrieb Arvind Yadav:
> Remove the signaled bit status check because it is returning
> early when the fence is already signaled and
> __dma_fence_enable_signaling is checking the status of signaled
> bit again.
>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>
> Changes in v1, v2: This new patch was not part of previous series.
>
> ---
>   drivers/dma-buf/dma-fence.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index 066400ed8841..64c99739ad23 100644
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -601,9 +601,6 @@ void dma_fence_enable_sw_signaling(struct dma_fence *fence)
>   {
>   	unsigned long flags;
>   
> -	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
> -		return;
> -
>   	spin_lock_irqsave(fence->lock, flags);
>   	__dma_fence_enable_signaling(fence);
>   	spin_unlock_irqrestore(fence->lock, flags);