Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <43d23604-9def-251a-d733-0bed9a431f85@amd.com>
Date:   Mon, 12 Sep 2022 08:45:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v3 2/6] dma-buf: set signaling bit for the stub fence
Content-Language: en-US
To:     Arvind Yadav <Arvind.Yadav@amd.com>, andrey.grodzovsky@amd.com,
        shashank.sharma@amd.com, amaranath.somalapuram@amd.com,
        Arunpravin.PaneerSelvam@amd.com, sumit.semwal@linaro.org,
        gustavo@padovan.org, airlied@linux.ie, daniel@ffwll.ch,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220909170845.4946-1-Arvind.Yadav@amd.com>
 <20220909170845.4946-3-Arvind.Yadav@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220909170845.4946-3-Arvind.Yadav@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmlKbVVhQzJUY3VGdkRGS2FRaWpobzZnc1dDejRXajA1ZUlWQ0pwdHZKdW5z?=
 =?utf-8?B?RnB1cEdNTko2aFFkbldhS0FiNGRNRlMwRUcrNWdRRWR5UWNCSzhYNGdHak1O?=
 =?utf-8?B?ckhLSFhnM0RRNEZKSm5VVWlWVE50STlJRml0V2ljdnF6aktRSW9ndHZEZmR1?=
 =?utf-8?B?Slh5aUxGMXNnM2prWkpEeTRPRnc4a1h3c3FKZUpjSG14allIbnB4UEl6d2xY?=
 =?utf-8?B?VzJUN0dESmtETENoYlo5d2s2RlNmRGlkZUhaWVF2ZGEwUkorNTJ5NVRtdXlu?=
 =?utf-8?B?bWpQMmtYZE1QS3J5cmt1dmVhUEVzRncrQjUyR3ROVW5NbzhtM3JLUWcvMkNV?=
 =?utf-8?B?RWVhT01HeW05ZnlyY3BNZDBUTGk4RlNVL2NFd0IvWUhZbU5hM3Fic20wVUJk?=
 =?utf-8?B?dEx1eURkOEZUdDhMdytRaEpudWlIeXI2TUwxeHc4ZjlSSktDdnRUMGNkYmFR?=
 =?utf-8?B?bnVZYkVXQm1JQjNON3JHejdjSW5KU2RsWlVHbkMxbWY5Z3lwbHF6UlA3YTgr?=
 =?utf-8?B?c2dpSGJCaUVyNjE0ckVRaU0wZWR0dXpHMm1UYlJ1U1Zqcmlwa1NnYlF5NmVK?=
 =?utf-8?B?RkhPNngwL3J2Sjc5eGVDOXhVdEk5ZVE4bnZEZ0dNY2QvdHlHaTdHb2twMzh6?=
 =?utf-8?B?cTF1blM1d0ZJOHIwNUF3SDFocUorOUhkQnBvVVI1bnIrMWpoMWVOZzVpbEg2?=
 =?utf-8?B?SzdWQzJuaVo4M0prOUg3VDdIZjhEYVBibllGak8rM1VyNjFlYUNwVlpRVWc1?=
 =?utf-8?B?N3dBUmMzL1JueGJvSTNYQThrVUZ1Ums0Y2Q1VTB4ZFljNGJCTnQ2Z0xsbjhM?=
 =?utf-8?B?a0tMd01yZWVPc2hNbkFELzJjWlY4YW05OVBZYkF6SW9LNmxJYndjNnQ2YlBa?=
 =?utf-8?B?aHpkQjhqTmJ3bTdCcENEaFl6WWtrV1NRQVJmYmhjakQydlRINUI4SWRyT2RB?=
 =?utf-8?B?U3BoVm1EeXZSR2J4VjB2ZkFWUmg0T2pZRDMyK3RTblhvOWhnWjh4cjEvRHdy?=
 =?utf-8?B?QzJXYVY5clNubFo0alBTNmRhckppOGR2THlyNDVFcFRkb3dVcnMvcW5ESVEx?=
 =?utf-8?B?NDdzUWZyMWlISitGNDZReEVLRnkxallNcVNJNWR4WFdHRkVQVjQ0M1ZTa01D?=
 =?utf-8?B?UUp4b3M1UmlvZ2NXQzVJdG9NMWIzWW1JODBZUmlvbzJXQ3YwTFBDajZjS1Rq?=
 =?utf-8?B?b2xsbnEzc0NRK21Sb1hGbkowM1ZHN29xZi92ZE15M0hwNm9LR1A5Nm9IS1FB?=
 =?utf-8?B?WkxJdXEyVE9MMXBVZmsrR1Q0bzNQQlNFaEdZSHRtWWRWVG9jd0J4bHd6N3hr?=
 =?utf-8?B?RkRUZ1VaRXg5M1VBV1U3YnFWQ2tOOXJiWEZmMlFhKzhqVUM2dVVseDZld0E4?=
 =?utf-8?B?Z055SGx2dEh1SEpLRkxweEVXaVp4Vmw5ZTd0U2I5WTVtb2VDUDBQVjdVbzVu?=
 =?utf-8?B?ZkFQejhkY21IZ3NWeTNtc0JUZkVJVTV5RXNNWjJlMzBnQ2JScWlERkxLU0tw?=
 =?utf-8?B?cFp1ZHNoUkpSZFB6bFhFNjJtL3dZUGl0cnJBakR5MWMxbGZNYThvRlZDMUJG?=
 =?utf-8?B?TFY4M05vUHQ0VHgrSGxGWHVVaXJQYmM0cDNsTzZ3RkFlL2RuckxGOVVmUmFs?=
 =?utf-8?B?Yjh5aWJQK1RZSHlPNDF3K2plbUhhc0R3UEtJUHdrOW85NGNBRmMzdU9mQm9E?=
 =?utf-8?B?MGRoVk94UEpySEx2UVhhOUtsaFo1YklCR254blQyd2RCYi9sTE5ESzNYZGFo?=
 =?utf-8?B?a2xzTFMrTGNpbHA1VW10YUVzSEN0TjQ4Q2tFQjZIR0FzTVlxMWhzSVdCc091?=
 =?utf-8?B?M2xTcjNiYmIveStrNzlRVXBZZzhVSHV6NjJRdTl4V0dkeDE4SHFld0d0OVN3?=
 =?utf-8?B?QWhYSzNUN0wvM2kvNFIvK0JWc2JTZDJqbW5JRmVGOUZ1a3Vtekt4OFE2Zkl6?=
 =?utf-8?B?cnBEMnFkZDJ2Wjh4L0lUNW9BV05WeUxuSVRBdzh1Y25FOFRJSW1Ybm9LOE9w?=
 =?utf-8?B?N3FsK2pDWVNSSktrcTcvMndqbTdLV0JxaG9yY1Z1bUhZV2JHdmZBTlcvM1d3?=
 =?utf-8?B?SkxMS2N6ZXZWUXpGSlN4WUk4YlFFei9yUTJ5QjQrV2tCMGIzOXJpQ1VSdWpD?=
 =?utf-8?B?cjl5eGhBNXhyV1l5NW5DUHFycEIzcU1Db3pKa3ZiRWphcm5PWmc5Q25FT0dy?=
 =?utf-8?Q?ICK2Et61u4Tg6Gn5Zutp6zsF+H5dqc4HIKtEppDGVr0x?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1dcb196-d5bd-42b6-f3f2-08da948a686f
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 06:45:40.7411
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8mbEyPMl6rnpDhLC36N0Nn1KyFYyEGNSBgxWw9Yve9PEeKEaZk9jGY2D6o8tRVLQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6375
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 09.09.22 um 19:08 schrieb Arvind Yadav:
> Here's setting software signaling bit for the stub fence
> which is always signaled. If this fence signaling bit is
> not set then the AMD GPU scheduler will cause a GPU reset
> due to a GPU scheduler cleanup activity timeout.
>
> Signed-off-by: Arvind Yadav <Arvind.Yadav@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>
> Changes in v1 :
> 1- Addressing Christian's comment to remove unnecessary callback.
> 2- Replacing CONFIG_DEBUG_WW_MUTEX_SLOWPATH instead of CONFIG_DEBUG_FS.
> 3- The version of this patch is also changed and previously
> it was [PATCH 3/4]
>
> Changes in v2 :
> 1 - perviously using  __dma_fence_enable_signaling() for enable
> signaling.
> 2 - #ifdef CONFIG_DEBUG_WW_MUTEX_SLOWPATH  removed
>
> ---
>   drivers/dma-buf/dma-fence.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index 64c99739ad23..bead1a6e9f59 100644
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -136,6 +136,10 @@ struct dma_fence *dma_fence_get_stub(void)
>   			       &dma_fence_stub_ops,
>   			       &dma_fence_stub_lock,
>   			       0, 0);
> +
> +		set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
> +			&dma_fence_stub.flags);
> +
>   		dma_fence_signal_locked(&dma_fence_stub);
>   	}
>   	spin_unlock(&dma_fence_stub_lock);