Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] mm/slub: return 0 when object pointer is NULL
To:     Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc:     cl@linux.com, penberg@kernel.org, rientjes@google.com,
        iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz,
        roman.gushchin@linux.dev, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <1662962379-16174-1-git-send-email-luoben@linux.alibaba.com>
 <Yx7dKxwxlNmCr9Ai@hyeyoo>
From:   Ben Luo <luoben@linux.alibaba.com>
Message-ID: <133458f0-23c9-9421-abb8-a50d5551b524@linux.alibaba.com>
Date:   Mon, 12 Sep 2022 15:29:30 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <Yx7dKxwxlNmCr9Ai@hyeyoo>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hello Hyeonggon,

Thanks for replying :)

在 2022/9/12 15:18, Hyeonggon Yoo 写道:
> On Mon, Sep 12, 2022 at 01:59:39PM +0800, Ben Luo wrote:
>> NULL is definitly not a valid address
>>
>> Signed-off-by: Ben Luo <luoben@linux.alibaba.com>
>> ---
>>   mm/slub.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/slub.c b/mm/slub.c
>> index 862dbd9..50fad18 100644
>> --- a/mm/slub.c
>> +++ b/mm/slub.c
>> @@ -674,7 +674,7 @@ static inline int check_valid_pointer(struct kmem_cache *s,
>>   	void *base;
>>   
>>   	if (!object)
>> -		return 1;
>> +		return 0;
>>   
>>   	base = slab_address(slab);
>>   	object = kasan_reset_tag(object);
>> -- 
>> 1.8.3.1
>>
> Hello Ben.
>
> The return value is used to check if the @object has valid pointer
> in @slab. (used for debugging) the return value is 0 if valid, 1 if invalid.
>
> It does not return a pointer. So changing it to 0 because 1 is invalid
> address does not make sense.

I know the meaning of this return value, but I think this function was 
expected by returning 0 if invalid ,1 if valid

Check this original code:

         if (object < base || object >= base + slab->objects * s->size ||
                 (object - base) % s->size) {
                 return 0;
         }

Object not in range of [base, base+length) is an invalid slab address, 
and it will return 0


--

Thanks,

Ben

>