Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp4934336rwn; Mon, 12 Sep 2022 01:23:10 -0700 (PDT) X-Google-Smtp-Source: AA6agR6y1GJrwmEgD2l0UKW0uukiR/GfCSVu+KxyquTCM6iKo6q0H8QPYLVKf541/rW8iMM9S4Rw X-Received: by 2002:a62:5443:0:b0:53b:b934:ee8e with SMTP id i64-20020a625443000000b0053bb934ee8emr26936078pfb.10.1662970990063; Mon, 12 Sep 2022 01:23:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662970990; cv=none; d=google.com; s=arc-20160816; b=wp3HG5e6wM3VdDxNuuKk/FWqnXLr19r3btCKYR8ektZiNDXpQkXcidkoNNJNTPq1Zz Ya5pPXXOKuP13DFOuFSnOyKtcc5wV5YWNURcU9eO0MRG/Whd3e3axOI11dqFLky8FPNo O5JmI+xkYJOEeLTzrU/GK2AeVWJgpnyhIS0/v1NaFcP1C7d4yIrLUDQJBWVQGJCMMT95 VMXls5+Ssvetu7ydViC/Urd9oJoWJArrjzUhk7mLYfdZDG6GPDVsG9FsZjJ5x5o6EBM0 i5fFxO3iSWT8NWxV9CfaZqKTxp8p875klbqioA51+wdoN+57429YAB6AbXYEgI/sBdoA LuWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=2LOJWP7iNLysX7kywuHKrhxC4PyTT4a8sQfoQJTmcG4=; b=TXVR8E/V8dqWYbtLXK6uLouIN+h3dkV3eWbYuwKZjCyWUS7pw9jOmMig9lyR2qUvBH RzYCpXMGE0Amu+b/0U4EqM2EXElusRZMhe1Ypv6Mn+1czXcpnJf1JT3hT9E7nqe+oNJM BzCr64ns2Ht7TZ1Zk0QTpP+GeO32Tk6oGp1vP1A2mr3KvXac+ZIEglL7+xWTfOAuM5Lv lrfJuJ0eE2eeFrk56+k1okg5cuUYzMjGWBuyh1PNGLTmgeSp7Vea35ottopZDOp8qrSo EcQ3vy0rpxNG2D5LXIdJgei+l4Qe7px/5gBQ4qCNynhWB6De2H6RE2gTC6YKjPH1YK0d uT1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f125-20020a623883000000b00536bf099c14si7041024pfa.307.2022.09.12.01.22.57; Mon, 12 Sep 2022 01:23:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229806AbiILIUY (ORCPT + 99 others); Mon, 12 Sep 2022 04:20:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229592AbiILIUX (ORCPT ); Mon, 12 Sep 2022 04:20:23 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6D830120BE; Mon, 12 Sep 2022 01:20:22 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7068E113E; Mon, 12 Sep 2022 01:20:28 -0700 (PDT) Received: from bogus (unknown [10.57.48.242]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6AD063F73D; Mon, 12 Sep 2022 01:20:20 -0700 (PDT) Date: Mon, 12 Sep 2022 09:20:17 +0100 From: Sudeep Holla To: Rafael Mendonca Cc: "Rafael J. Wysocki" , Len Brown , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ACPI: PCC: Release resources on address space setup failure path Message-ID: <20220912082017.iuo35tyzwvq3dqfn@bogus> References: <20220909153320.501347-1-rafaelmendsr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909153320.501347-1-rafaelmendsr@gmail.com> X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 09, 2022 at 12:33:19PM -0300, Rafael Mendonca wrote: > The allocated memory for the pcc_data struct doesn't get freed under an > error path in pcc_mbox_request_channel() or acpi_os_ioremap(). Also, the > PCC mailbox channel doesn't get freed under an error path in > acpi_os_ioremap(). > Thanks! Reviewed-by: Sudeep Holla -- Regards, Sudeep