Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Sep 2022 12:08:36 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     netdev@kapio-technology.com
Cc:     Vladimir Oltean <olteanv@gmail.com>, davem@davemloft.net,
        kuba@kernel.org, netdev@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Hauke Mehrtens <hauke@hauke-m.de>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Shuah Khan <shuah@kernel.org>,
        Christian Marangi <ansuelsmth@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Yuwei Wang <wangyuweihx@gmail.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 net-next 6/6] selftests: forwarding: add test of
 MAC-Auth Bypass to locked port tests
Message-ID: <Yx73FOpN5uhPQhFl@shredder>
References: <YwzjPcQjfLPk3q/k@shredder>
 <f1a17512266ac8b61444e7f0e568aca7@kapio-technology.com>
 <YxNo/0+/Sbg9svid@shredder>
 <5cee059b65f6f7671e099150f9da79c1@kapio-technology.com>
 <Yxmgs7Du62V1zyjK@shredder>
 <8dfc9b525f084fa5ad55019f4418a35e@kapio-technology.com>
 <20220908112044.czjh3xkzb4r27ohq@skbuf>
 <152c0ceadefbd742331c340bec2f50c0@kapio-technology.com>
 <20220911001346.qno33l47i6nvgiwy@skbuf>
 <15ee472a68beca4a151118179da5e663@kapio-technology.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <15ee472a68beca4a151118179da5e663@kapio-technology.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D07mIkI0PCh1OEPupbhcy8BX1r9bcWsEZHhuFWb4YXNGbQe/H7z/Aa8iJMSO?=
 =?us-ascii?Q?MTiovmnqNm1OQgR+qEnz05onC40iA/Gf/POx/HJYH+pmXeJm35jkasBsuh5Z?=
 =?us-ascii?Q?U4Lpp2aepg98cYFX7cFY6yGRZ/riEOWg6ED+A9IauWXpc3hNgMETXi+FGo0b?=
 =?us-ascii?Q?G/kgJvVWwNF66C3E49/EsdlyCHniIupsMjRSUCYqA7+u8NlgsFIcfoTZ4rlK?=
 =?us-ascii?Q?qbHTLsbuGNZwSSyM+v50awFJpwSVWPB9EJ8wcx1ML9mc4pWOcFMyQmLiqY7q?=
 =?us-ascii?Q?OEJ6cqSoe5PTeDbdDFFlUGrDGr1t+skL44I9K/1OTyCr8e/jMqsSuZaSM71c?=
 =?us-ascii?Q?xFmsCGnS3j1wvVyjaoJLphoRapm9KEKHB/b8XYuvr0ekL99RpCyK7Li6Q94l?=
 =?us-ascii?Q?stGesyXHmFFWFfTasVUeuNKbXIHzO9rXnR6GgdpF3qmZXD9/9BEF+1G8G4ud?=
 =?us-ascii?Q?N02yAAn1a+IYmAlILVxg7AgNmQg9/wppXQaSm1c5dWD5gCOLntPeSJIMd6a7?=
 =?us-ascii?Q?wWGl/l/TBXzTdBJeJm8Sy8+FI9ojh6o6R21oxsvALLPkNS9QE9TBCrHqceZ4?=
 =?us-ascii?Q?i3Xh7AmMHL1kZgY94z1BCALlJ8WR7P06WEzf2P68mB/Tcw49hSwMfLUYtH+L?=
 =?us-ascii?Q?TC04Cip60x0EpvzvSVqcu87j9pq+FmKfqkjAuTRAmeeIL8m9u1EXTfpU8N0v?=
 =?us-ascii?Q?EAaVq/h8q6Fd32628BX413lDMwGyQAEfz0Yxi7Fi8fzPkqq5PTUW82YxbTGy?=
 =?us-ascii?Q?6IxqWAZ1dksllRUbqGDyHoOdhEPhVFJ6/JjZLvig4dBs53RbMz9zDLKab1jH?=
 =?us-ascii?Q?X+CBjPiz5IePV9hlqAAQaqbKZUZSgTq8kv2lPhpgarZNL0jHYBlFfRTrd09P?=
 =?us-ascii?Q?IMV6f4q6cMawKuuA2TZhhWrdAgNe+7VntoW/rq34bc74x25wpc8Hqh1CInY0?=
 =?us-ascii?Q?Qme5tOCyLUdrfIGk4SlUVI+6p6bg+naoZdgqDsOi3MY6vx15DUyRmIeVP4oC?=
 =?us-ascii?Q?gStVHzrCU50ZmldHlrixs5PfCTuLu62TSEzxOxvaGUNhpezuA7YiWl7Ggnqm?=
 =?us-ascii?Q?0azR8/dXWAQ3mz9pLpgAL1AGJsFEUFV6d3mFqFIVrw9duvbo0OZhFlsz8V5o?=
 =?us-ascii?Q?va96M0mEgOVCc6HrKV6LehZBhgfApn/qgN/hFpZEnofGNd355NynQEbMVrAX?=
 =?us-ascii?Q?P8EX6prUbFbM12WzBNAn7463puw3t/2LFHvx7kFqiiNy7GyEItcQoscYLAux?=
 =?us-ascii?Q?xyWUGmQ7eK5fNQDDuFUid5fVUnzfP8J0iMg+Yd1M+itoFAI+8ArZtqIXdv5w?=
 =?us-ascii?Q?bSvwzbssMJBBprepmGDegsIEyCvihAkZAAjvVIPWAuOO+CWoChSy0E0nJc3g?=
 =?us-ascii?Q?cJ4ujFX89kKFJ/JhtSqTuwRcLzn1VE66HrMax2zQpkOexU9/gz4VMA+yrC0G?=
 =?us-ascii?Q?rIRFP+6Lw4fzR6IdAG2iELNqcxhZsG5nh6uPOS6BKkIl4+olLr9vsvL8dSBJ?=
 =?us-ascii?Q?DQb1KNH5HNFVKdqVB2Boq8EVgRX9kvQ8FjxyLjccQELFVzZbi67Rp0PBbTG1?=
 =?us-ascii?Q?STAHCmQ6heChcdkPJp2vd/AqwBFLhzhsycUo/0mS?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1d795a3-0537-47d4-9e63-08da949e62c4
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 09:08:41.1016
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PAOTYUUUl0sbrkSf6Xdmgx/3ymZw9X9R++FAf/tQhWzqmad/N3oq1R0Sb+fBM742IZCTUAFx4rrehWXk8pxYNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5429
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 11, 2022 at 11:23:55AM +0200, netdev@kapio-technology.com wrote:
> On 2022-09-11 02:13, Vladimir Oltean wrote:
> > On Fri, Sep 09, 2022 at 03:11:56PM +0200, netdev@kapio-technology.com
> > wrote:
> > > > > > On Wed, Sep 07, 2022 at 11:10:07PM +0200, netdev@kapio-technology.com wrote:
> > > > > > > I am at the blackhole driver implementation now, as I suppose that the
> > > > > > > iproute2 command should work with the mv88e6xxx driver when adding blackhole
> > > > > > > entries (with a added selftest)?
> > > > > > > I decided to add the blackhole feature as new ops for drivers with functions
> > > > > > > blackhole_fdb_add() and blackhole_fdb_del(). Do you agree with that approach?
> > > > > >
> > > > > > I assume you are talking about extending 'dsa_switch_ops'?
> > > > >
> > > > > Yes, that is the idea.
> > > > >
> > > > > > If so, it's up to the DSA maintainers to decide.
> > > >
> > > > What will be the usefulness of adding a blackhole FDB entry from user
> > > > space?
> > > 
> > > With the software bridge it could be used to signal a untrusted host
> > > in
> > > connection with a locked port entry attempt. I don't see so much use
> > > other
> > > that test purposes with the driver though.
> > 
> > Not a huge selling point, to be honest. Can't the blackhole flag remain
> > settable only in the device -> bridge direction, with user space just
> > reading it?
> 
> That is possible, but it would of course not make sense to have selftests of
> the feature as that would not work unless there is a driver with this
> capability (now just mv88e6xxx).

The new "blackhole" flag requires changes in the bridge driver and
without allowing user space to add such entries, the only way to test
these changes is with mv88e6xxx which many of us do not have...