Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Sep 2022 18:37:38 +0900
From:   Masami Hiramatsu (Google) <mhiramat@kernel.org>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     <linux-kernel@vger.kernel.org>, <mhiramat@kernel.org>,
        <ast@kernel.org>, <jbacik@fb.com>, <akpm@linux-foundation.org>
Subject: Re: [PATCH -next 1/3] fail_function: Switch to memdup_user_nul()
 helper
Message-Id: <20220912183738.d86c72c87197cfc8dd377d49@kernel.org>
In-Reply-To: <20220826073337.2085798-1-yangyingliang@huawei.com>
References: <20220826073337.2085798-1-yangyingliang@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 26 Aug 2022 15:33:35 +0800
Yang Yingliang <yangyingliang@huawei.com> wrote:

> Use memdup_user_nul() helper instead of open-coding to
> simplify the code.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thank you!

> ---
>  kernel/fail_function.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 
> diff --git a/kernel/fail_function.c b/kernel/fail_function.c
> index 60dc825ecc2b..03643e33e4c3 100644
> --- a/kernel/fail_function.c
> +++ b/kernel/fail_function.c
> @@ -247,15 +247,11 @@ static ssize_t fei_write(struct file *file, const char __user *buffer,
>  	/* cut off if it is too long */
>  	if (count > KSYM_NAME_LEN)
>  		count = KSYM_NAME_LEN;
> -	buf = kmalloc(count + 1, GFP_KERNEL);
> -	if (!buf)
> -		return -ENOMEM;
>  
> -	if (copy_from_user(buf, buffer, count)) {
> -		ret = -EFAULT;
> -		goto out_free;
> -	}
> -	buf[count] = '\0';
> +	buf = memdup_user_nul(buffer, count);
> +	if (IS_ERR(buf))
> +		return PTR_ERR(buf);
> +
>  	sym = strstrip(buf);
>  
>  	mutex_lock(&fei_lock);
> @@ -308,7 +304,6 @@ static ssize_t fei_write(struct file *file, const char __user *buffer,
>  	}
>  out:
>  	mutex_unlock(&fei_lock);
> -out_free:
>  	kfree(buf);
>  	return ret;
>  }
> -- 
> 2.25.1
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>