Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f8a92b6d-ad23-24e7-2a01-73839e57cb85@baylibre.com>
Date:   Mon, 12 Sep 2022 11:49:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFT] [PATCH] regulator: tps65219: Fix .bypass_val_on setting
Content-Language: en-US
To:     Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Tony Lindgren <tony@atomide.com>, linux-kernel@vger.kernel.org
References: <20220828120153.1512508-1-axel.lin@ingics.com>
From:   jerome Neanne <jneanne@baylibre.com>
In-Reply-To: <20220828120153.1512508-1-axel.lin@ingics.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Axel,

On 28/08/2022 14:01, Axel Lin wrote:
> The .bypass_val_on setting does not match the .bypass_mask setting, so the
> .bypass_mask bit will never get set.  Fix it by removing .bypass_val_on
> setting, the regulator_set_bypass_regmap and regulator_get_bypass_regmap
> helpers will use rdev->desc->bypass_mask as val_on if the val_on is 0.
I think this will result in exact same behavior. val would be assigned 
to 1 when enable is set and 0 otherwise. Anyway you are right this line 
is useless.
> I don't have this h/w to test, please help to review and test the patch.

I'll double check on the board.