Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 11 Sep 2022 14:34:43 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Tom Rix <trix@redhat.com>
Cc:     linus.walleij@linaro.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: ab8500: remove unused static local
 variable
Message-ID: <20220911123443.uyezfayi2qwtlhmo@mercury.elektranox.org>
References: <20220719022743.305189-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kojtgi2dfwfvwzhf"
Content-Disposition: inline
In-Reply-To: <20220719022743.305189-1-trix@redhat.com>
Precedence: bulk


--kojtgi2dfwfvwzhf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Jul 18, 2022 at 10:27:43PM -0400, Tom Rix wrote:
> cpp_check reports
> [drivers/power/supply/ab8500_chargalg.c:493]: (style) Variable 'ab8500_ch=
argalg_ex_ac_enable_toggle' is assigned a value that is never used.
>=20
> From inspection, this variable is never used. So remove it.
>=20
> Fixes: 6c50a08d9dd3 ("power: supply: ab8500: Drop external charger leftov=
ers")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---

Thanks, queued into power-supply's fixes branch.
Sorry for the delay.

-- Sebastian

>  drivers/power/supply/ab8500_chargalg.c | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/power/supply/ab8500_chargalg.c b/drivers/power/suppl=
y/ab8500_chargalg.c
> index ae4be553f424..05146d436a6a 100644
> --- a/drivers/power/supply/ab8500_chargalg.c
> +++ b/drivers/power/supply/ab8500_chargalg.c
> @@ -490,8 +490,6 @@ static int ab8500_chargalg_kick_watchdog(struct ab850=
0_chargalg *di)
>  static int ab8500_chargalg_ac_en(struct ab8500_chargalg *di, int enable,
>  	int vset_uv, int iset_ua)
>  {
> -	static int ab8500_chargalg_ex_ac_enable_toggle;
> -
>  	if (!di->ac_chg || !di->ac_chg->ops.enable)
>  		return -ENXIO;
> =20
> --=20
> 2.27.0
>=20

--kojtgi2dfwfvwzhf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmMd1eMACgkQ2O7X88g7
+prxpw//b64FEro+osFjtCJqs6be/hUV+KVfatZOPUXIzy0QZzBqFuC2LvvQWJIv
LneApTqXf2Yhje4L+xowTXp0DgRSCjoYsXRFcNMkv2aeHo/g6hekPVoW+vFGNat/
Uj1ho47vob2XdTwQLwrrxuT81pRMJfAPJDQT6lNPldLakKflNJiz31trw6mkd6j9
4HV/zlzEHy26hIJYFkUXUFs+vVbZEDKzaf/J/SHW8AttxS33shbBx4oHVsQ1LOWV
4AwR+UjoDFM4PQrSL877wNVUEPHhrPLu3WmqcV/qWtcF49NFAi9mL3r1aaOL8OA0
bo67+k7P9kDiTk9LATryfGJJjC63obzLz+R+5Yub/PbQ50NK2JjPQsAG/iGutsr4
bf08apeIARxbyq5ZDYlZV3APOLnVdaivQf5twn4sKMdT5WlkoRRv9x6sqpQbY9aS
glOoAyLL8a4SUXl1CEWuBefb2pSGY1W7BncIRpQ6e4lpeWJmJgJpYGUF/gi+5I+n
DY+TbHPQo4/SFj/hVEMFeg/urF2G2W/g8KGQYIbEBScKeKcfUNx/0n+ajnobQIK4
O0Xc3HDbmPJaBA/p+3ci090sAzZ57Ub5QHHCoarsUnQJVm3pDAZiBYH2wFt5QVKF
6VvM3u6YJ8CBo5DNzzDnMeD6SHUPp+/I/DKtoB+037iU+cmE99s=
=mRsW
-----END PGP SIGNATURE-----

--kojtgi2dfwfvwzhf--