Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Sep 2022 13:02:58 +0200
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     cgel.zte@gmail.com
Cc:     w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
        Cspeakup@linux-speakup.org, linux-kernel@vger.kernel.org,
        Xu Panda <xu.panda@zte.com.cn>, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] speakup/utils: use "!P" instead of "P == 0"
Message-ID: <20220912110258.jwyv4xenfdvmo3p3@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        cgel.zte@gmail.com, w.d.hubbs@gmail.com, chris@the-brannons.com,
        kirk@reisers.ca, Cspeakup@linux-speakup.org,
        linux-kernel@vger.kernel.org, Xu Panda <xu.panda@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220912102059.18215-1-xu.panda@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220912102059.18215-1-xu.panda@zte.com.cn>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

cgel.zte@gmail.com, le lun. 12 sept. 2022 10:21:00 +0000, a ecrit:
> From: Xu Panda <xu.panda@zte.com.cn>
> 
> comparing pointer to 0, use !P instead of it.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

> ---
>  drivers/accessibility/speakup/utils.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4bf2ee8ac246..58ca9847637f 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
>         else
>                 snprintf(filename, sizeof(filename), "%s", name);
>         infile = fopen(filename, "r");
> -       if (infile == 0) {
> +       if (!infile) {
>                 fprintf(stderr, "can't open %s\n", filename);
>                 exit(1);
>         }
> -- 
> 2.15.2
>