Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220910081152.2238369-1-ardb@kernel.org> <20220910081152.2238369-9-ardb@kernel.org>
 <6876236f.7b0c.18327c74248.Coremail.chenhuacai@loongson.cn>
 <CAMj1kXFpQ1FkiMMXeA-E5FdnDzhZr7qmN15PNig_9KXxGNRJhQ@mail.gmail.com> <2c005589.7bc5.1832d12eb0c.Coremail.chenhuacai@loongson.cn>
In-Reply-To: <2c005589.7bc5.1832d12eb0c.Coremail.chenhuacai@loongson.cn>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Mon, 12 Sep 2022 11:18:05 +0100
Message-ID: <CAMj1kXEvRfgMo+kJBwdNQfcBSfEXYGZ5vTbh2Ym8T6X+p9iWBA@mail.gmail.com>
Subject: Re: Re: [PATCH v5 8/8] loongarch: efi: enable generic EFI compressed boot
To:     =?UTF-8?B?6ZmI5Y2O5omN?= <chenhuacai@loongson.cn>
Cc:     linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
        Matthew Garrett <mjg59@srcf.ucam.org>,
        Peter Jones <pjones@redhat.com>,
        Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
        AKASHI Takahiro <takahiro.akashi@linaro.org>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Atish Patra <atishp@atishpatra.org>,
        Arnd Bergmann <arnd@arndb.de>, Xi Ruoyao <xry111@xry111.site>,
        Lennart Poettering <lennart@poettering.net>,
        Jeremy Linton <jeremy.linton@arm.com>,
        Will Deacon <will@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, 11 Sept 2022 at 16:03, =E9=99=88=E5=8D=8E=E6=89=8D <chenhuacai@loon=
gson.cn> wrote:
>
>
>
>
> > -----=E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6-----
> > =E5=8F=91=E4=BB=B6=E4=BA=BA: "Ard Biesheuvel" <ardb@kernel.org>
> > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4:2022-09-10 22:28:04 (=E6=98=9F=E6=
=9C=9F=E5=85=AD)
> > =E6=94=B6=E4=BB=B6=E4=BA=BA: "=E9=99=88=E5=8D=8E=E6=89=8D" <chenhuacai@=
loongson.cn>
> > =E6=8A=84=E9=80=81: linux-efi@vger.kernel.org, linux-arm-kernel@lists.i=
nfradead.org, linux-kernel@vger.kernel.org, "James E.J. Bottomley" <James.B=
ottomley@hansenpartnership.com>, "Matthew Garrett" <mjg59@srcf.ucam.org>, "=
Peter Jones" <pjones@redhat.com>, "Ilias Apalodimas" <ilias.apalodimas@lina=
ro.org>, "Heinrich Schuchardt" <heinrich.schuchardt@canonical.com>, "AKASHI=
 Takahiro" <takahiro.akashi@linaro.org>, "Palmer Dabbelt" <palmer@dabbelt.c=
om>, "Atish Patra" <atishp@atishpatra.org>, "Arnd Bergmann" <arnd@arndb.de>=
, "Xi Ruoyao" <xry111@xry111.site>, "Lennart Poettering" <lennart@poetterin=
g.net>, "Jeremy Linton" <jeremy.linton@arm.com>, "Will Deacon" <will@kernel=
.org>, "Catalin Marinas" <catalin.marinas@arm.com>
> > =E4=B8=BB=E9=A2=98: Re: [PATCH v5 8/8] loongarch: efi: enable generic E=
FI compressed boot
> >
> > On Sat, 10 Sept 2022 at 15:22, =E9=99=88=E5=8D=8E=E6=89=8D <chenhuacai@=
loongson.cn> wrote:
> > >
> > > Hi, Ard,
> > >
> > > I prefer to give a chance to disable ZBOOT, so I don't want to select=
 EFI_ZBOOT unconditionally in Kconfig, and then the Makefile can be like th=
is:
> > > diff --git a/arch/loongarch/Makefile b/arch/loongarch/Makefile
> > > index c3f579bdf9e5..bc6fe65125f5 100644
> > > --- a/arch/loongarch/Makefile
> > > +++ b/arch/loongarch/Makefile
> > > @@ -14,6 +14,10 @@ else
> > >  KBUILD_IMAGE   :=3D $(boot)/vmlinux.efi
> > >  endif
> > >
> > > +ifdef CONFIG_EFI_ZBOOT
> > > +KBUILD_IMAGE    :=3D $(boot)/vmlinuz.efi
> > > +endif
> > > +
> > >  archscripts: scripts_basic
> > >         $(Q)$(MAKE) $(build)=3Darch/loongarch/boot/tools relocs
> > >
> >
> > OK, I will fold this in. This actually aligns it with the other
> > architectures, so I prefer this approach as well.
>
> Thank you, and if "make install" can also handle the zboot case, that's e=
ven better. :)
>
> diff --git a/arch/loongarch/Makefile b/arch/loongarch/Makefile
> index c3f579bdf9e5..5480fe2de7cd 100644
> --- a/arch/loongarch/Makefile
> +++ b/arch/loongarch/Makefile
> @@ -137,7 +137,11 @@ vmlinux.elf vmlinux.efi vmlinuz.efi: vmlinux
>  core-y +=3D arch/loongarch/boot/dts/
>
>  install:
> +ifndef CONFIG_EFI_ZBOOT
>         $(Q)install -D -m 755 $(KBUILD_IMAGE) $(INSTALL_PATH)/vmlinux-$(K=
ERNELRELEASE)
> +else
> +       $(Q)install -D -m 755 $(KBUILD_IMAGE) $(INSTALL_PATH)/vmlinuz-$(K=
ERNELRELEASE)
> +endif
>         $(Q)install -D -m 644 .config $(INSTALL_PATH)/config-$(KERNELRELE=
ASE)
>         $(Q)install -D -m 644 System.map $(INSTALL_PATH)/System.map-$(KER=
NELRELEASE)
>

Is there any reason in particular this is open coded like this? Other
architectures just do something like

install:
    $(call cmd,install)

and be done with it.