Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp5109977rwn; Mon, 12 Sep 2022 04:42:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR4O6AMmdLDUVO3kyRBDxC3evinxGgCJ7Df8XSXq37RW5KPQqpLk8bNCZysXSkcTbaAj6sF8 X-Received: by 2002:a17:906:8448:b0:77b:e6d0:58a5 with SMTP id e8-20020a170906844800b0077be6d058a5mr6110076ejy.347.1662982979417; Mon, 12 Sep 2022 04:42:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662982979; cv=none; d=google.com; s=arc-20160816; b=VgGmD/tZP35OgkaXJoc/jifqlmN/udHiul2ILQ1LXi7yoYBD3jE73uAVj0GAIji3yq USHP3zJdeQl+5SVgiiP7b+e5lLtUlQgHe0fTkfOQbDqEDu3UkKGaGAfShk/nirHdpWWS KFumhx4yCUoi9VAwGUGc97khSaXqVIKMq7uHAAWD2T3/cYaBnVUM/5lx8SpjBKvHznFN U131Zjwz3YQOLqM7lHvbsWpPTMU2xLwDEjIZ56wDrcXZK+okLuEFsoMqqS0Gb0xn1oY2 jzTDHpw0qXmoneHVbzBFo1RKZdCsyT3xQuvhPFqKhetgjgGT1yZhAwuHYnO+CNhxNQ8+ ZXHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rN5cJc1dJAH5dC28+7t6GDU2GBhcvNmbLRkSFvffGpU=; b=n7Gt/5dRiDvEKsjj72Z5V/qi5/ad8As1pjlp5wAn+W45JwL0ppIhM2qyDnp2ySMC37 zMM5Omw9ox5mrx+WH3vRPW2oIlyrtPFu8qT0In4aB9IpHL6RbnB3uEr/3z7DVK2RBXZ0 nJx324MAfmQK7I16t8Mk/foqrGaKjejCSdK3qtjuckXlxhilJg991xBx8tClx7prjKij 6mMUXAQHhNMVqMbdUY2udeXqeDSFt7PQfuCtlwsALz0LPZ6BO3AtABv8G0t3b6lYwqGF 1DQKBYSTKCh4Wu2CShlwWB74XHuGceCbEIkCrDLxbpjqW+xQ9cvHj15bB6fgVlJDBFC0 nJqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="t0Se/KfG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc36-20020a1709078a2400b0072fa13ddca0si6375644ejc.229.2022.09.12.04.42.33; Mon, 12 Sep 2022 04:42:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="t0Se/KfG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbiILLjp (ORCPT + 99 others); Mon, 12 Sep 2022 07:39:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbiILLjm (ORCPT ); Mon, 12 Sep 2022 07:39:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EC385F70; Mon, 12 Sep 2022 04:39:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0C3B3611D1; Mon, 12 Sep 2022 11:39:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 209FBC433D6; Mon, 12 Sep 2022 11:39:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662982780; bh=YVloGXKhM56QYWGpSw8QQeiGROxDfWLZpZwICrSsIAg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t0Se/KfGFqagOtYwm/o8hI1IqCbIl8HIsFfaIcXFAAmOj2/jzd5gb80aGjnQ1+Ch9 bYo9U682DtubhmpfMjJuJvAlhlHrXao1P+/5cB3zUueTH4kjOSLAEYY97T5l/iSKNx Em86vqrhfi9xbp7PKIzu7s1HQ27iMvHd2L5FlPEvjDFNCIyw1EkS4LtisBBfOYw7S6 TATuCivyicc9JayzxW9bpAhD1k/yscBifcczfr7n0OkGcVTcuBfjIIgNXBsC6p5JxZ RkKISEQh5Qk1Irbfa2PRGX4GBkSTXenmWSZQc4j0yuhy40sD+y7vE/yxY+KTC8TCeg ayO5yvVQHk5TQ== Date: Mon, 12 Sep 2022 14:39:32 +0300 From: Jarkko Sakkinen To: Gaosheng Cui Cc: dhowells@redhat.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] security/keys: remove request_key_conswq and keyring_search_instkey() declarations Message-ID: References: <20220909060452.1121620-1-cuigaosheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220909060452.1121620-1-cuigaosheng1@huawei.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "KEYS: Remove orphan declarations from security/keys/internal.h" On Fri, Sep 09, 2022 at 02:04:52PM +0800, Gaosheng Cui wrote: > request_key_conswq has been removed since > commit 76181c134f87 ("KEYS: Make request_key() and co fundamentally > asynchronous"). > > keyring_search_instkey() has been removed since > commit b5f545c880a2 ("[PATCH] keys: Permit running process to > instantiate keys"). > > so remove the declare for them from header file. > > Signed-off-by: Gaosheng Cui " Remove the following orphan declarations from security/keys/internal.h: 1. request_key_conswq() 2. keyring_search_instkey() " Then add two fixes tags after that. BR, Jarkko