Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Sep 2022 14:18:39 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Hangyu Hua <hbh25y@gmail.com>
Cc:     gregkh@linuxfoundation.org, jirislaby@kernel.org,
        changlianzhi@uniontech.com, dmitry.torokhov@gmail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: vt: add a bounds checking in vt_do_kdgkb_ioctl()
Message-ID: <Yx8Vj2GfGxehRAtR@kili>
References: <20220908075403.27930-1-hbh25y@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220908075403.27930-1-hbh25y@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEtFQlpCN2FNSFNjOFpGcWY0Nkh1MHF1eE4wcXV5dkhyMVpsa05pOUxmWjFP?=
 =?utf-8?B?cE9JUnBML00xUFpjTjlXNDJmTkxkWTZtU0JaalZXbGJNU0tJNFp3bFhxbk5X?=
 =?utf-8?B?WmdvZlBMYnowM2R4ejJHbTAwa1lvRDBiOVI3T0FVajgrV0Q2eElHNXJtUk1J?=
 =?utf-8?B?d1hoSlB0NlFEa2tBelBPR0hOOHdQWnp5QkJOZmRUNGpteko3WFlCeVovTmI2?=
 =?utf-8?B?MUJNTnQ1Z3VLczFnSXVhWXAzUWoyV1Iyd3hUdzl6UWk1YlVIUW9BY2YwUUtx?=
 =?utf-8?B?aTBuZTNRdmxOQ2Nnc0tpcWl3SmxGYkdHeS9JQ2lEL25qbEt1OHZ6ZnJXOXNP?=
 =?utf-8?B?VENPanhsN2lobzBKZExBZFZCSS9jUzhaOVVDWjR1b3VNK0ZjQXpsSW9Jdkdo?=
 =?utf-8?B?ejF4ZzhjQzd2dzRORXJ4aG9QTEVOSHg4aWlseGdjcWE5dDZpRm8zNGo2dnBv?=
 =?utf-8?B?Mm1Kc0RBY0M3QVZjakwvTG5hb3YrT3BQN0dQV0x0QjkwVTlEc2Q3VjFiMEtV?=
 =?utf-8?B?dDlkbWVrOXY0Y3FoRUhOUGVreHhqb21Dd2tDMWpIcEl3OURlVTdhbEN0TjVQ?=
 =?utf-8?B?RXJqbXlsVWdpYVllcmNwYXNGMFhSU3NBMUFDckxZRU5qMWpteElaTkoxM3dq?=
 =?utf-8?B?UjdBWDN6S1M1c0lObjBHMUVlcUlsK2NwbnFLOFVGUTdEa0NVWnRKdERLbzZY?=
 =?utf-8?B?ZDl1RFlhOWI2Mk5TbFJEVE9Bdjl5Y3liUUxlSHBzSUNpY014SDZCQnJZaGY4?=
 =?utf-8?B?ZFJkQ3A2SDU3eEdLNFRKd29teUlYalBvck5kL2lPMXJlVFBHVzFqbDdxMzYw?=
 =?utf-8?B?cTlMa1Y2dksyNWUyTnZINjF4VFpqYzQvM1hkdE0zSVdGeHpKaDBNVUR1VVFs?=
 =?utf-8?B?Ymg0c2FOdkNIMzJXYjdpVmNWSldwVEsxMjUvSmYwaXFDR1NRdGxQdXJ6NWtC?=
 =?utf-8?B?cll0S0NBck5EZDJ4eGdGWDlUQ1RnQ0Q5cXlSNHNmVGRJZi9WcEV1MC8vZmsz?=
 =?utf-8?B?TVlJRHdYU2RCL2FDMUVVV1dHZzNtUVhTM2t4a2ltTGVuTDZkTXdjSzhJMWJs?=
 =?utf-8?B?cW5xU1lKelY3c25lWEpFZHYweFE0eDNtWlNZcWJZQkZPWC9Xd0FNa2YwSTZj?=
 =?utf-8?B?U29BMy91TmhmdVNRVWI0Zk54cHZiYW5ZVmhqSWlhMnM4OHFxR2FrZHRYYzl1?=
 =?utf-8?B?cVdGa3lLTHdKNmJhUGRnamlVZnpQWCttK2lkczJQRmdFZUJibGZRdHdwNTUx?=
 =?utf-8?B?R01OM3ZXQnN1eGVsU2QrUms4WkNEMUQ4d2N0YzM5eWJpcTBZemJSRmpIMWF6?=
 =?utf-8?B?eVpHa1pNNUp4VlNSVGhTaHUwOEZyQUNMdnppQnJjUVZOc3d6b2lHK0NOeHhv?=
 =?utf-8?B?V2FkQzl2VkR3V0ZDUmpEVW02OUdZOWV5eWN2MjVJZDJ0V0JqLzNCQVhNYTYz?=
 =?utf-8?B?UDFNSlRtNXhYYzlGQ0RXTUpZS2FHVkI5RE5DcXB5UUIzUWQvdDcvUkUwVk5p?=
 =?utf-8?B?TXozZGhEcTJWTFBRT2dydXpQWXIwMGQrWXVwRzN0YmZpNzdkV0M1MHprUlQ0?=
 =?utf-8?B?L0xnZ1J3bjFZK1YwRVJkdVpIS1RTelFKWHdoMFVzU3VkdlVWbVl3dE5RK2FP?=
 =?utf-8?B?ak04MCs1TjQ5b2RVUm1zZThYSVh0TkUxSmovRGp4cXllK21ZdnVUNTl3bi9R?=
 =?utf-8?B?NU9WdnVaU3V1S3VCZDUxSzg3a1IrVHh6MFZHTUkxVEZjWkkxSll6cUJmNlV2?=
 =?utf-8?B?Ri9MQkJUelBhU1owbHFOTncxUURkTXBZOEpTVHkvZHNrcnFJWjV3WDRQTkRM?=
 =?utf-8?B?MDVUcjlCUzRWcERTdmFndW5iRXJtTnd3ZU83ZVpLQ0d1Y1FmRmdrZjgvQnRu?=
 =?utf-8?B?VjM1aEVJWkpKMG5VeWM3TFJ6WGROUHRLMEJRSmlET1dTU2cvbEZIbTkwYWFP?=
 =?utf-8?B?eXUvM0JVOHpNYVB1MmE3OW9UUjJlaHdpT3dEb1lKbWh0N3FKbVhuQS8vaWJD?=
 =?utf-8?B?NzJqdGhDWnBXTUsxRm1GVnRoUS9rNWJyaFB4TDFncmNZTmkrODRpeXRibzhl?=
 =?utf-8?B?ZDZldkgvOTFTSm13aGxRbno2OWRic2t2Q3hST1VDUFQzMXovbmZGaitBTjJp?=
 =?utf-8?Q?33TKzjW9PVsXU9epEy+XhVUyh?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b76c2baf-7a41-4b28-28d4-08da94b08e80
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 11:18:46.1326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TylPAwZhZYYZzd7HXwM7MyvKcy7S7+UGzQvu72+KNkaCkc/PXh5JIlFGjtn8YjAFIiFxwJaFjHA3BF/nCKz3Fzi4Q9aeCkJr64n7KvNDS/c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4159
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-12_07,2022-09-12_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 bulkscore=0
 malwarescore=0 mlxlogscore=623 spamscore=0 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2209120038
X-Proofpoint-GUID: 5kiZ1f9hVfOYUPtrBqNS9qXyDDn4sN-7
X-Proofpoint-ORIG-GUID: 5kiZ1f9hVfOYUPtrBqNS9qXyDDn4sN-7
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 08, 2022 at 03:54:03PM +0800, Hangyu Hua wrote:
> As array_index_nospec's comments indicate，a bounds checking need to add
> before calling array_index_nospec.
> 

This commit message doesn't explain the impact to the user so the patch
was going to be rejected based on just the commit message regardless of
the actual code.

regards,
dan carpenter