Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Sep 2022 14:29:17 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Yu Zhe <yuzhe@nfschina.com>
Cc:     rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        liqiong@nfschina.com
Subject: Re: [PATCH] net: broadcom: bcm4908enet: add platform_get_irq_byname
 error checking
Message-ID: <Yx8YDUaxXBEFYyON@kadam>
References: <20220909062545.16696-1-yuzhe@nfschina.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220909062545.16696-1-yuzhe@nfschina.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FNe31lG6pVYZc6ZKQt8DnVp7PulC12pntGsWDN+LbydpQ3tlWDJYb7OiruaE?=
 =?us-ascii?Q?WWEY5yI7JMwiL6Y+NZd7CnVtBTA6Bp39ZROq26UgooU7mBi1ALwSwXZuqRcc?=
 =?us-ascii?Q?zgJNnnxHK4kkWFPpjHF7nEjUjZgpgx1aswaxdoTxf2lnoAbUw6BCa74nLpsp?=
 =?us-ascii?Q?BxOX0cP75NKQYFdPKwj0ShPymH8AOcLQ/j+ts75iFXg5SpXreUykEGR1dVGE?=
 =?us-ascii?Q?0i17mw+Gwsoi/JgE+fL+9O6JMFNfEW02b2TKUiYIH62VZtvmkp7Ffs8Br+25?=
 =?us-ascii?Q?QlTFCfGjCWaHwmR7kbdxUgC7w3kT8LxPclRm8hUqXF9ava8zIAjnYwTHp8fF?=
 =?us-ascii?Q?m07cIUX0jQBQFby01ETfEW4/EFOkZFbs25PvSvwvaEW5Nrf+cj4z3bpOOT8N?=
 =?us-ascii?Q?n7w37UGrmh6dVK7h9kG+7CW/mlc9ZbjBC++Ox1ouI1C5TifCapvhDRLlIVl+?=
 =?us-ascii?Q?S6fepL0mTHHqplqW8jt705xlp3/jEsrC/mvd8xH0Yb/l5A/97WuAHOF+N45a?=
 =?us-ascii?Q?rLN9/1iuvCVlTqbsNeyBeoBFgBouCKxXsT3wuhy04f0x/HsTfnUbUhPQyR/T?=
 =?us-ascii?Q?rbvwii/J/O1DFn6bCrMvgKEwT+bEu/Av+Y/yw61x36OOCSn61ddn0N6UfSfy?=
 =?us-ascii?Q?JrfsjlcxiuhxhmgkysOaKGqeAc0ydbe8zG0rH7G8/CoXLcy3g0uOMUdEljuD?=
 =?us-ascii?Q?Aanj85tyBAse/cvMVwWvkPNJfB1orJJ2leCfllylJqeKHGYVn/jK6PywuWHo?=
 =?us-ascii?Q?yt8QMQ4Yk+4Msje5PBqSC7XYCF0GqbEvLv94n21JKM/NBnJvjceC36BGXNN6?=
 =?us-ascii?Q?5y3DLIElIA8VZVo6eedGjATx+ebzHbOTLhEP6OTe9vNYIzzW8+rMpvgTd/cn?=
 =?us-ascii?Q?rLSz1949D2LkQ0UsCrpqo5DYu6L6tx4DOLZoJJTVu/QFaMNdz4XTaDoNaLre?=
 =?us-ascii?Q?VPS1tAqBeIJQFDMCG9H1n2FjT994w7Z6Bkm1Y+K4/s7rUoRYIp7VM1soZH2k?=
 =?us-ascii?Q?xzw9LpVYPeywXhgV6jzbqElMv3Dm345p/3vqJPkgvbntL3VXFrhpzdTV1lve?=
 =?us-ascii?Q?uAMWEIr7IFcYKPPXVWu1RjaBIW7QZflvXafDg5ExB11ETALNn/A6oGtwS0Xy?=
 =?us-ascii?Q?B6+vdQlQibs+eyOdlIt+HpRViLWOPr6dflhhOsx5HzkKIk1OWdxhB5gdl9we?=
 =?us-ascii?Q?DYKb66/ihXNEgcb5HMo1YlP49d8C3p6orYYFP+earCr6vkgbn1XfkaUhf0vd?=
 =?us-ascii?Q?McjEroCL0/ysO02wd+FIAc9pXmN/PvuPQu4UsOiYm4oIoZjAXkPj8rOBZYBJ?=
 =?us-ascii?Q?nqT34EbTVdUIZlvVWpS6Zu9RKPNa9/RnXcpEz3eaFQhS5Uxm5ZN9LwFd8gpy?=
 =?us-ascii?Q?MaHzE31QBjrm3TtaC+xopr8HfRh0JtKJUf1JEWlS1FSE28zz3k2hBFHjeHnq?=
 =?us-ascii?Q?h+iG/3wvSJBf32osi1DMITe+whU5o51YVAwNPm5m0Y325XL0tzcuMmJzqR7j?=
 =?us-ascii?Q?GDmsetDMXc8IVSAERwvZNUkDgfoJPVsSY/6kdl6jaWFZkVt97AT+JjN+7Qlz?=
 =?us-ascii?Q?Yo/OBxcuFJD/9d6R96Dcba6n5hL3TmRMIfNeFmF4?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e341feab-bc50-41d8-4a28-08da94b20cce
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 11:29:26.9250
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5rujjmSeLCFOb8Ywx6CAJO7OATKRBqDSJDO5XQKLt9lmwk292bDm18m0kmFTA2MRsKUEJO9wP8tqSTbkssdBnDhAbM0f8DEhK9fFwVhLTSw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5227
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-12_07,2022-09-12_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxscore=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2209120038
X-Proofpoint-ORIG-GUID: lUE19dp9hoFFe2NrrWre0TmFbaJdHzGN
X-Proofpoint-GUID: lUE19dp9hoFFe2NrrWre0TmFbaJdHzGN
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 09, 2022 at 02:25:45PM +0800, Yu Zhe wrote:
> The platform_get_irq_byname() function returns negative error codes on error,
> check it.
> 
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
>  drivers/net/ethernet/broadcom/bcm4908_enet.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/bcm4908_enet.c b/drivers/net/ethernet/broadcom/bcm4908_enet.c
> index c131d8118489..d985056db6c2 100644
> --- a/drivers/net/ethernet/broadcom/bcm4908_enet.c
> +++ b/drivers/net/ethernet/broadcom/bcm4908_enet.c
> @@ -705,6 +705,8 @@ static int bcm4908_enet_probe(struct platform_device *pdev)
>  		return netdev->irq;
>  
>  	enet->irq_tx = platform_get_irq_byname(pdev, "tx");
> +	if (enet->irq_tx < 0)
> +		return enet->irq_tx;
>  

If you read the driver, then you will see that this is deliberate.
Search for irq_tx and read the comments.  I'm not a subsystem expert so
I don't know if this an ideal way to write the code, but it's done
deliberately so please don't change it unless you can test it.

regards,
dan carpenter