Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220910170207.1592220-1-danct12@riseup.net> <0a2bb48f-c67d-0544-5037-d02f658a3351@connolly.tech>
In-Reply-To: <0a2bb48f-c67d-0544-5037-d02f658a3351@connolly.tech>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date:   Mon, 12 Sep 2022 16:32:06 +0300
Message-ID: <CAA8EJpr4_G_uK5oj9Y0j_tE_LsnqDHKaU1D_nhXOiL0sA=aMnQ@mail.gmail.com>
Subject: Re: [PATCH] clk: qcom: sm6115: Select QCOM_GDSC
To:     Caleb Connolly <caleb@connolly.tech>
Cc:     Dang Huynh <danct12@riseup.net>,
        Bjorn Andersson <andersson@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>, linux-arm-msm@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 12 Sept 2022 at 16:17, Caleb Connolly <caleb@connolly.tech> wrote:
>
>
>
> On 10/09/2022 18:02, Dang Huynh wrote:
> > While working on the Fxtec Pro1X device, this error shows up with
> > my own minimal configuration:
> >
> > gcc-sm6115: probe of 1400000.clock-controller failed with error -38
> >
> > The clock driver depends on CONFIG_QCOM_GDSC and after enabling
> > that, the driver probes successfully.
> >
> > Signed-off-by: Dang Huynh <danct12@riseup.net>
> > ---
> >   drivers/clk/qcom/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> > index 1cf1ef70e347..d566fbdebdf9 100644
> > --- a/drivers/clk/qcom/Kconfig
> > +++ b/drivers/clk/qcom/Kconfig
> > @@ -645,6 +645,7 @@ config SM_DISPCC_6350
> >
> >   config SM_GCC_6115
> >       tristate "SM6115 and SM4250 Global Clock Controller"
> > +     select QCOM_GDSC
>
>         depends on QCOM_GDSC

All other Qualcomm clock drivers select the GDSC if required, so I'd
tend to disagree.


-- 
With best wishes
Dmitry