Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Sep 2022 16:25:02 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Nam Cao <namcaov@gmail.com>, Ji-Hun Kim <ji_hun.kim@samsung.com>
Cc:     forest@alittletooquiet.net, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vt6655: fix potential memory leak
Message-ID: <Yx8zLugepoJkJjHj@kadam>
References: <20220909141338.19343-1-namcaov@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220909141338.19343-1-namcaov@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PsEduMj7p+HqbM1uMMh1orrLHoXsSCj5JxwTr0G7+IV3z3p9mI/+dAjyT7rx?=
 =?us-ascii?Q?w40qtrWyJI8/0/Po6VKcZMBpjLqj9uNucK8dydPtT4yF98VoKLVXV2CGHU4K?=
 =?us-ascii?Q?sTXtByiW11HGUvG9XHKfeFPtwenTRbiVxXSW4m/SrZBhyK8LLmAcC+40krDR?=
 =?us-ascii?Q?wNFpxu6aCYhTlSrDatiE6hmyjfIQAfYLHvSEV/65GuSJVBXnzoAANNXo6NP7?=
 =?us-ascii?Q?mCgYcYf4D9owy+yuEWkSj0GZGNSFBCVfSW0XIvmt4At3/ceg4k0GFE20DlMJ?=
 =?us-ascii?Q?sz1Tb14iQnFlXHMhRjicn9DTBFjeQsnqwGVj1u5ORtnkySMMfkeCHWZvBeiS?=
 =?us-ascii?Q?v5RlRxyTsy5uVsO9rAt2TfavsgwhhWQKaZmcKHvMaBA7DyOronOrwqzBViKl?=
 =?us-ascii?Q?hsdcI7AfiwjKSzr/O0bS/+WNpeosdWgZMJhV2RrVUM3r6RhT0+oh67nG6MS2?=
 =?us-ascii?Q?h/a3WWPqbcIZzFy9PFCsjU1jp27MYmEJ17j2EK8DoShCbOkHKR/6LiaE4JUC?=
 =?us-ascii?Q?U/xcjnFhl2ekVdip1znv3H7VDwES7+Vwlbny/mA97DQxUdgACA1FM0xJmUN8?=
 =?us-ascii?Q?DdfIjPrwatvn1VnmUAHRoA7VnDEQmp224U6iC7ZECJTZkLS/uOoz9EEcQtc/?=
 =?us-ascii?Q?LFEPysyIGA64WkASz9d/dnj+2/gR8ZHQqmJfkCVy2p8BuzvZXQrccdikmOCy?=
 =?us-ascii?Q?tXDCNUSL6LwtjuV8Bak2VKN1VJoODX4kOTzCuFdjM+Y+1NjDBE3O63RaxgJB?=
 =?us-ascii?Q?3ElpZSRWQjoYWB7+o0kAyX8b8TVba7lIZGup76itVAvD9rf0SOLxfF71D5iH?=
 =?us-ascii?Q?XuThq55MUNo6JrAnCOG703Zt/mLw0vldjD4x3MFrbPNir1KZoL5w8e/Ypn2Y?=
 =?us-ascii?Q?zi8mdANDCp7I0lWZucIBk7JHL0qbPitB8Daq+AUqMU7X6YJ81pOf8MPKW8KK?=
 =?us-ascii?Q?d6FCxhmKU/D8WbhGxCHj1cYPlnpouB+7Y7MNd5rh6jcrF/c5Bz0ZBXJaOxoR?=
 =?us-ascii?Q?cBt68kXKgTqEK9lHdoELhaXsf61U8F00qVbMs7m+SNJ57iE4w4VlLQdydmGk?=
 =?us-ascii?Q?APQA8ID7IaMZuAn4TkIU9mjhPQtumkIdrapBDos/xdctTK7bVZYPAKxHzF1i?=
 =?us-ascii?Q?bydeNf01+TAAmvsvOlGhF+WwYJrPgH5G+KC8sp5MiwIPosa3XM0/sSZpdXoP?=
 =?us-ascii?Q?CdILfts/24KZcCHpDy69GgeJP9r8jIRAlsCeLT51wDqyo2nVuHjH5HSq8nFu?=
 =?us-ascii?Q?ppJ2HLJ21gDfLrQDyHpfMtsUdIdHzYWoynFfJwLprbC93x58yDQvPAaNqH2x?=
 =?us-ascii?Q?jZ4a7c8s1fjTROB2maVwiJnb5V/9CwuIyoDevR7ZuwyPsQtGaTvxiOZ5d5ov?=
 =?us-ascii?Q?G+i8Du1muEAtD2Vq7Ufoluj7pNwOy7v4CCfPdW3Gk7jy/B/ihu+I7LrGzCAo?=
 =?us-ascii?Q?0mo9A27Br77fI/7eQuTs782lDq3PcO0Jtnw1RV6yNvvN7VilnX1c+ilh9YYy?=
 =?us-ascii?Q?hg9DiAYoMxl30Q7P8yDKq6Tgl7Sl0Sr3dyBUXtuQkeA0uHCTMxT08NUhGI1x?=
 =?us-ascii?Q?QdT+V6ed14twh2ORrD3r3qgNLuiOEniGhZ5vHjKH?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1507b488-4902-470a-4772-08da94c2392d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 13:25:13.2993
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e22FC1z6yWLirSQgKwW2SAIOvrWci5xnk+IKOzQb/S0NWjmbZcJphqQKh9bi88GRV3pTuRYcuDhU5Mvk8IE97I/MnWKM33gTYHaXOwM42g8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4763
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-12_09,2022-09-12_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxscore=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2209120045
X-Proofpoint-ORIG-GUID: YQu44G7rIgUfgOgMU52X1xw-VCrO-vwV
X-Proofpoint-GUID: YQu44G7rIgUfgOgMU52X1xw-VCrO-vwV
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 09, 2022 at 04:13:39PM +0200, Nam Cao wrote:
> In function device_init_td0_ring, memory is allocated for member
> td_info of priv->apTD0Rings[i], with i increasing from 0. In case of
> allocation failure, the memory is freed in reversed order, with i
> decreasing to 0. However, the case i=0 is left out and thus memory is
> leaked.
> 
> Modify the memory freeing loop to include the case i=0.
> 
> Signed-off-by: Nam Cao <namcaov@gmail.com>

Looks good.  Please add a Fixes tag, and CC all the people who were
involved with the original patch so they can review it.

Fixes: 5341ee0adb17 ("staging: vt6655: check for memory allocation failures")

I actually wrote that buggy code and Ji-Hun copied it from me, so my
bad.  Sorry!

regards,
dan carpenter