Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Sep 2022 17:17:28 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Nam Cao <namcaov@gmail.com>
Cc:     forest@alittletooquiet.net, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vt6655: fix potential memory leak
Message-ID: <Yx8/eKbkOs8AwGpK@kadam>
References: <20220909141338.19343-1-namcaov@gmail.com>
 <CA+sZ8B-z7nRdJLhxeJ_tWSj_LBSwoFgtQja1-vDnBVdR=b0=DA@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+sZ8B-z7nRdJLhxeJ_tWSj_LBSwoFgtQja1-vDnBVdR=b0=DA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9mM/QXD1xmcQI37/9Xks/hqxlZZrAIOInrpH3oUgV2Re3ma+hJT1Wk88XpBp?=
 =?us-ascii?Q?hd2IV+sHau4LDEHG/GbVMMjr6EFmWHtD9kAayv2X+0n2w2QFQLXRjFmob7X8?=
 =?us-ascii?Q?jwzTnPidlJ3tDuxlTV6fKB5aydHLVdLk1JuE9DKv7MJUU9H2SPyOOvmAZ0I8?=
 =?us-ascii?Q?eO19xBqkRbnWnVU7JlIAGqt6i4O4oYybyGDAJ0Czpp7pvWgdsgYi8sAOWrQo?=
 =?us-ascii?Q?MAKTPDpNK0oegO7D3rNPXm71tXv09EFSEzCe/1VuB6Ye6r2SdxVynGGMjdoJ?=
 =?us-ascii?Q?GFdiXXksdBSfDvNwqxGD21R25nZUkcTQ6knP492n8WwkORTj+5MUhmfLp9z8?=
 =?us-ascii?Q?F/mmBfUj+rsuGe7ouzbbTV1aSrbQENWbNhDQcYYR3pq+nQDcoB4nXJgl19Kr?=
 =?us-ascii?Q?kJOLla2q22WNggNKO4JwsUDRhNu3KjOAARkGyPGb3Ddha+xon8g4e0kRwvNx?=
 =?us-ascii?Q?caFZrKiy8kwlH9eIgrCIOiNCaZWZ+wS+8Uirn8fe5AGRxOh89593Nl5d7MVV?=
 =?us-ascii?Q?g6eNgjrL4XQrMI/oHpSRlzlidDXbI3ZZ9O1TdGRwobeTj6cmH/MDEg6vO8lv?=
 =?us-ascii?Q?hefDxsRU5tunEYdDYj0mRvF/ZFhR9RJKUSVN/m08VyECRspN6vZrSi/3ESFo?=
 =?us-ascii?Q?dE5TUPH8dIfYmibYrgkbRx3KGU7HIHO84kN1opbyemyXfOIkCL8L+I/k9gXf?=
 =?us-ascii?Q?qWXwA88x+qj+vJz44Wo5OICnaNte1qBPyzCpufFFXDDU74TKj7xMuxALlbez?=
 =?us-ascii?Q?P6qPo1Ysw1urBPTmcTNRL84zaNaVjIiCkC51YITMkt82UmmWQzxzKNYS6c03?=
 =?us-ascii?Q?fzF+w7/8JvR9XWhWvxl060hyhmM5xClL8LMCKKmuzX6btg7P70Ctn+sfGRkh?=
 =?us-ascii?Q?lsl4GQpPCIPBXWo+ThUuOGL/yXFxtQeE6SkR7cZIfFQZ7w+DApfK0Blr8sdV?=
 =?us-ascii?Q?EWY5KbDmUn19yoIGt0GGt4sILYwE12ilM7QOyGl3TEKVt93yyJ+6E4czZkG2?=
 =?us-ascii?Q?0j21AcQhUq8C7R9pxt+DP5xY9XAPZimvnrP+RolG2iTbk/qk20Ga5kLgBRjt?=
 =?us-ascii?Q?fl9UMo0OAUSBJRT/We8KZVSTQ8uhEpcP7YYCu5l91axXYX9Yz8AO74w1BoxT?=
 =?us-ascii?Q?0mL6EMdYj7Y0Cot231TnI/6gkbKxmzQruTtiXln8X6DzW7GJzAjfsx3ZfyOA?=
 =?us-ascii?Q?7BIqOAB3P4KPhbwiyFzTc0XUGjG2RfgaR6F4uUIsAMxbma+tL9hGugv9KPFs?=
 =?us-ascii?Q?nGWR+eOz+mEe544kCx6zmVwd2ckM5Ug1AQpb+sFpSC4GJTgopQNTxlGVKTJg?=
 =?us-ascii?Q?vZ8AEjSAAubHpldEnfjCaG+MP+ExQqjM5ezRknmk42b3Eh/dpUFamaR5KWci?=
 =?us-ascii?Q?rgLlz7532gJpi7O+swiV7zKIDUr/tw3g+F90eV+0gDmX78ZwN0HssU0N4d9o?=
 =?us-ascii?Q?rBqZAl8GUadpI0IkKDX1EOumu0aflQfJNWyyXPkIabPmvJrrS23f0EfcCFPO?=
 =?us-ascii?Q?skqVDzGN5OT/C7H+Qkhs+3pBQ0OQ3kHdN2uNBfsTZjtp2ExX02h91tsKWjMN?=
 =?us-ascii?Q?YQoOQcAmhcVykWHsB4qBSw/ca36UVxW3BB4WGoi9?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78dfd1d6-f72d-42c8-3231-08da94c98b6d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 14:17:37.9404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wqLbiN7TX40JyLpBIYH28BaQ7SYL2fCEeyQRZKzoNeNSTyxj9FlQgLHtjGxq/kc8dXB12U+OU3XNnUh4lSM0qv+p/k9BiqaIQCiIZgInMNo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5188
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-12_10,2022-09-12_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxscore=0 spamscore=0 mlxlogscore=805 adultscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2209120048
X-Proofpoint-GUID: dJ2cUsSrYJ_ZI7N3-rXkgxU3muN3L5yQ
X-Proofpoint-ORIG-GUID: dJ2cUsSrYJ_ZI7N3-rXkgxU3muN3L5yQ
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 09, 2022 at 04:42:05PM +0200, Nam Cao wrote:
> I did not realize this initially, but this bug can cause more serious problem
> than just a memory leak. In the case that kzalloc fails right from the
> beginning with i=0; then in the while loop, "i" will wrap around and the code
> will access priv->apTD0Rings[4294967295] which is obviously not good.
> 

True.  You probably want to resend with that added to the commit
message.  I will create a Smatch check to prevent these in the future.

regards,
dan carpenter