Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp5359591rwn; Mon, 12 Sep 2022 08:00:32 -0700 (PDT) X-Google-Smtp-Source: AA6agR7ZidotPd6+X5Wg36hJAS1BqxezVxka6Pm6ldNKpQHzUiUm8nd5YYtRiUXkrAR/grmtwoi+ X-Received: by 2002:aa7:d883:0:b0:44e:bbbe:d661 with SMTP id u3-20020aa7d883000000b0044ebbbed661mr22549945edq.248.1662994832287; Mon, 12 Sep 2022 08:00:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662994832; cv=none; d=google.com; s=arc-20160816; b=CTGWURHQGn1+SWVxZhfQU0N1HhTTcqPdp3F9olbmuCfxH82KT9uOyUV4aiGODff7mT LBHmrWW1jTkijblc8p4C2NF+ImdMsG1D6e4W2krJqrjJPQXTsKtbDwz2XyZ12Jpi51DJ yVjpecFybn4G/PzMjU+cq2prSRY7CjtBfqddxjpSMxLZ9Sj4U+rLtGSiGd+NEn3KJXbk TVx9HOrBxiHDc2Xq2FNkpFYGX94knimfg/ppO+0Eiaw/NbC6DsW0R5ang7iZVSxbWBL9 K0MNCgpxvPelxEpcY45dc2I6BJsxdOOGhP0mDlo2kL65ZunQWWyjarPBxNHsGIY+JZs1 F2qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=TwDyrRndMjfHyW6ko+lvjWhzK4QcQhLfN6rVCwyq68Q=; b=rWcNAVoePBQn8uepjaKTmSIz/eaJxeyZiAsT1PvtCczUG/Jz1hiOVg+GLD8UoFY/Ha 5iLEvUbb1eeLsnNWhRtHEkqyFJJ5h856sQYw0+zTDLT2RQWO5j3OZ3erM2yFDtpYkGyO pKK0ZGr5aAFyPFhbrLz86i5J6W4mHoFen0n3tJSvP5qLGSJhfKgNc23wLE+5btkpMUlb 2FSsLo+RFoDxTmu2gOtJXx8sv4IiI/Q2ONN6xx5JXQnlW8MSqpUvr9+QRWnf91b1IX8r o0UgVlgU+NNhUMDFEE5DY41bg5evEe8EPR+cuFiOjUptR9QAbIIYxP44lmuxxIYlT0cU MF3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v15-20020a50d58f000000b0044e9fd71b82si6954562edi.280.2022.09.12.08.00.06; Mon, 12 Sep 2022 08:00:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229735AbiILOlO (ORCPT + 99 others); Mon, 12 Sep 2022 10:41:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229724AbiILOlK (ORCPT ); Mon, 12 Sep 2022 10:41:10 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 54BEABE06; Mon, 12 Sep 2022 07:41:08 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 60317113E; Mon, 12 Sep 2022 07:41:14 -0700 (PDT) Received: from entos-ampere-02.shanghai.arm.com (entos-ampere-02.shanghai.arm.com [10.169.212.212]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 872083F73D; Mon, 12 Sep 2022 07:41:01 -0700 (PDT) From: Jia He To: Len Brown , James Morse , Tony Luck , Borislav Petkov , Mauro Carvalho Chehab , Robert Richter , Robert Moore , Qiuxu Zhuo , Yazen Ghannam , Jan Luebbe , Khuong Dinh , Kani Toshi Cc: Ard Biesheuvel , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, devel@acpica.org, "Rafael J . Wysocki" , Shuai Xue , Jarkko Sakkinen , linux-efi@vger.kernel.org, nd@arm.com, Jia He Subject: [PATCH v6 0/8] Make ghes_edac a proper module Date: Mon, 12 Sep 2022 14:39:57 +0000 Message-Id: <20220912144005.212624-1-justin.he@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit dc4e8c07e9e2 ("ACPI: APEI: explicit init of HEST and GHES in apci_init()") introduced a bug that ghes_edac_register() would be invoked before edac_init(). Because at that time, the bus "edac" hasn't been even registered, this created sysfs /devices/mc0 instead of /sys/devices/system/edac/mc/mc0 on an Ampere eMag server. The proper solution is to make ghes_edac a proper module. Changelog: v6: - no code changes from v5 patches - add the reviewed and acked by from Toshi - describe the removal of ghes_edac_force_enable checking in Patch 05 v5: https://www.spinics.net/lists/kernel/msg4502787.html - add the review-by from Toshi for patch 04 and 06 - refine the commit msg - remove the unconditional set of ghes_edac_force_enable on Arm v4: https://lore.kernel.org/lkml/20220831074027.13849-6-justin.he@arm.com/ - move the kernel boot option to ghes module parameter - collapse th ghes_present and ghes_edac_preferred into one patch v3: https://lore.kernel.org/lkml/20220822154048.188253-1-justin.he@arm.com/ - refine the commit logs - introduce ghes preferred and present flag (by Toshi) - move force_load to setup parameter - add the ghes_edac_preferred() check for x86/Arm edac drivers v2: https://lore.kernel.org/lkml/20220817143458.335938-1-justin.he@arm.com/ - add acked-by tag of Patch 1 from Ard - split the notifier patch - add 2 patch to get regular drivers selected when ghes edac is not loaded - fix an errno in igen6 driver - add a patch to fix the sparse warning of ghes - refine the commit logs v1: https://lore.kernel.org/lkml/20220811091713.10427-1-justin.he@arm.com/ Jia He (8): efi/cper: export several helpers for ghes_edac to use EDAC/ghes: Add a notifier for reporting memory errors EDAC:ghes: Move ghes_edac.force_load to ghes module parameter ghes: Introduce a helper ghes_edac_preferred() EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes EDAC: Add the ghes_edac_preferred check for chipset-specific edac drivers apei/ghes: Use unrcu_pointer for cmpxchg EDAC/igen6: Return consistent errno when another edac driver is enabled drivers/acpi/apei/ghes.c | 82 +++++++++++++++++++++++++++++++--- drivers/edac/Kconfig | 4 +- drivers/edac/amd64_edac.c | 3 ++ drivers/edac/armada_xp_edac.c | 3 ++ drivers/edac/edac_module.h | 1 + drivers/edac/ghes_edac.c | 78 ++++++++++++++++++++------------ drivers/edac/i10nm_base.c | 3 ++ drivers/edac/igen6_edac.c | 5 ++- drivers/edac/layerscape_edac.c | 3 ++ drivers/edac/pnd2_edac.c | 3 ++ drivers/edac/sb_edac.c | 3 ++ drivers/edac/skx_base.c | 3 ++ drivers/edac/thunderx_edac.c | 3 ++ drivers/edac/xgene_edac.c | 3 ++ drivers/firmware/efi/cper.c | 3 ++ include/acpi/apei.h | 2 + include/acpi/ghes.h | 36 +++++---------- 17 files changed, 175 insertions(+), 63 deletions(-) -- 2.25.1