Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7c260dac-b29f-80a5-84da-cd2fd9cb63b3@nvidia.com>
Date:   Mon, 12 Sep 2022 15:49:09 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 1/2] mmc: sdhci-tegra: Separate T19x and T23x SoC data
Content-Language: en-US
To:     Prathamesh Shete <pshete@nvidia.com>, adrian.hunter@intel.com,
        ulf.hansson@linaro.org, thierry.reding@gmail.com,
        p.zabel@pengutronix.de, linux-mmc@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     anrao@nvidia.com, smangipudi@nvidia.com
References: <20220912132337.18159-1-pshete@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20220912132337.18159-1-pshete@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3NWNTVQcHRCcEk0dnVJRG5PNTlJN1QrNGpyWmtlYjlacklnUEk4L2xOc2Zi?=
 =?utf-8?B?aE9ET0xjNmg3R01XZFBIM0RTZ1ZLUE5qdVNhZW9TdUUzUy9iYUd5SzFJbERU?=
 =?utf-8?B?T0lFU21YMFJXbnRpZW9na25HeFNFZXFlWGNiTVl2UGRLZUd0Mlc1MC9oUG9X?=
 =?utf-8?B?T0FtVUE4bVdaK2dQM2NYY0FwR1NJL3JVVDJydGthRC82dUx4WERobTdHbUJ3?=
 =?utf-8?B?T0JsRHZJak50VTZjNDFxcWpLZVYvME9iNm16dndMT29FN1dmc1UyWjdOQnNa?=
 =?utf-8?B?enlPcTlLeTJCOFFVT0laL0d4bnBvRnB4SmpZcHBrRGdCM2JSNFJlSXZDVWMy?=
 =?utf-8?B?d1diTUlyOW1PVGdhZXZkUDA5QXErTG1uREdXaStDbGtMMVUwdXA3OTBQK2gx?=
 =?utf-8?B?VE0vdFRvK1NGdzJ6VE9yWkJBaUlMMlp3Mkd4Y2tRbXB1N1lzNWxKTzFCMGdJ?=
 =?utf-8?B?UmhQVGtMS0tuTU1vdGEwRGtBN0lqdEhpZ0xNMTNiWkVLcGpQb1JzdDhqZnZx?=
 =?utf-8?B?M0Y3c2ZzektXcWNkcGc4TjN3WUIrV3grcmF1MTRkSmw5aWFGT1U2ZlJramJm?=
 =?utf-8?B?VCtLRDRuOXk4VG5pbWVpTnhNM1lpcUxEU3pWc0hjK3N2WXNhN3dnZkVvNDBj?=
 =?utf-8?B?amlrUDQzWUFGc2hHOS9JYTZaL0FzUHJDMFVUcmxkQlRUdUJnZU91SGVJaFpU?=
 =?utf-8?B?dmJseEFnQXpBZUUxN3I2cWNxK0ZVU3FKMHArNzMwN21EdlQxUWZ2aXBxSTdO?=
 =?utf-8?B?UTFmcWdwaDhtV3EvU1Q3aklGUFpQOExhUGQzL2JlSG11WnhyeElIZzRlMzVW?=
 =?utf-8?B?UVRmRGZPcG95dGFpQlEwVmhqeUFrT0VPVkJWbjBkYjlMZ3pTYytwYWM4bmFR?=
 =?utf-8?B?ZFduYzRNdW52UjR3UzRHMXVKa01xem92VzhtN2s5cGw4ajF0RkNTaWM2UVJj?=
 =?utf-8?B?VjZwczdWRllEbVFDUzNzdHJkRTFDMzhPRlFma3BVZ0hxSW5mSkZJbW9WT2xu?=
 =?utf-8?B?WEdLVnlEK005SStyeU1ET1U0QzE4anFkMG9xbmtPWktPZjdnSzhVWnNhSXpR?=
 =?utf-8?B?U2xabDZkR0c4bzNRaVBsZGxDUjdvSFo4bGtEdUVOdzh2MDB3ZXl4b0hKZmwv?=
 =?utf-8?B?WmFZaGFxeVdpSzdsckVCeElHSW1aMit2dmRyNUdGT2d4TmliMzlubkpXRHov?=
 =?utf-8?B?aVhxWXZhWFZncTdCOU9wNkl6THlLRXFtZmlaYk1Zdk9QYUhscU9URmdCaGg0?=
 =?utf-8?B?aEtHZFpCWDZSWXpOUWpaeTEvbENja3VYR3ZkY3NwT3NlUVd5aVlKWUdoVWFo?=
 =?utf-8?B?RkRvUzV2WmZoVWFmMmI4UTNLK05ZcXRGekhMRWtBektLbUd5R01jWURIZzBj?=
 =?utf-8?B?M0lUUHY1R0FqbGcxd1poOGxDbllReVJidkljcGxGalpzbG1Bc05za3hhTzFM?=
 =?utf-8?B?WDlUTlo1TCtPY1l1Q1VpVGpqUDJ6SlRWOWljNzBnSXNVNUtBN1c3U284SzVE?=
 =?utf-8?B?UUcrNnR4dE1lVXlvdFNWR1ZwWTlyaVpWcGVFZmRvZUFCS2RlUFF0MGpRZ0dm?=
 =?utf-8?B?blpjT0JOc08vOWcvODNyZDd6bVo1bVd1ODVleS9DU2g4SGdHbTJyT3dmQkRu?=
 =?utf-8?B?NloxTUhkcUlNdFVxUUkrUndsU3RvK3hCcmVHMkxXbE15bEpjUlNsN1lhOGRZ?=
 =?utf-8?B?eXEyTE5kaTd2RzExZVN3YzVlZlBweEVSREFFNzFaeWVPZjNqazhFSEltaVZR?=
 =?utf-8?B?RXJkOFYxaGJ0d2VGa1ZObklmVERVbWgrc0tJaXNsbDZBd0NrWVBNdEwzbWtI?=
 =?utf-8?B?UmxwUVhjT0d5UkxobVc1QVExU1N6N05oSUdPYzc3d2lnVlRHRDVRd0tSWmwy?=
 =?utf-8?B?VmtxUTFtbWZsWm9IQXFMTGx2SkVKVUNIaHJnZlhKeW1pTkcvaCtJVE9OZUR3?=
 =?utf-8?B?QzgxUG9oQkQ1RW9JaXlvV2xLdWJ4SElRUklkY3pEVEc2cDlBYlVBOFc2a1U5?=
 =?utf-8?B?MGg1ZUM4Tnh0VENtZkFpeFd4QWFhTlRyd0YrYk52c0M1WXVEdXUxMmRINlZJ?=
 =?utf-8?B?ZVU4emIyOGhjampkZmxOZVk3dWV0TzVpNjdiQnFBVlRGR1VwOWY0UDYrbWVt?=
 =?utf-8?B?N3kxWFUvRkwxTmtNMkg4Q3Z2YUxiSFdmeVo4L0VqbmxVdk9HV1FTcjBacmtw?=
 =?utf-8?B?K0RJSll2amtoRmUrQUI1Y29ReDh5ekJsUWJwRldMMUJ3MXFBR0FSSzlBb0RH?=
 =?utf-8?B?MDVnTmE1R25iZUJFZDhFL2xJcC9BPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e827141e-6ee4-4b3c-d311-08da94cdf74b
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 14:49:16.7619
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +nClG8n4IoK9lfUhfgx0RdX1x7PXHw4Nf4h9m2LLHeP1gHQ6FuSQUviUSBRIirwNIGcBJvgJaBZF1Q1lA2ULvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6322
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/09/2022 14:23, Prathamesh Shete wrote:
> Create new SoC data structure for T23x platforms.

Always helpful to say why we need to add new SoC data. Ie. what is 
different?

> Signed-off-by: Aniruddha Tvs Rao <anrao@nvidia.com>
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> ---
>   drivers/mmc/host/sdhci-tegra.c | 17 ++++++++++++++++-
>   1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 2d2d8260c681..136c045d8f01 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -1525,7 +1525,8 @@ static const struct sdhci_pltfm_data sdhci_tegra186_pdata = {
>   		  SDHCI_QUIRK_NO_HISPD_BIT |
>   		  SDHCI_QUIRK_BROKEN_ADMA_ZEROLEN_DESC |
>   		  SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN,
> -	.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,
> +	.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN |
> +		   SDHCI_QUIRK2_ISSUE_CMD_DAT_RESET_TOGETHER,
>   	.ops  = &tegra186_sdhci_ops,
>   };
>   
> @@ -1556,7 +1557,21 @@ static const struct sdhci_tegra_soc_data soc_data_tegra194 = {
>   	.max_tap_delay = 139,
>   };
>   
> +static const struct sdhci_tegra_soc_data soc_data_tegra234 = {
> +	.pdata = &sdhci_tegra186_pdata,
> +	.dma_mask = DMA_BIT_MASK(39),
> +	.nvquirks = NVQUIRK_NEEDS_PAD_CONTROL |
> +		    NVQUIRK_HAS_PADCALIB |
> +		    NVQUIRK_DIS_CARD_CLK_CONFIG_TAP |
> +		    NVQUIRK_ENABLE_SDR50 |
> +		    NVQUIRK_ENABLE_SDR104 |
> +		    NVQUIRK_HAS_TMCLK,
> +	.min_tap_delay = 95,
> +	.max_tap_delay = 111,
> +};
> +
>   static const struct of_device_id sdhci_tegra_dt_match[] = {
> +	{ .compatible = "nvidia,tegra234-sdhci", .data = &soc_data_tegra234 },
>   	{ .compatible = "nvidia,tegra194-sdhci", .data = &soc_data_tegra194 },
>   	{ .compatible = "nvidia,tegra186-sdhci", .data = &soc_data_tegra186 },
>   	{ .compatible = "nvidia,tegra210-sdhci", .data = &soc_data_tegra210 },

-- 
nvpublic