Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ce358ac4-a473-158c-ccce-c50af813fb6d@intel.com>
Date:   Mon, 12 Sep 2022 07:31:13 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.2
Subject: Re: [PATCH] x86/intel: Clear SGX bit if both SGX driver and KVM SGX
 are not enabled
To:     Jarkko Sakkinen <jarkko@kernel.org>,
        Kai Huang <kai.huang@intel.com>
CC:     <linux-sgx@vger.kernel.org>, <dave.hansen@linux.intel.com>,
        <seanjc@google.com>, <linux-kernel@vger.kernel.org>
References: <20220909080853.547058-1-kai.huang@intel.com>
 <Yx8OTDwhqbgvGp4p@kernel.org>
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <Yx8OTDwhqbgvGp4p@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkdyUUtwV2ZJa21hVUJzaVAyTFp2WXlSKzdBNU5QZUd4c000TTZjZjNMUTgv?=
 =?utf-8?B?ZDhGb1I4UUtVeTQ4VVFZUnREL2hvUXRzTmNLanJYbGRGd2V1YXpXM2JSUU00?=
 =?utf-8?B?MTRjUVJXc3V0RlE1QXdzT29oVE9RdnhaOWM0RGdGdTl0M2FkUkpoc20rV2FX?=
 =?utf-8?B?MXNraGJFbDJNWnV1K1l3bENtMHNwb2dOUDBuVWg4QVl1d1dBcVpJc1dRVFpa?=
 =?utf-8?B?MnFtdHZxUERjaXBBWC8zRzhFUUQveE1IUDd2NGNOU0JHSjg1SCtacDJEOWh4?=
 =?utf-8?B?bEpUWFB3Ky9oY1h6ejd2eHlLNnJUTVVhV0lTYnd3OERkdzBZMDdQREpWWjhY?=
 =?utf-8?B?dE00NUQwci9FZ3R6KzFvUGVJeFZ6ZmU0bUJkQkJzZmtCaldDek5WWnQxY1pr?=
 =?utf-8?B?VmMyRlN1QitNNk5HZ1Q4dWo1ako2aHd1OVMrYlpXb2Z3cW1BYjNXdVphMEFK?=
 =?utf-8?B?dTl5VmhsRDlpc2p5MzJHQk4rbEdWd0ZCc3Rra1ExMGIvdnk4dHJlNEl4bGdJ?=
 =?utf-8?B?UmRQQ0pTeWY2dmpDR29rLzRtbnFEaG1QOTJuc3AvY3g4SU9McUhBUnlXZHl5?=
 =?utf-8?B?aWxtbVVIeFdNLzh4RmhieGlsMVBFa0Z1WVVQRThWS20xMlY4Z2dFaVBxRTM1?=
 =?utf-8?B?TTdCbTB3cDArNk5BQlRLTEdvSk5WNXY1M3NIT2Y3VDA4dWZyZHFRT3puMFZF?=
 =?utf-8?B?aFNVazhjTzlTTy9DdURDYVZDVzB1b2VTbmQ3NjVtaGRnNjVJRWZDOEdRcXpr?=
 =?utf-8?B?MkdDUTduMVBpaG1DVkVFTGdMcnJ2WGp3dmZqMHQybEdUOEFYK3Fjc1g5am5P?=
 =?utf-8?B?TFhMNFl5NEZzWnNmZFY0SjFsU3VyekliSzV4cGNJMGpaVnpVQ29oNEZvVlRG?=
 =?utf-8?B?OHhuM3lHc3V5MDZWT1EyRkRoQUJiT1Z0ODR3ZHZSQU5namFrT3U5VHBFamtv?=
 =?utf-8?B?MVBiN2gya0RLaUlocmdyUGFmNktXenN5K2Y0YTBaZFk1bTdlOXMrQmMwNjV6?=
 =?utf-8?B?UE1Kb0VwdG5zMlpLZGcxaDhrMmNtTTNCZXNNRjA3V1M2TzRsQkp1NXpDdzJ3?=
 =?utf-8?B?em13OFRkM1lRVUszaUdUMUQrU3BLdGVlK1d5eXV6VGlCYktJNGVYV1RKeUlI?=
 =?utf-8?B?RFN5RzFYYXliYnhLMVJ1MUdQY2R6RDVaOG5wSnZiS0xLcFRueGVwY3Y3bXcw?=
 =?utf-8?B?MDhwMk5WcGZ1WDN6eEZxRTJBeS8vY09mMnBLTkdVWWJrZnB6TG90Z05HY0J1?=
 =?utf-8?B?blNGR2JEVTVqMWFHY0lxcWo3UFJ4OUJVVCtDQ0tYUVgxam1LS3NGVFZoMWpm?=
 =?utf-8?B?WEh6Q3NZa0tNb2kvbjNEOEgvaXlsTXlsMndndVA5ZVEvalNXUnpTY3BUNEZl?=
 =?utf-8?B?VXMyWVo1aE1BQ3BoWUhMZ0I5VHE1WGNkNCt3KzJRSWQ2MHlJbCtydnhsRnRZ?=
 =?utf-8?B?MkZnakJKM0NtcS8wbEVoYzI3bUwzelY3WEdYdDVGOGxXODBKY2xmenVLZ2dI?=
 =?utf-8?B?WDExMCtIMmtNZSsvOWR0WlF2akRNMzYxL3VjWC9hRVlseDNwQnpHWlRjUlpN?=
 =?utf-8?B?SDdsRmIzQk1BNWFMa2ZNR1B4TllDcE5XNnV5eFRnZTJwdlNFSGV4QmN3STli?=
 =?utf-8?B?Z2RWa3lZejJpaFdmNCs3TUJJbzFidVNicXA0TEkzWEw3Mk16M1RoTEpSM28v?=
 =?utf-8?B?YVIxQy9ZUVlIVHR4MXBCQ1hSbWN4eG4yaFlJbEdYTVJ5R2dKZ2xlNWNTZ0RO?=
 =?utf-8?B?aWJFdmR4RjlFM2szYk9aRjBBK1A3YTdrbWoraGVId0o0RSt1OW1uQzRxNnFM?=
 =?utf-8?B?VmFXaGU2TERwVzE5dzltWU1Xdi8yWlYxT1B1ektzNVRiQVIvVVJYTlA5NnIv?=
 =?utf-8?B?M2ZBZjhEUkI1bHFORlBXTmludjRVcVM3K0s1cktybWgxQXc0YUFBMGpORmdV?=
 =?utf-8?B?c3NiTFRGR1lDUURSaVdxN2dWTjZ0OTZOQ2h2bEYwdUM0ZGdSM2ZsRHRlMkV0?=
 =?utf-8?B?dWxLMEQ1R3ZDSzNFeitldHRONUtZdVdTbDVEc3R2eDBGQzNsNlM3Ukc0dFdw?=
 =?utf-8?B?cWtCVTllcUpma3hLeHFuSFJjNTFvT1NpazFjcnVVSytWT1dmeG0xa1NsVDZp?=
 =?utf-8?B?bVhUdnc5aDRhR29GTEhEeWRjSWxMMlJWd0pBc1gzQmF0VEN1eHNGTU83bzFx?=
 =?utf-8?B?c2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 98405c45-322b-4709-800c-08da94cb72be
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 14:31:15.2268
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dc3fLJjbyhSdJmG7rk0imTPq+z1fRflV+CEBw0jwlgMDD3X0JGE6a+eIR13/hgkixEA2JsW2d0siMqey0NzMaaublsve9Qn+E5lfNJsx2vc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5687
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 9/12/2022 3:47 AM, Jarkko Sakkinen wrote:
> On Fri, Sep 09, 2022 at 08:08:53PM +1200, Kai Huang wrote:
>> Currently on platform which has SGX enabled, if CONFIG_X86_SGX is not
>> enabled, the X86_FEATURE_SGX is not cleared, resulting in /proc/cpuinfo
>> shows "sgx" feature.  This is not desired.
>>
>> Clear SGX feature bit if both SGX driver and KVM SGX are not enabled in
>> init_ia32_feat_ctl().
>>
>> Signed-off-by: Kai Huang <kai.huang@intel.com>
> 
> Is it a pattern that flags are cleared when they are disabled by the
> kernel? I don't know the answer for this.

There appears to be relevant text in Documentation/x86/cpuinfo.rst:

tl;dr "In general, /proc/cpuinfo shows features which the kernel supports."

Longer quote:
"If users want to know if a feature is available on a given system, they
try to find the flag in /proc/cpuinfo. If a given flag is present, it
means that the kernel supports it and is currently making it available.
If such flag represents a hardware feature, it also means that the
hardware supports it.

If the expected flag does not appear in /proc/cpuinfo, things are murkier.
Users need to find out the reason why the flag is missing and find the way
how to enable it, which is not always easy. There are several factors that
can explain missing flags: the expected feature failed to enable, the feature
is missing in hardware, platform firmware did not enable it, the feature is
disabled at build or run time, an old kernel is in use, or the kernel does
not support the feature and thus has not enabled it. In general, /proc/cpuinfo
shows features which the kernel supports. For a full list of CPUID flags
which the CPU supports, use tools/arch/x86/kcpuid."


> 
> I could imagine that sometimes you might want to know whether the CPU
> supports a feature, even if e.g. your distribution kernel does not.

Indeed ... this seems to fall into the "murkier" part of the above quote.

Reinette