Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp5401184rwn; Mon, 12 Sep 2022 08:31:10 -0700 (PDT) X-Google-Smtp-Source: AA6agR46dOv7kQADyPrP7Dkzl5GhXlsbP/RoX3k8Avion841drXnYdmkS0n+dj7YyHp3f7tdFsAN X-Received: by 2002:aa7:8096:0:b0:52d:d5f6:2ea6 with SMTP id v22-20020aa78096000000b0052dd5f62ea6mr28811323pff.0.1662996670615; Mon, 12 Sep 2022 08:31:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662996670; cv=none; d=google.com; s=arc-20160816; b=Xz1YY5gDA2r/v8JuAbsWed0PDdc26ymYTgVm1lZIkl9FzjGG5Mz7nvg1gsRfqEDvYB U+LR4GC+P9mNSKZ6b3LakuxTAztI/J0P2O++wPQOreub1ujPlVd1sxz1ZGq9rpret2PF b8L2JNx4rw9mEZCuwbUJVsTNZXbacUy8ul6kbpqvmOLzfo/2t83l3JQPxzclnQIFgfsW nIN3x1zZoNm0rJ24PLQDDZmdDRw5ANHV0nWCrNt4EWos1ZEwAIqVwZWB4gluMh3uLHnV nANHcKoMsEI8H2V6Cc0OlibC6ujhGZrO/p69hvH7zVd03nTjDfalLLbtDvQPWB9+Xzwm rx2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zQ6noXpXGUxM0iv1KPA2l9wW4gGI9cU0yqet3pfzjGk=; b=kLeUjgYUAj0AAbp8T4ZvCOaKvRfvxCEn5jfJAnmlyZM/49v8Q43bfVBOg7pcOMrHjk 5+gg5pbvzDVPICzxm2CGYbAM5CrU7MDZ/9si0u94jCyiYakK9A8IHqkvz6LicD7RPKxK FtEABoQ2VQAbwnewuqFdFkR9mxES6/ty6qUeAxVS2QL9jq3483gIYrek9c41oFmUN54m i8PYgkvE/vMB0rHHGIdKoPCOWr0GWTcyGtUg304F5n1FVOyFXnB7Q4HPT+7imaSsukp/ cneVyGZCEYaPvdH6syIVgIwKzpFPJO/pc3Uj68UrR2/jKQEbKTZZlU/37YGKh2dPTk0g mPug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Z20p49e/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jn17-20020a170903051100b00176e84bac4bsi9053767plb.373.2022.09.12.08.30.50; Mon, 12 Sep 2022 08:31:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Z20p49e/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230241AbiILOl1 (ORCPT + 99 others); Mon, 12 Sep 2022 10:41:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230210AbiILOlX (ORCPT ); Mon, 12 Sep 2022 10:41:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73FEF1FCF7; Mon, 12 Sep 2022 07:41:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F0B9261224; Mon, 12 Sep 2022 14:41:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15DFAC433C1; Mon, 12 Sep 2022 14:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662993681; bh=LIlb3/sVDRiailHPluUwQ0BEaWEPEWV2j5OvEnX4BQU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z20p49e/gOyYdaaXvpTh9ebRDz8SRpomkbTdwpuTeoWcY4Lh29F9pV38PlR5cqRSO DUzd+p80O5DoQCbthS5VXjG2YJADK0OSPf4+cSH121d1mBq1FixCRa8gdugzKk0DuA SpxXG4RJj08HbLRaFz32mZ8AHg0CVJJUJIZTeUwE= Date: Mon, 12 Sep 2022 16:41:45 +0200 From: Greg Kroah-Hartman To: Ionela Voinescu Cc: Catalin Marinas , Will Deacon , James Morse , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH stable-5.10] arm64: errata: add detection for AMEVCNTR01 incrementing incorrectly Message-ID: References: <20220912135226.31027-1-ionela.voinescu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220912135226.31027-1-ionela.voinescu@arm.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2022 at 02:52:26PM +0100, Ionela Voinescu wrote: > commit e89d120c4b720e232cc6a94f0fcbd59c15d41489 upstream. > > The AMU counter AMEVCNTR01 (constant counter) should increment at the same > rate as the system counter. On affected Cortex-A510 cores, AMEVCNTR01 > increments incorrectly giving a significantly higher output value. This > results in inaccurate task scheduler utilization tracking. > > Work around this problem by keeping the reference values of affected > counters to 0. This results in disabling the single user of this > counter: Frequency Invariance Engine (FIE). > This effect is the same to firmware disabling affected counters, in > which case 0 will be returned when reading the disabled counters. > > Therefore, AMU counters will not be used for frequency invariance for > affected CPUs and CPUs in the same cpufreq policy. AMUs can still be used > for frequency invariance for unaffected CPUs in the system. > > The above is achieved through adding a new erratum: ARM64_ERRATUM_2457168. > > Signed-off-by: Ionela Voinescu > Cc: Catalin Marinas > Cc: Will Deacon > Cc: James Morse > Link: https://lore.kernel.org/r/20220819103050.24211-1-ionela.voinescu@arm.com > --- > > Hi, > > This is a backport to stable 5.10.142 of the upstream commit > e89d120c4b72 arm64: errata: add detection for AMEVCNTR01 incrementing incorrectly > > This is sent separately as there were conflicts that needed resolving > when applying the mainline patch. Compared to the upstream version this > no longer handles the FFH usecase, as FFH support is not present in 5.10. > Therefore the commit message and Kconfig description are modified to > only describe the effect on FIE caused by this erratum. Both backports now queued up, thanks. greg k-h