Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 12 Sep 2022 09:04:06 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     "Russell King (Oracle)" <linux@armlinux.org.uk>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Lee Jones <lee@kernel.org>
Subject: Re: [RFC v1 net-next 6/8] net: dsa: felix: populate mac_capabilities
 for all ports
Message-ID: <Yx9YdlrsLsBNPJzL@colin-ia-desktop>
References: <20220911200244.549029-1-colin.foster@in-advantage.com>
 <20220911200244.549029-7-colin.foster@in-advantage.com>
 <Yx7yZESuK6Jh0Q8X@shell.armlinux.org.uk>
 <20220912101621.ttnsxmjmaor2cd7d@skbuf>
 <Yx9Uo9RiI7bRZvLC@colin-ia-desktop>
 <20220912155234.ds73xpn5ijjq3iif@skbuf>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220912155234.ds73xpn5ijjq3iif@skbuf>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QqNMICxe+ntKrZmJD5E97lLtM2Pp8025jxOq94O/1bX63AiFhJkzU8BF0TPS?=
 =?us-ascii?Q?sGkrAi04AUhCIxHzhy5xECWRP7HUjT87d36j2PkRd4/AMwPqcr/qB5RKEXrQ?=
 =?us-ascii?Q?vm5FSCp+nOH95ajPgU/WTawh5Spi9GpD5GZGJkyhF258uUZo8jaeF6LeVVMy?=
 =?us-ascii?Q?X6i8OKwvStXikztrbM+OdIZx7SX9A8NEUzIeiva1fnYNxgzrSu78r0U9LFgo?=
 =?us-ascii?Q?NAea5Otqony7Drn/SN+cAZNRfIVsoBFYpMuyqGBvaA/mU0tn3XqCsoxqsEjr?=
 =?us-ascii?Q?m+5/xBJ/fjJsofLvZGMFmDmd5VJrWp3UW746SNYQK1m9Y6USHxDuo8qdXsWB?=
 =?us-ascii?Q?JCNqoiDC5mOe1VudnEPz0osSTGGBnTR6O7YUEF4CA/K+0iPym30esxYpVm07?=
 =?us-ascii?Q?Q+8ay8zsKkTbMXCt4RZ+vFxtnRBCzjGqKRzHGhuvUGb2sLAL+j8aF/vm8+kA?=
 =?us-ascii?Q?281CWdZjuclaeOuwJxvmn994lmpU/Cj8npmlOiE4F3vSIvadl+3mL1hUy7iI?=
 =?us-ascii?Q?Hf1oVKfIMPy/fMuncbVjYDyYR4rC23BaVGcAfWdBQyzwzbyyk9GTT8029L1e?=
 =?us-ascii?Q?elqPBzRwBBckxJ+Ji3cx0udBoMcrNKOhMQAGnzTnJoVTEhYWBnMuimpSAFRf?=
 =?us-ascii?Q?akhjtTXgswcc/oTJOVeWQ9vJaJqeRqmd4+X8DgK9C/W20KFFSftylw4mjuQl?=
 =?us-ascii?Q?/nyD63tP+iJhRGntea2lfrlGuw0QvT8oyBWgzzzLcv+4+QiZ3TucRtzvyBrL?=
 =?us-ascii?Q?QhvewU7kdWM3SXhXLZThi9ZSaIWUG7fKp+Enlay7vyuW+/Px2RDyLcElSPOP?=
 =?us-ascii?Q?pGnsVMr6QuxZBUf6JwjE36oL762HSAhbn8C6wYNy8DrXBvFAWR7w7Sc0w2NA?=
 =?us-ascii?Q?HdlAjDLnJ6pQejVj8n+z745gJs3C9Is6IJ9QUE1GLQTMwHoxO7WXfciJ7DR1?=
 =?us-ascii?Q?GKJd9y6rkIqF5X9nlLm87e/+QjquCBTOrUDJlMAiNOLksSnfuLLCrZ0gktke?=
 =?us-ascii?Q?g2cut7leibaDxyzHQUCOfTJ3IHiAVLHlLyBADWL9wtui1r2chQHu0NshhABR?=
 =?us-ascii?Q?WEMQvNwfgYXR6r3c3q7ZyBN0PeC3EVfFK5drkO6vmSiGuo0CZy0dXgB5I/+F?=
 =?us-ascii?Q?QXupFGf3r1EjBmuQbBM305uPyaznxIOceQaDDDyv6Kc2IWdpjAKsqPPHxmRZ?=
 =?us-ascii?Q?GAkg5vQK8ST7pFtG0RHAsKLTJNlgvgn2dPAYDzWEApktxmqMDdtI+iaEKGjA?=
 =?us-ascii?Q?refW46dDDV9qwO1ASKoEDz13GiOmBYPEVJgS05NBoa7xFfZslVHWD/gCO0Ht?=
 =?us-ascii?Q?FX2xt4ThxAJ8Glb7bqSDH2PMwaLjOzwpu+1/YvIvDwc7OKV5N6m0MCqMUhhD?=
 =?us-ascii?Q?IcYKdXY9GM2EsP7OREzgGkL/owp23MZCYZZj1INIuyOD5Z1gXf9KNA9MHqCR?=
 =?us-ascii?Q?tR/i8hYSzJZnkWLqtFjeIe0DJ1K8TCXdHVKmE6sZl2WF0gl67F0ZUnjIDh/x?=
 =?us-ascii?Q?yVkn6IDWd0j9RM85jTZnRNh3TXqTPVYZKFz27wlDXLX4MVnnAa7wZfCGaCVr?=
 =?us-ascii?Q?0TM8oTcslxyJEns/1DYElF52stYJcd6lS94Gdkt68mLroo2S/+ffbhxe46iO?=
 =?us-ascii?Q?Tg=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62f11276-aa51-4e21-812e-08da94d86e82
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 16:04:11.7052
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DvZI57TIbt3V7Ml9CcWvm0IKvULVPmbNFQQIAcRBLipWlFWr/RH8okvPbh4pg/paQSV49y7SwcRpOYhpSX8p//s1JIFhoenwV6wQnjFelhQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5068
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 12, 2022 at 03:52:35PM +0000, Vladimir Oltean wrote:
> On Mon, Sep 12, 2022 at 08:47:47AM -0700, Colin Foster wrote:
> > > This is true. I am also a bit surprised at Colin's choices to
> > > (a) not ask the netdev maintainers to pull into net-next the immutable
> > >     branch that Lee provided here:
> > >     https://lore.kernel.org/lkml/YxrjyHcceLOFlT%2Fc@google.com/
> > >     and instead send some patches for review which are difficult to
> > >     apply directly to any tree
> > 
> > As mentioned in the cover letter, I don't expect this to necessarily be
> > ready by the next merge window. But seemingly I misjudged whether
> > merging the net-next and Lee's tree would be more tedious for the netdev
> > maintainers than looking at the RFC for reviewers. I'm trying to create
> > as little hassle for people as I can. Apologies.
> 
> What is it exactly that is keeping this patch set from being ready for 6.1?
> There's still time...
> 
> It mostly looks ok to me, I'm in the process of reviewing it. You
> mentioned documentation in the cover letter; I suppose you're talking
> about dt-schema? If so, I just started off by converting ocelot.txt to
> mscc,ocelot.yaml, since I know that the conversion process is typically
> a bit daunting to even start.
> https://patchwork.kernel.org/project/netdevbpf/patch/20220912153702.246206-1-vladimir.oltean@nxp.com/

Yes - checkpatch correclty gave warnings about mscc,vsc7512-ext-switch being
undocumented. Thanks for that patch - I just saw it! I'll wait for your
review before I get optimistic. But if it boils down to separating the
last patch (per Lee's suggestion) and adding the dt-bindings, maybe it
could be ready in another round or two.