Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <17db01f1-0e53-fd25-d5ca-622003ddd42c@schaufler-ca.com>
Date:   Mon, 12 Sep 2022 10:00:43 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH -next] smack: cleanup obsolete mount option flags
Content-Language: en-US
To:     Xiu Jianfeng <xiujianfeng@huawei.com>, paul@paul-moore.com,
        jmorris@namei.org, serge@hallyn.com
Cc:     linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, casey@schaufler-ca.com
References: <20220908103543.194119-1-xiujianfeng@huawei.com>
From:   Casey Schaufler <casey@schaufler-ca.com>
In-Reply-To: <20220908103543.194119-1-xiujianfeng@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/8/2022 3:35 AM, Xiu Jianfeng wrote:
> These mount option flags are obsolete since commit 12085b14a444 ("smack:
> switch to private smack_mnt_opts"), remove them.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Added to https://github.com/cschaufler/smack-next#next.
Thank you.

> ---
>  security/smack/smack.h | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/security/smack/smack.h b/security/smack/smack.h
> index fc837dcebf96..e2239be7bd60 100644
> --- a/security/smack/smack.h
> +++ b/security/smack/smack.h
> @@ -180,15 +180,6 @@ struct smack_known_list_elem {
>  	struct smack_known	*smk_label;
>  };
>  
> -/* Super block security struct flags for mount options */
> -#define FSDEFAULT_MNT	0x01
> -#define FSFLOOR_MNT	0x02
> -#define FSHAT_MNT	0x04
> -#define FSROOT_MNT	0x08
> -#define FSTRANS_MNT	0x10
> -
> -#define NUM_SMK_MNT_OPTS	5
> -
>  enum {
>  	Opt_error = -1,
>  	Opt_fsdefault = 0,