Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        George McCollister <george.mccollister@gmail.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Woojung Huh <woojung.huh@microchip.com>,
        UNGLinuxDriver@microchip.com,
        Linus Walleij <linus.walleij@linaro.org>,
        =?UTF-8?q?Alvin=20=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= <clement.leger@bootlin.com>,
        =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= <arinc.unal@arinc9.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Marek Vasut <marex@denx.de>, John Crispin <john@phrozen.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        linux-renesas-soc@vger.kernel.org
Subject: [PATCH net-next 1/3] dt-bindings: net: dsa: mt7530: replace label = "cpu" with proper checks
Date:   Mon, 12 Sep 2022 20:50:56 +0300
Message-Id: <20220912175058.280386-2-vladimir.oltean@nxp.com>
In-Reply-To: <20220912175058.280386-1-vladimir.oltean@nxp.com>
References: <20220912175058.280386-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zAqTpSxPMRo1yG3x0ck0zaPPv4/HT8X70f6UK6Wv2ZhOEQL0AXM5EC//2Lvs?=
 =?us-ascii?Q?7xYYst97iN2zUw5LsGP1y3jiTptXN6MZd7CPiGO1OBQm8OZN1lGMcPvuthuM?=
 =?us-ascii?Q?3qzB2qTGt63uPI5JruLkL712HHzEcyOOrSnUsf+Z5ESwqp4koeqpMwETdhwe?=
 =?us-ascii?Q?fy9dEMcvsBy6GrZot7Z5OB/cY44eOKjp23QBGA6B95Tw2YRgbOUej1LY5HXX?=
 =?us-ascii?Q?P3wVci+Az4b+qAVlIrwxFbePXixZ/rRfZly36P4OyDDlLwCKIJjkopPD/WTN?=
 =?us-ascii?Q?JBoUGbesRA/m6zj/umTDx6JQ+TrPYFxg4L3me4O0SK21MHpqyDsVsL6ylEw+?=
 =?us-ascii?Q?Xwu1VSJmQeshubE/G/pvqjvw2Lsx+Fce7AoE1otjekG2bI87sO3coffcVlRg?=
 =?us-ascii?Q?4mt4AmvjuhqWJ9MURFfn/euf4NUzYkLduhwOJbhkSfgHJrpv/nhiDlGGbeS1?=
 =?us-ascii?Q?2DW5aJiMBd8yjL8+zrviHovG9yilWQV1kcuap5ezKFH3NaRWXgNCgAabJ7q5?=
 =?us-ascii?Q?Pu8ObOwC1Hyk+OrtO2J0NSXG5zWl+uQYDsvy9a+FKg6OOyUwDjdm5tSrt/RA?=
 =?us-ascii?Q?EnBdtseX+GNohJ/rEQklW2WB38UojCQdFaRPPyjhwkSOTdbdupAnzfNS8aOP?=
 =?us-ascii?Q?dfbo8LBpiJYP1Md+XL4wQyWHXRx4bj/ctLnw9fbAUIJFrNxZi+px/I6I3eur?=
 =?us-ascii?Q?3Rs267dQQmjOqi0KqQRkLLmseu2Hf30lOICSs8xfEPSKrSbgOjtGL7OWvnar?=
 =?us-ascii?Q?yt/KtsipfpSVBBD2lU/zPyFK3lDrUI5bXx/0Pb/5XkWifX174mxf8dgzEg0R?=
 =?us-ascii?Q?PvHqnAtVDyXsXoheGvX+CR/dBC8977hNalYpZIB+7QtiEr9veBNg7iDxYAC4?=
 =?us-ascii?Q?rYDz/IcZcJ9rLFr85OhzYZX10aK/fTMlqoODfVW4BomIBfs6wd2QYYTkZEph?=
 =?us-ascii?Q?TyujS12QXaKJzHi84zfPfTynLejQqLJJCtvYtkoqF6EFqQBE83Mw+JiH74cD?=
 =?us-ascii?Q?oMHb+vTE74KjVhd+fCC/DgUB3INvhvpfy6KElWjJrsWdF/4/lgkgKwaOroH7?=
 =?us-ascii?Q?4IMWiYjZx+fjM2kVJLbsDRciMjpqUELA/IfoSgCoshqAw0hAllRN65uOw1R1?=
 =?us-ascii?Q?uRMAzC5eE5rtNd6jFRFIOwD1eKPNrH139hgUgj56EUyRO4fjxSQl5G06r2ZM?=
 =?us-ascii?Q?2yF/jIikjkUMrfcR/Xp3dplv4uYUM2i9eAyDJ+8fcPRZHqE9RA0pPsGrqkoZ?=
 =?us-ascii?Q?aM0RGjLa8eHQyMtiueNccpY0L0anAmutV3WG3RI90EHdlEFm6Fd5GqrhEWGM?=
 =?us-ascii?Q?wk6fcRtsD67JbaKOWIpStuxDboPKYpPr8OWbPg3EQiGuluUUS0PH9RXLbHiF?=
 =?us-ascii?Q?KYArM8cnycD9iPiNElzLCcaR0jImEkCDVdh5cUWO537+RA7JA8ybb7DCAS0h?=
 =?us-ascii?Q?vC1lzN/9WvjP9NiqyOSh7BXpvgPggQ92PIQsW7dDeMdCo5IBuZ2rjlXO87er?=
 =?us-ascii?Q?xxc/hAtta4ixamlMbml4mPBAecu6faB+Mwi4K2BN5bf8YbeD5/6rgim0nMD0?=
 =?us-ascii?Q?0xIBoB3NyQ58EGr+mcTl54qu3Pah4KcJmnAtNlouoNEdL85wO6n7zkaHb4Xz?=
 =?us-ascii?Q?ZA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c878e44a-54aa-4826-5bc8-08da94e76214
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 17:51:13.2235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Cz5MEJCU7YukC5kR7jfC1hMV3M431mvhFeMj8iGW0pa3IOPLlpWFjTW0uQyn2kIeHKPJA+yxxWAT8qqhWfdtVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8687
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The fact that some DSA device trees use 'label = "cpu"' for the CPU port
is nothing but blind cargo cult copying. The 'label' property was never
part of the DSA DT bindings for anything except the user ports, where it
provided a hint as to what name the created netdevs should use.

DSA does use the "cpu" port label to identify a CPU port in dsa_port_parse(),
but this is only for non-OF code paths (platform data).

The proper way to identify a CPU port is to look at whether the
'ethernet' phandle is present.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
index f9e7b6e20b35..fa271ee16b5e 100644
--- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
@@ -163,9 +163,7 @@ patternProperties:
         allOf:
           - $ref: dsa-port.yaml#
           - if:
-              properties:
-                label:
-                  const: cpu
+              required: [ ethernet ]
             then:
               required:
                 - phy-mode
@@ -187,9 +185,7 @@ $defs:
         patternProperties:
           "^(ethernet-)?port@[0-9]+$":
             if:
-              properties:
-                label:
-                  const: cpu
+              required: [ ethernet ]
             then:
               if:
                 properties:
@@ -215,9 +211,7 @@ $defs:
         patternProperties:
           "^(ethernet-)?port@[0-9]+$":
             if:
-              properties:
-                label:
-                  const: cpu
+              required: [ ethernet ]
             then:
               if:
                 properties:
-- 
2.34.1