Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp5750245rwn; Mon, 12 Sep 2022 13:52:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR573jf23Ddjk2Wd+NV0J2xhkKEgQMICg+V7djBpbIligJVXCxMelDTrR7xC4i2prbThOxva X-Received: by 2002:a17:906:9746:b0:74f:945a:5d41 with SMTP id o6-20020a170906974600b0074f945a5d41mr19781965ejy.63.1663015928953; Mon, 12 Sep 2022 13:52:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663015928; cv=none; d=google.com; s=arc-20160816; b=UfTkM/favmRr9UZ88uPnZ8sfQ7fDDVCOY47Z/1qTsX2UMHshjK30bxPpfat2mY6ECW BdPHhJJtkY5dN6gBz3c/6ffXGM+s+iTKiWnY6rP7zeapaCUC9vFfWMsSAHhiIaKAsGrU j+Fxld+3le/tw5d1FbfNp/T4bmWKLYcztUKy7AI8OxBm0t4xbT2i+zHXdQvXefVa9Is6 uNU+ZLcp2KK5ZbVqYe7n6w3rpVDUwLhQAiO5lrwI+6MEUUxDUprLBOzK9fStGmyXvpFU YCzMXSA65mLxam9KxNcglzauH2S2qib2Khbx9gYQNyCGR2bScBKajBv11s/MrNIHexkr /mQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=jVR/9nc47BR/vr6v5JXHQZhjrWw6Ts0BF9bO5+LClOA=; b=TJCnlGXG3NQJhdLnBDkHsshtoY1nIk6olmkaMV1OBMSmfp82kYqht6tWOj0a0111rX G2z5bGLL3oCWeeuNKMAEjlWd3dIhYDdz/3LEJOttz8wiDKNGfl4pF4oAIvw3U9oKp8M7 2yb4UkLZ7H3OvGKrzwyGEBOl/fIPQoVQ87gCr2vfcXeT5SwGOr54xXbgGJB3tnaagIWR w/XtU12JmgU7hKncRYeszdgIVzC19inEWlfblqxIPCY2OTsXrHgu3V0dMGbi4KdAkASF PS3JAiXpOx1ktOR1vVZSUymSY3+I3+TWfzWXisTYwCl2OPGT1u5bpXcpBBVbZHz1Sgf7 YZxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a10-20020a1709063e8a00b0073d72e1633bsi6422929ejj.908.2022.09.12.13.51.03; Mon, 12 Sep 2022 13:52:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229907AbiILUhh (ORCPT + 99 others); Mon, 12 Sep 2022 16:37:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229880AbiILUhf (ORCPT ); Mon, 12 Sep 2022 16:37:35 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1D2A54A102; Mon, 12 Sep 2022 13:37:34 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 11439106F; Mon, 12 Sep 2022 13:37:40 -0700 (PDT) Received: from mammon-tx2.austin.arm.com (mammon-tx2.austin.arm.com [10.118.28.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 72D7C3F73B; Mon, 12 Sep 2022 13:37:33 -0700 (PDT) From: Jeremy Linton To: linux-acpi@vger.kernel.org Cc: rafael@kernel.org, lenb@kernel.org, viresh.kumar@linaro.org, robert.moore@intel.com, punit.agrawal@bytedance.com, lukasz.luba@arm.com, ionela.voinescu@arm.com, pierre.gondois@arm.com, linux-kernel@vger.kernel.org, devel@acpica.org, linux-pm@vger.kernel.org, Jeremy Linton Subject: [PATCH v5 0/1] Disable FIE on machines with slow counters Date: Mon, 12 Sep 2022 15:37:21 -0500 Message-Id: <20220912203722.205185-1-jeremy.linton@arm.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org FIE assumes the delivered/relative perf registers are fast to read so it goes ahead and hits them quite frequently. On a couple of Arm platforms though they end up in PCC regions which require mailbox handshaking with other parts of the platform. This results in a lot of overhead in the cppc_fie task. As such lets runtime disable FIE if we detect it enabled on one of those platforms. Lastly, allow the user to override this decision via a module parameter. v1->v2: Apply Rafael's review comments. Move the MODULE_PARAM into the ifdef Fix compiler warning when ACPI_CPPC_LIB is disabled. v2->v3: Tristate the module param so FIE can be forced on/off Bump pr_debug to pr_info if FIE is disabled due to PCC regions Switch ACPI_CPPC_CPUFREQ_FIE off by default v3->v4: No functional change, resend due to email addr issues v4->v5: Minor whitespace, comment wording, if/case conversion Drop the ACPI_CPPC_CPUFREQ_FIE disable config change added in v3 Jeremy Linton (1): ACPI: CPPC: Disable FIE if registers in PCC regions drivers/acpi/cppc_acpi.c | 42 ++++++++++++++++++++++++++++++++++ drivers/cpufreq/cppc_cpufreq.c | 25 ++++++++++++++++---- include/acpi/cppc_acpi.h | 5 ++++ 3 files changed, 68 insertions(+), 4 deletions(-) -- 2.37.1