Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Nathan Huckleberry <nhuck@google.com>
Cc:     Dan Carpenter <error27@gmail.com>, llvm@lists.linux.dev,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ax88796c: Fix return type of ax88796c_start_xmit
Date:   Mon, 12 Sep 2022 22:19:07 +0200
In-Reply-To: <20220912194031.808425-1-nhuck@google.com> (Nathan
        Huckleberry's message of "Mon, 12 Sep 2022 12:40:30 -0700")
Message-ID: <dleftjo7vkfiro.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20220912194031.808425-1-nhuck@google.com>
        <CGME20220912201920eucas1p1ff844ab7a87a01fdb0ae98295e103147@eucas1p1.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2022-09-12 pon 12:40>, when Nathan Huckleberry wrote:
> The ndo_start_xmit field in net_device_ops is expected to be of type
> netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev=
).
>
> The mismatched return type breaks forward edge kCFI since the underlying
> function definition does not match the function hook definition.
>
> The return type of ax88796c_start_xmit should be changed from int to
> netdev_tx_t.
>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: [...]
> Cc: llvm@lists.linux.dev
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> ---
>  drivers/net/ethernet/asix/ax88796c_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: Lukasz Stelmach <l.stelmach@samsung.com>

> diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethe=
rnet/asix/ax88796c_main.c
> index 6ba5b024a7be..f1d610efd69e 100644
> --- a/drivers/net/ethernet/asix/ax88796c_main.c
> +++ b/drivers/net/ethernet/asix/ax88796c_main.c
> @@ -381,7 +381,7 @@ static int ax88796c_hard_xmit(struct ax88796c_device =
*ax_local)
>  	return 1;
>  }
>=20=20
> -static int
> +static netdev_tx_t
>  ax88796c_start_xmit(struct sk_buff *skb, struct net_device *ndev)
>  {
>  	struct ax88796c_device *ax_local =3D to_ax88796c_device(ndev);

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmMflDwACgkQsK4enJil
gBCQAgf+JuMtztJB1UODPRAMGslnlVGtuSPkAD34lYD2XiYUtEqSTnE2AvS7zRl6
ciMUiYzMP3s00YwkM7wEwuGtIf93o/MmwlbkVV2fTQYAgh4hs74SVlgE7KR44FiT
B+NCDuBWB1qnkR22d+xkmZShAFqhpHUPFoBY/hSqmz8/t2LIi7MCBh6/EAJOoqXi
BQ4W8KlBpLqRwltkph2xvQxMTCc59l59IzXEIL5RE/fRaXfS+4SRxvTnhGHGaEKI
IsBcjQ0OpfEw74CY/ysO7LFhF6rkSLp+7BeJYVwXks2jaondpKUg8fvfIwMKUYpM
ODv8Xl5+ycmFhqzYZh901v5xPpvSEw==
=8cv3
-----END PGP SIGNATURE-----
--=-=-=--