Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6445a450-d15f-be32-818a-4bb1c11ef429@intel.com>
Date:   Mon, 12 Sep 2022 15:01:21 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH] iavf: Remove useless else if
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        <jesse.brandeburg@intel.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20220909033240.46329-1-jiapeng.chong@linux.alibaba.com>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20220909033240.46329-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXBmOGI5N3ZtTWdhQ20yb0VjZWcwQ1N1VUZxK0hPc09idXNla2dRRkxFd1B2?=
 =?utf-8?B?MkRKTkJKZ3QxYVVGZy9zWnFDMWlma1N0ZElDTGRmY3NRNE1tMy9zOVhiTFd5?=
 =?utf-8?B?VWdkZW00bDQ2NTRxbUI2YzFLbEZIM2NNRlByZExvSHZJT3Zpajdqb3VMbnV5?=
 =?utf-8?B?WHRQdk9ST1N2NEE2Y0ZnanI0eWlhbVlWZGhTKy9FMzRsZEJpU0l5NzNKZ2RC?=
 =?utf-8?B?MjJrYm9GTFpSUjc3QklPVHJtY0wwa2Era1BSL2JJSG5FV3d6ZUJ5YlpQU1di?=
 =?utf-8?B?VVBFcVpMSHFjU0dUL24yVzRhOEJIOWx1d2RFSHZDUmpHdEN1TEd6MVNjNTM2?=
 =?utf-8?B?Y052bVc4RWN4cm05YWVUbnA4VGVWa0piSG8vZG9GdERlVk9KYzZ4dktFNnc1?=
 =?utf-8?B?Z3BnNmJUK0VteWZuZVFxOEF4cDNsUjhEbWFPWG00MlZvMnZUbWViRjFKaHBa?=
 =?utf-8?B?cktPek1VZnBqZlEyNFNSWlpNdTl3QTNuRE56b3d2cjF5Wm1BZXhPWnN2clFh?=
 =?utf-8?B?UExQRkFRZ3EvQU9VOFdXZlM4TENCQlVKUUdScFA1VE1zczd5MlZiM2cwMzlG?=
 =?utf-8?B?clVydzBna01tRFIwYzlkN084RElPVlNWOHY2OGRwTGZIbEdxY29CMktuSWc0?=
 =?utf-8?B?UnF2SlA1TlNiM2tId2tmU2xaZnlNcFJkUmNZOHVlb2hpNjZYMU42YVA5N0RU?=
 =?utf-8?B?Y01JQjZCdzlLY3orT3JQMkxkVTIvRDZ5RTdFK3ZmaXAwSFZhRFpmdGdUeFV2?=
 =?utf-8?B?M3dWK2ZaeTVzcm8zR1NUd09lalVzZi9Xb3I0QjVkQWUvL2N4SEpEU0Eva1B1?=
 =?utf-8?B?NE1BOVluMmlRS1JZMnZ0QURDN2VmWVZTdHQwd0p4RU5qajk5WWdTZGJWNnRX?=
 =?utf-8?B?ZW1FUHY1Y0tRai9JanJqOWI2cFQ0c0liU2JpQ1ZTM1V4RU5Zb0o0VTVhKzJG?=
 =?utf-8?B?L1g2Q1pZNGphUWZCc3Z6Ylh3N0JvS08rTnZ6U3dQeWhRRjE1eXZOeTU2dysz?=
 =?utf-8?B?NXJJN2VuQ2RRU0lBaWE1SWd5a3dZQi9iSUJrcFQ1aDRpc1g2akR6WjRNazdy?=
 =?utf-8?B?UXc4bWdsdWJNZDZVMFoxYlVVL0lYeklhWFZLK1BtcGpybGtWNWg2SW5vV2dS?=
 =?utf-8?B?VGxkN2EyNzVWUVplS2Y2T0lNRTdpRXZwdWpWMEE0M2JiVmNlMWFmWEhPNFlH?=
 =?utf-8?B?cGdHMnFJQ3pkU1dhU1ljUHRBMG1PTG4wMmpDTlNlRVFxSDJCaCtIY1JPWHdS?=
 =?utf-8?B?OVlzMjZEczVmVHlVNDhLRzNBWWVxQlFUbXZOSElKNWEwREpsQVdLK2dpRmFW?=
 =?utf-8?B?N3pEMHloRVB2bElaUk9QM3BORUlCV3dJRUU4aVV2enZ4KzVjMGY4ZFFBTDZp?=
 =?utf-8?B?eWZ4OEpHQUFLYjFtbWtvbkZ2TUdrWmZQckptdjRpdE9vdUdJYzhYQ08zbnRq?=
 =?utf-8?B?SW92d3lHQ25yL1RzUUQ2NllSUXd3bzFocGNhYWpHRzRoeHRTbjlWSVdKTk5a?=
 =?utf-8?B?aVJUTEFzVVlTSUwybERHTE5xMlI3SGxFdm16UWtjaWVSZ2gxMEhRbzdsZ0hI?=
 =?utf-8?B?cjB4azhFMDVEREc0STdqdW9xd25VL0FIdXRwRmtOTjMzZTBqUGtEYlJzT3JG?=
 =?utf-8?B?M1NEbkNtWVp0OU1WTmFDUmNIOGxNdWxoakZndWorZW9TZ1lTejJ4VU5aaDIw?=
 =?utf-8?B?MzlyNUxaeWZaNTdZWTFiZTFHQ3B3R1ZXc29aYm1oZDFWNnM3RC9mVkhwV2Jk?=
 =?utf-8?B?YUVibWJieTQvODdDMFBhVWd0SXp1U2FsK0dScTFFUjFncm9vYWE3bFVSUjBD?=
 =?utf-8?B?OWpHa3JkTzE2bFBoL0lzc1E1Z290VTVhSTVrYmVZejBhZXlDSGFSYVAzRHFh?=
 =?utf-8?B?ZG5WdzAwMjZla1NhLzZPTDFPQkxvbzV1QnoveU9FeFJxam91WXhjMFZZQzJQ?=
 =?utf-8?B?Y3RXZzIvZVcvbWhJOVRQNXdQb2VvazZ5WDdjS0ZmZ1IyUTFUK0xoait6aVpO?=
 =?utf-8?B?azA5UlJuUjhDM2c3UFZFMlZOUks0b3N0eGVHZkQ1VEw3cEI5bm9vUnBRU1VJ?=
 =?utf-8?B?V3ROQVFHSEJrRjlKZjUvUU1OS2IzVmx0cDVCditFdUtZaTVrQllQZnpZOGxz?=
 =?utf-8?B?MXRnM2lwWDNzSE0wQU1uQ215TUlsV2syNi9YbUtNNmVFQXhrNjdrd05UNzBI?=
 =?utf-8?B?cFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b72eeaba-d943-4da3-d903-08da950a557e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 22:01:24.4653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I6HshiyU+Q3GVrCsT31JDeboV6Lf+vkxS1dK1obW/HHaJgJPldGHCHsOC/fe06FgpZQXiV3TN6fJjfKrtAlX2sYWNSABaCe9WevrSCPvgxI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5261
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/8/2022 8:32 PM, Jiapeng Chong wrote:
> The assignment of the else and else if branches is the same, so the else
> if here is redundant, so we remove it and add a comment to make the code
> here readable.
> 
> ./drivers/net/ethernet/intel/iavf/iavf_main.c:2211:6-8: WARNING: possible condition with no effect (if == else).

This was already nacked by Jakub [1].

Thanks,
Tony

> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2106
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

[1] https://lore.kernel.org/netdev/20220801091355.6ca23bcf@kernel.org/