Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Mon, 12 Sep 2022 12:18:18 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Vincent Guittot <vincent.guittot@linaro.org>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
        mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org, parth@linux.ibm.com,
        qais.yousef@arm.com, chris.hyser@oracle.com,
        valentin.schneider@arm.com, patrick.bellasi@matbug.net,
        David.Laight@aculab.com, pjt@google.com, pavel@ucw.cz,
        qperret@google.com, tim.c.chen@linux.intel.com, joshdon@google.com
Subject: Re: [PATCH v3 6/8] sched/fair: Add sched group latency support
Message-ID: <Yx+wKhhk5niBZMNO@slm.duckdns.org>
References: <20220909130309.25458-1-vincent.guittot@linaro.org>
 <20220909130309.25458-7-vincent.guittot@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220909130309.25458-7-vincent.guittot@linaro.org>
Precedence: bulk

Hello,

On Fri, Sep 09, 2022 at 03:03:07PM +0200, Vincent Guittot wrote:
> +	{
> +		.name = "latency",
> +		.read_s64 = cpu_latency_read_s64,
> +		.write_s64 = cpu_latency_write_s64,
> +	},

You're still using the nice value here, right? If so, can you please use the
filename "latency.nice" so that it's consistent with "weight.nice"?

Thanks.

-- 
tejun