Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220828120153.1512508-1-axel.lin@ingics.com> <f8a92b6d-ad23-24e7-2a01-73839e57cb85@baylibre.com>
In-Reply-To: <f8a92b6d-ad23-24e7-2a01-73839e57cb85@baylibre.com>
From:   Axel Lin <axel.lin@ingics.com>
Date:   Tue, 13 Sep 2022 07:48:44 +0800
Message-ID: <CAFRkauDKUGRracu2ofc=q-UTjWaeef5GfevT6kHnP=MWo__BGw@mail.gmail.com>
Subject: Re: [RFT] [PATCH] regulator: tps65219: Fix .bypass_val_on setting
To:     jerome Neanne <jneanne@baylibre.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Tony Lindgren <tony@atomide.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

jerome Neanne <jneanne@baylibre.com> =E6=96=BC 2022=E5=B9=B49=E6=9C=8812=E6=
=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=885:49=E5=AF=AB=E9=81=93=EF=BC=9A
>
> Hi Axel,
>
> On 28/08/2022 14:01, Axel Lin wrote:
> > The .bypass_val_on setting does not match the .bypass_mask setting, so =
the
> > .bypass_mask bit will never get set.  Fix it by removing .bypass_val_on
> > setting, the regulator_set_bypass_regmap and regulator_get_bypass_regma=
p
> > helpers will use rdev->desc->bypass_mask as val_on if the val_on is 0.
> I think this will result in exact same behavior. val would be assigned
> to 1 when enable is set and 0 otherwise. Anyway you are right this line
> is useless.

Setting .bypass_val_on=3D1 won't set TPS65219_LDOS_BYP_CONFIG_MASK bit.
The TPS65219_LDOS_BYP_CONFIG_MASK is BIT(6), so you need to set BIT(6)
instead of 1 for .bypass_val_on.
Remove .bypass_val_on setting then it will use .bypass_mask as
.bypass_val_on setting.

Regards,
Axel