Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Sep 2022 10:25:07 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Chuck Lever <chuck.lever@oracle.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        NeilBrown <neilb@suse.de>
Subject: linux-next: manual merge of the nfsd tree with the cel-fixes tree
Message-ID: <20220913102507.3295ce32@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/x71jjIHH/OQo31x58HL2qMX";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/x71jjIHH/OQo31x58HL2qMX
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

Today's linux-next merge of the nfsd tree got a conflict in:

  fs/nfsd/vfs.c

between commit:

  00801cd92d91 ("NFSD: fix regression with setting ACLs.")

from the cel-fixes tree and commit:

  e9de96c3df55 ("NFSD: Refactor nfsd_setattr()")

from the nfsd tree.

I fixed it up (I think - see below) and can carry the fix as
necessary. This is now fixed as far as linux-next is concerned, but any
non trivial conflicts should be mentioned to your upstream maintainer
when your tree is submitted for merging.  You may also want to consider
cooperating with the maintainer of the conflicting tree to minimise any
particularly complex conflicts.

--=20
Cheers,
Stephen Rothwell

diff --cc fs/nfsd/vfs.c
index 19f28c33e44d,8eda499de545..000000000000
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@@ -343,6 -339,44 +343,48 @@@ nfsd_get_write_access(struct svc_rqst *
  	return nfserrno(get_write_access(inode));
  }
 =20
+ static int __nfsd_setattr(struct dentry *dentry, struct iattr *iap)
+ {
+ 	int host_err;
+=20
+ 	if (iap->ia_valid & ATTR_SIZE) {
+ 		/*
+ 		 * RFC5661, Section 18.30.4:
+ 		 *   Changing the size of a file with SETATTR indirectly
+ 		 *   changes the time_modify and change attributes.
+ 		 *
+ 		 * (and similar for the older RFCs)
+ 		 */
+ 		struct iattr size_attr =3D {
+ 			.ia_valid	=3D ATTR_SIZE | ATTR_CTIME | ATTR_MTIME,
+ 			.ia_size	=3D iap->ia_size,
+ 		};
+=20
+ 		if (iap->ia_size < 0)
+ 			return -EFBIG;
+=20
+ 		host_err =3D notify_change(&init_user_ns, dentry, &size_attr, NULL);
+ 		if (host_err)
+ 			return host_err;
+ 		iap->ia_valid &=3D ~ATTR_SIZE;
+=20
+ 		/*
+ 		 * Avoid the additional setattr call below if the only other
+ 		 * attribute that the client sends is the mtime, as we update
+ 		 * it as part of the size change above.
+ 		 */
+ 		if ((iap->ia_valid & ~ATTR_MTIME) =3D=3D 0)
+ 			return 0;
+ 	}
+=20
 -	iap->ia_valid |=3D ATTR_CTIME;
 -	return notify_change(&init_user_ns, dentry, iap, NULL);
++	if (iap->ia_valid) {
++		iap->ia_valid |=3D ATTR_CTIME;
++		return notify_change(&init_user_ns, dentry, iap, NULL);
++	}
++
++	return 0;
+ }
+=20
  /*
   * Set various file attributes.  After this call fhp needs an fh_put.
   */
@@@ -357,9 -391,10 +399,10 @@@ nfsd_setattr(struct svc_rqst *rqstp, st
  	int		accmode =3D NFSD_MAY_SATTR;
  	umode_t		ftype =3D 0;
  	__be32		err;
 -	int		host_err;
 +	int		host_err =3D 0;
  	bool		get_write_count;
  	bool		size_change =3D (iap->ia_valid & ATTR_SIZE);
+ 	int		retries;
 =20
  	if (iap->ia_valid & ATTR_SIZE) {
  		accmode |=3D NFSD_MAY_WRITE|NFSD_MAY_OWNER_OVERRIDE;

--Sig_/x71jjIHH/OQo31x58HL2qMX
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmMfzeMACgkQAVBC80lX
0GzJDAf9Hyc6QBzR86G/Z7ndvUx49p9y/mnBZTfPeOgl18HOWrrC3BAkqpaB+ao1
DitKIgKPp/1E+UmEC/ktkMeHD5Ri3ClQGrO8SYc/K4ZO7ag14gFubwhoTYUkGqdd
XpO6YscYq0xyPFupIhY+pDJ0QSHmZbHix32COOsu9rUXWJAjYWFLcV2md3c7ff9c
3nHrmZ6SXunFoff0iV0zAnA6gM5JndukLzq6CL2W1j2SptW2L50lkoIiRWUxe+Uh
8giWxFxtzSmPH8l/yp/9dFO3b/gTP3bOoBVHjX2bJ87N4NNim47kVsCTvDRQGmO5
UisODRbl7/W39+8ZGiq9jGVZxq+M4w==
=tlT4
-----END PGP SIGNATURE-----

--Sig_/x71jjIHH/OQo31x58HL2qMX--