Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>
CC:     Nicolin Chen <nicolinc@nvidia.com>, Joerg Roedel <joro@8bytes.org>,
        "will@kernel.org" <will@kernel.org>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "marcan@marcan.st" <marcan@marcan.st>,
        "sven@svenpeter.dev" <sven@svenpeter.dev>,
        "alyssa@rosenzweig.io" <alyssa@rosenzweig.io>,
        "robdclark@gmail.com" <robdclark@gmail.com>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "gerald.schaefer@linux.ibm.com" <gerald.schaefer@linux.ibm.com>,
        "orsonzhai@gmail.com" <orsonzhai@gmail.com>,
        "baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
        "zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
        "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        "vdumpa@nvidia.com" <vdumpa@nvidia.com>,
        "jonathanh@nvidia.com" <jonathanh@nvidia.com>,
        "jean-philippe@linaro.org" <jean-philippe@linaro.org>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
        "christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
        "yangyingliang@huawei.com" <yangyingliang@huawei.com>,
        "jon@solid-run.com" <jon@solid-run.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "asahi@lists.linux.dev" <asahi@lists.linux.dev>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: RE: [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain
 and device/group
Thread-Topic: [PATCH v6 1/5] iommu: Return -EMEDIUMTYPE for incompatible
 domain and device/group
Thread-Index: AQHYsNLwCXoHuSRk00qOEfaHbTrxlq3UDMUAgAASXoCAAAVEgIAAM22AgAFUQQCAAC55AIAAuSeAgAARJhCAAIL6gIAFo0HQ
Date:   Tue, 13 Sep 2022 02:22:17 +0000
Message-ID: <BN9PR11MB527670BB3EEB81064DC811828C479@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220815181437.28127-1-nicolinc@nvidia.com>
 <20220815181437.28127-2-nicolinc@nvidia.com> <YxiRkm7qgQ4k+PIG@8bytes.org>
 <Yxig+zfA2Pr4vk6K@nvidia.com> <YxilZbRL0WBR97oi@8bytes.org>
 <YxjQiVnpU0dr7SHC@nvidia.com> <Yxnt9uQTmbqul5lf@8bytes.org>
 <YxoU8lw+qIw9woRL@nvidia.com> <YxqwQ+3OICPdEtk0@Asurada-Nvidia>
 <BN9PR11MB5276D4CDC551DEA5962F9A178C439@BN9PR11MB5276.namprd11.prod.outlook.com>
 <YxsshXKlidq8WgT+@nvidia.com>
In-Reply-To: <YxsshXKlidq8WgT+@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b4qeXk9yk5QzTjdJ3jnMCs1ixGiIWHfRF1YgiHM7o1kcAFatKoQ5Tb0N1ZWm?=
 =?us-ascii?Q?7vUvFYVzbOslLtFOKCjHUOWwkECNobeiQr9H3ycGf9GELBfzz/Am0c6x3o/u?=
 =?us-ascii?Q?wTMVs8rFQaSv7dZxxMrIndj2OTxhIeNvC/kDeasgnCXvul8zk4o+2V4w754L?=
 =?us-ascii?Q?ph4lQjDy0/st8JCQN3/61s0L6eGfFTm5t0gN2ngFjWJfy2UmrylEjK78ToqN?=
 =?us-ascii?Q?2NpZeVswFV0eZbNCO5zu2wbUZlbZINhZyeRZ9ms1O+ashlUKT+jiVcZXztTr?=
 =?us-ascii?Q?CotmeK6Iruz7auG0RkVJ13qDUpkpMMr0Jk/qVGrY/esSKZ2uuQwjpTflF84v?=
 =?us-ascii?Q?Ip93U5V+aDSPmt6LMXosQIR0StyNS9VYAWZVWZ0Fae6gG/kWvdgU691sUJA7?=
 =?us-ascii?Q?sv3+U7AnLfyQ3nQIcYgVPbNlbDGqefSyQVKX/BDFs+4ph7tteXb4lvnarIqx?=
 =?us-ascii?Q?Jk+GDVh0PM1RMOcstoBBU7saETKdcUf5mlnQcLFsd+l629bFC1pqdHs+WQXZ?=
 =?us-ascii?Q?Iee23pKgt9LDOIr7Qt44KL6N+D80pFnY0kQ/QpHx8yLM3VhuG4GPqYHNKw/v?=
 =?us-ascii?Q?Y54inkz7Hvb52dkdBJoKxQ3QyOlWvVqt7Gfl5KJ4vr4dNrgCem/aMsJR4C/0?=
 =?us-ascii?Q?QJv8MWTJXnwJJhLlPWyluM+0I4xy3yPgkc9ijTbYzCFs+74bio0kW3FDQx2U?=
 =?us-ascii?Q?6Lo4Lz1Tzdd+1Zg8hWa8ruC1Qdv2cSC6TXyOtP7yrm44lpFLRl15BYxiq/dZ?=
 =?us-ascii?Q?/Isv8ynn1JsRnQvSzK+RvQxtJ8FR5HFZAERGcsGvdAaxedkp9lL/qN7i/PC0?=
 =?us-ascii?Q?baFDGRLrMy0InZMcCJTg9e3rMF6WvZ1VlprLiBTHQ63ZODYasDOED19JVVxM?=
 =?us-ascii?Q?UXDURkGCzBpcACXmngM+4Qb3m4MupLOC08LVRRsObGT0iCuCnRVN0hRViH0q?=
 =?us-ascii?Q?OiR1gRIF8SbdMWbxSrs6nQvkwo5fFID34ePJOsuLqz28ibpn9mhCy+JyW2/a?=
 =?us-ascii?Q?UhbHCkoyz+UCB81s0JPwT1pij7cMgFE9HgYQ2BJTiQ8dufs3P3N+VMuuk3ra?=
 =?us-ascii?Q?LJHBPNCZeQSK6TUPmrPKxF3vWkXBFvxec1SM58OiFwSx8+helW5c+x5OIs13?=
 =?us-ascii?Q?oBGlvDvm4H++fCpWdTIlkm0IbksSOHGNqXTZX5rDVR+qGNBDiT+ismsqXm0b?=
 =?us-ascii?Q?udPt46R25GgtwlssftxrwfLyBNkV6YVSxQGodmoEMrOcvOjqwON80hyCN5yp?=
 =?us-ascii?Q?HdqLRZNkXZwqtvKd/zSq2o+v7Ns7w62nUvCsfvONISKv6ToQiGitBazLlKvr?=
 =?us-ascii?Q?KONzotzNgPNtvoWYxR3ztbFn/C6ZnpDrVvpz6FriWfCv6ujGwwIr3nXLZ05j?=
 =?us-ascii?Q?Z99MJTfaqOG88D4ft0x44nMiUY/twm8byKqiyK81GUXxcVIoWAqYVp5U4Rbn?=
 =?us-ascii?Q?dktqjoJGQ4p1tZq/wUAxURv/Ft41uRJBDCzV6HkyqLnbeK2ym9MbXp81hYz3?=
 =?us-ascii?Q?ssTk+BM5ZV7yMi8WBTVhU+YATdVbyqlQ94qJsAgHB39m0nj9Ye77ZetgNB1V?=
 =?us-ascii?Q?4tloqOtwtOjDysZUsRc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5ce67f3-a65f-4a98-18d2-08da952ec7ac
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2022 02:22:17.7012
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /H/LmOHGk/LV+KRBVGSs00g9G8hLQ0HGzLapZzpWY5xN0nFoEQgopuaQQLhqb/2GkrmbUM+Rqt1I3lDYrc7t8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6287
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@nvidia.com>
> Sent: Friday, September 9, 2022 8:08 PM
>=20
>=20
> > As discussed in a side thread a note might be added to exempt calling
> > kAPI outside of the iommu driver.
>=20
> Sadly, not really.. The driver is responsible to santize this if it is
> relevant. It is the main downside of this approach.
>=20

Better provide a clarification on what sanitization means.

e.g. I don't think we should change errno in those kAPIs to match the
definition in iommu subsystem since e.g. -EINVAL really means different
things in different context.

So the sanitization in iommu driver is probably that:

  - If an external kAPI returns -EINVAL, convert it to -ENODEV given iommu
    domain is iommu internal object hence unlikely for external kAPIs to
    capture incompatibility issue between domain/device;
  - Otherwise just pass whatever returned to the caller, following the defi=
nition
    of "Same behavior as -ENODEV" above

Thanks
Kevin