Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] security/keys: remove request_key_conswq and
 keyring_search_instkey() declarations
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     <dhowells@redhat.com>, <paul@paul-moore.com>, <jmorris@namei.org>,
        <serge@hallyn.com>, <keyrings@vger.kernel.org>,
        <linux-security-module@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220909060452.1121620-1-cuigaosheng1@huawei.com>
 <Yx8adIc2FC0jdJuM@kernel.org>
From:   cuigaosheng <cuigaosheng1@huawei.com>
Message-ID: <169ff0aa-b59f-99d2-942b-01cb2fe47795@huawei.com>
Date:   Tue, 13 Sep 2022 09:53:46 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <Yx8adIc2FC0jdJuM@kernel.org>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Thanks for taking the time to review this patch, I have made a patch V2 and submitted it.

link: https://patchwork.kernel.org/project/linux-security-module/patch/20220913014613.524253-1-cuigaosheng1@huawei.com/

?? 2022/9/12 19:39, Jarkko Sakkinen д??:
> "KEYS: Remove orphan declarations from security/keys/internal.h"
>
> On Fri, Sep 09, 2022 at 02:04:52PM +0800, Gaosheng Cui wrote:
>> request_key_conswq has been removed since
>> commit 76181c134f87 ("KEYS: Make request_key() and co fundamentally
>> asynchronous").
>>
>> keyring_search_instkey() has been removed since
>> commit b5f545c880a2 ("[PATCH] keys: Permit running process to
>> instantiate keys").
>>
>> so remove the declare for them from header file.
>>
>> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> "
> Remove the following orphan declarations from security/keys/internal.h:
>
> 1. request_key_conswq()
> 2. keyring_search_instkey()
> "
>
> Then add two fixes tags after that.
>
> BR, Jarkko
>
> .