Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6040182rwn; Mon, 12 Sep 2022 19:54:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR56mM4hV8GyY5ebk71wY9pZhmRQKDZGS8h1xJkXyGvY8Gnea7v+hJQy9jLlSrhKMwpFZRJD X-Received: by 2002:a05:6a00:170c:b0:537:27b4:ebfe with SMTP id h12-20020a056a00170c00b0053727b4ebfemr30469133pfc.19.1663037644831; Mon, 12 Sep 2022 19:54:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663037644; cv=none; d=google.com; s=arc-20160816; b=B4/XxxoNJUwvtZokqnbl5n4R82vBWpvYovGWXLJXI3ZHCV5F9R+JBMdQxkKlRMNYo6 xfH30wKHaiy+7EEBHOdo+ZacsaLg6QfL8GviURs+m6aKMa5m2GDzXnMDCMipIT91Nip+ Iu7rcdl49+OBb5OTYXat5iqyfR+dnuoUn7eSZZ8egPc565gSZ6TCYE06UtJMXyrEaaTY mvqYG0tvwVn2ka6F7dVoX7yXOVIH16pzgXmbkX0WgB1xqdDL1FRLxldPfofjLjuvKhjM RVUX3F43dzVdgC6U/EedFAENQy1LrmGj82AEkx+Qhnc2nvxGxBm8fviJM+ph0MLkK3l7 mkkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=5K5C19ucjIxirrTVwdTH8e1rDFFb25mycghKPQV6gu0=; b=YZDfCS055oDQW/fGCAK6paX6aUizfA3VAjLbpn5GbvuP5B9N9162rNRCdKiy7v+0Gd LEDbnc39P3iqpDibH2DgnUmqe01BpD5wnTI8UEsTyWeuArPNXqhuFiV74J9VSsYINTnm EDm9pvc2vn7WsjbQttivH/p+er0V7/fPoqRzfAYBp3girwVPnMgm3SGZaIzpUu/nWEuH YSu4zcdaTk9OOSwUn3k/oGxHyTxEiypBxjIZ58xuOdV2utwqwgaRNfkVovS3wJDT4Kn6 Y2Q0yQGl2vg9ocneP0qyH/FhRjUaQwXCeS7Q0hfrOUQ9MW6s1itXDc41Fu7hKFiDcpRh mQhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lixom-net.20210112.gappssmtp.com header.s=20210112 header.b="vdpA6/PC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nw4-20020a17090b254400b001fd7d02c976si10542878pjb.87.2022.09.12.19.53.52; Mon, 12 Sep 2022 19:54:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lixom-net.20210112.gappssmtp.com header.s=20210112 header.b="vdpA6/PC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbiIMCeR (ORCPT + 99 others); Mon, 12 Sep 2022 22:34:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229939AbiIMCeQ (ORCPT ); Mon, 12 Sep 2022 22:34:16 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FA4D52E60 for ; Mon, 12 Sep 2022 19:34:14 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id go34so24372391ejc.2 for ; Mon, 12 Sep 2022 19:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=5K5C19ucjIxirrTVwdTH8e1rDFFb25mycghKPQV6gu0=; b=vdpA6/PCDhdOn4FHZdxwU6muy2HDRh6oIz4AgmwFHsQZn4+Voak+h+r/3WyHUZSDy2 MT1zLdA1+Va/7dTKENil5CMjiiM5w3L/1bYVJmXlMmeJ2WTtcC09uf4rA2E9YhncIrnE x3eniFG3ljQmdA8u1Z715pWgOVFldMnB0uCJV6iBid35EBecyOnqU6C1vi2PNe7J911J b6Ga8Al/azf84L27DOL0pVQUZwuJhAicRv9wmua1tDiX8Et9brdlVI8nI7oEKCTyVloU xuYjwAnYMhQV3lFt19A/9eMqZ3LC/267oiEotbje/X0XktdF42H1NfJoncxojN7JAP74 OsZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=5K5C19ucjIxirrTVwdTH8e1rDFFb25mycghKPQV6gu0=; b=nEylac9j16AxTZRbRhYVKJ6oWWz4dBHfP1oYBZCQbYgWnrz4n8Bk0aqW5k+dpR9p/H 4LB7VFMwijkC/Mnc3tPKbkDpkYvVhvK2XV7SGkSGdZy80vuFVCsRwWjjWYHwQJkEN0Jc /hP4X3EzCLcvzjwl7j2TRH82vxoKZtCCQlaXLceF3BK8Gwa/2fvWwXt/36Ikl/f6o1d9 9tnmIj9JM/OeMNuhgD8gzNb6Dq9wGQ1TeHbwvOZXiprSf8HCzziC/AtEGWaOLBI0wK7U vBWNVAbFrtJbIBn7R+Vasg1K/ogQdQqqCU8qks1CZX6govFOIl+J3MTEfZXYE5xzrLd7 J1Yg== X-Gm-Message-State: ACgBeo164HhCi2ULHpYmrMVexXUHJ3E5iNYc7qjFsEAou6RJ/mWXTB8x bMOcYAR9wLiIPtDG863okb4KfRxeH526VfZF3eizyA== X-Received: by 2002:a17:907:1c0b:b0:77e:7da8:f6ed with SMTP id nc11-20020a1709071c0b00b0077e7da8f6edmr4079086ejc.309.1663036453344; Mon, 12 Sep 2022 19:34:13 -0700 (PDT) MIME-Version: 1.0 References: <20220817202538.21493-1-leoyang.li@nxp.com> <20220817202538.21493-2-leoyang.li@nxp.com> In-Reply-To: From: Olof Johansson Date: Mon, 12 Sep 2022 19:34:01 -0700 Message-ID: Subject: Re: [PATCH v4 1/2] arm64: dts: lx2160a: update PCIe nodes to match rev2 silicon To: "Russell King (Oracle)" Cc: Li Yang , shawnguo@kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hou Zhiqiang Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2022 at 1:33 PM Russell King (Oracle) wrote: > > On Mon, Sep 12, 2022 at 11:54:06AM -0700, Olof Johansson wrote: > > On Mon, Sep 12, 2022 at 12:05 AM Olof Johansson wrote: > > > > > > Hi, > > > > > > On Wed, Aug 17, 2022 at 1:26 PM Li Yang wrote: > > > > > > > > The original dts was created based on the non-production rev1 silicon > > > > which was only used for evaluation. Update the PCIe nodes to align with > > > > the different controller used in production rev2 silicon. > > > > > > How can I confirm what version of silicon I have on a system? > > > > > > My non-evaluation commercially purchased system (HoneyComb LX2K) has: > > > > > > # cat /sys/bus/soc/devices/soc0/revision > > > 1.0 > > > > > > And I will be really grumpy if this system stops working. It's what I > > > use to do all my maintainer work, even if that's been fairly dormant > > > this year. > > > > > > It's overall setting off red flags to update an in-place devicetree to > > > a "new revision" of silicon instead of adding a new DT for said > > > revision. 2160A has been on the market for several years, so it just > > > seems odd to all of the sudden retroactively make things > > > non-backwards-compatible. > > > > Confirmed that this patch renders my HoneyComb unbootable -- PCIe doesn't probe. > > > > Shawn, please revert, and be on the lookout for similar problematic > > approaches in the future. Thanks! > > I think you may also need to beware of the MC firmware revision - I > seem to remember reading in the changelog notes for it that NXP > dropped support in the MC firmware for the older silicon, though I > may be misremembering. It's been a while since I really looked at > the LX2160A from the point of view of maintaining or developing > anything for it. Yeah, and if anything this speaks against trying to update u-boot/EFI on it to something newer, bugs in firmware or not. -Olof