Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <9f801e9d8d830408f2ca27821f606e09aa856899.1662078528.git-series.apopple@nvidia.com>
 <68cf1d70f3fb8ce4e3c1a4899c19df4f6c382a13.1662078528.git-series.apopple@nvidia.com>
 <f81f6f90-81ad-7b77-a74d-e9d5d6e3bc94@nvidia.com>
 <87mtbb5soy.fsf@nvdebian.thelocal>
 <90a0441e-47ad-007f-06c1-b30e5f7bb692@nvidia.com>
User-agent: mu4e 1.6.9; emacs 27.1
From:   Alistair Popple <apopple@nvidia.com>
To:     John Hubbard <jhubbard@nvidia.com>
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org,
        Peter Xu <peterx@redhat.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        huang ying <huang.ying.caritas@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        David Hildenbrand <david@redhat.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        Matthew Wilcox <willy@infradead.org>,
        Karol Herbst <kherbst@redhat.com>,
        Lyude Paul <lyude@redhat.com>, Ben Skeggs <bskeggs@redhat.com>,
        Logan Gunthorpe <logang@deltatee.com>, paulus@ozlabs.org,
        linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 4/4] selftests/hmm-tests: Add test for dirty bits
Date:   Tue, 13 Sep 2022 12:33:40 +1000
In-reply-to: <90a0441e-47ad-007f-06c1-b30e5f7bb692@nvidia.com>
Message-ID: <87czc0m1wd.fsf@nvdebian.thelocal>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KaCH68r1cOfK6xkHEEUmKitGj0h5DWYR3Ure1vwz20giz4+xCugEV/DcRoZu?=
 =?us-ascii?Q?a9l2L97a/9YBaltC34p9/LMIoKKy5FndVHpRTAyzKT7i5uUHa193FNVZb0RU?=
 =?us-ascii?Q?OmYhMoqdK1EXjqXwz60sF4z1X6OQP4D343j6kyLbyvlhgIODB7w0tqiVJHg1?=
 =?us-ascii?Q?lcUN+2Q1cCSEJXkEQsartvLC+Z0cr5RLK6QZejL6b8LfvmC2AV8JASEfo7/j?=
 =?us-ascii?Q?/h8mXPBfvpSRtBgzHSvrW4+z2zTz8muOTex0mSn6wxWkuo09IsYHndHE8YCl?=
 =?us-ascii?Q?GqiX+T1pvt4vq3DJKzdlfGOgOVLZixU06OmC2tD2SyX6PPTOJAp20C3OY5Dc?=
 =?us-ascii?Q?WZQIq2Tc937SorP+yTz+jWObLyuqLmKWMr96kVEcv3DkkwkbcayPCp/m8ud+?=
 =?us-ascii?Q?EixS8u6cb4esKlAmnRKGR5ElpZqeI8bByJMtmilyRCB+sYQUPbLT44arUmge?=
 =?us-ascii?Q?UxK9ZssHbkgJFb3QvjMFTlNZQf/iNu4AL5GsWvSzc4Tb9tba1NkK1MNHDSMG?=
 =?us-ascii?Q?tUC2zoBMDKRl/Cek+NinNsCz2r9XzUnZe/Y1bxcAgO8OvmkepoChxmPsRpsP?=
 =?us-ascii?Q?MPi93x4BnJTQs/tyOzcGtBXgMNMBaLFEOS+Y48MCdg4rm4z+zZWMx+bK1RaB?=
 =?us-ascii?Q?R0jRBcbNKnuv9kA37Jm3R+AeI5S+wbiJdIJDlkoPeJf4+jw8veULydKdQ4AG?=
 =?us-ascii?Q?2Hii9ybyPO64dmi0Gnjr9fbWP89JUZj4VvWgqLwt6MfEEEKGrettg8+5czF7?=
 =?us-ascii?Q?cXYz5YdGC+nwgPBdtKgYJkYBp51LlB81te0pVXRyYSek87+uzZeIgWqnHWUo?=
 =?us-ascii?Q?vNtvjMaDHV1NT910rz9jR6auuN9ISOXCpL7dk1Co72OTsCTuzjMwLn3iH9oj?=
 =?us-ascii?Q?28sKj8Uf7YvkVNYoajMHTZ0dwPPBnOhKZWQs1rLQzN+ZA9qFEitH5yoMvZvY?=
 =?us-ascii?Q?GTtELIliy/sdDlkdu0WhLYtGjG7dr8tU7vbGEJwyvET73wOXipQGdTtNlwll?=
 =?us-ascii?Q?4vr3PjK84ir2lQjE+n8dAO26OnHhocKntgv0bWJl4/ZMUt/8KtnddonFeMJy?=
 =?us-ascii?Q?OFR3g1cCoYEVL7zd08rRLiLIS/8dAmlgngVT0vQmhFwJpkeP4lRbf0mafTmf?=
 =?us-ascii?Q?2k4tOTLfFsVN0IiLybGQZUheP73T1C/kcj/5BTVbYwizktoXYa+aHKy72xxb?=
 =?us-ascii?Q?7AMg7qdzSxa2409jSXcApJqXt35Z44tBo+kMpwPhdKXNVH3WGHhwS7vFPsd0?=
 =?us-ascii?Q?ENIIejwtnchbdaVGLNEpLnByLZsOTQXgNaMhNcS1vK6C4cgEGC5hUXHJJkYM?=
 =?us-ascii?Q?kFkmgPiYFoQjPfaMYcvuuNzyzyscVYhpJ3qihqcWCpWinh1z9D/n1zAfWtAP?=
 =?us-ascii?Q?XDnbcRvTrqHWAHZFN4SKfrjihXcHyZ98OwRtz1xY6R2RCtlXup5fhfLY2if/?=
 =?us-ascii?Q?fxazVUZ+SVvo1h0sut9v++SEPNVoEmE8Fr5hvrIopPJYYObpVmlD22eo/Bbv?=
 =?us-ascii?Q?0viQydzOTjFCAdnqgKP3aJtBjhCKME1EQRgPWMCF2j3hXTqzfIvhjOD/wIo/?=
 =?us-ascii?Q?l+A+28gE5+fzZISAzZWcUf7XK3TjQ7BHEWit9+ND?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb83a520-b19d-48fe-2db5-08da95317d18
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 02:41:41.4612
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yKCoKgiYhGEnYEqOLpmZcT5nVh4BQ/vm+PtYfcPE8Al7Y3r6J91eg8NlXT9Jm8QRA6DkAqDE9HDdt2stL1Xizg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5387
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


John Hubbard <jhubbard@nvidia.com> writes:

> On 9/7/22 04:13, Alistair Popple wrote:
>>>> +	/*
>>>> +	 * Attempt to migrate memory to device, which should fail because
>>>> +	 * hopefully some pages are backed by swap storage.
>>>> +	 */
>>>> +	ASSERT_TRUE(hmm_migrate_sys_to_dev(self->fd, buffer, npages));
>>>
>>> Are you really sure that you want to assert on that? Because doing so
>>> guarantees a test failure if and when we every upgrade the kernel to
>>> be able to migrate swap-backed pages. And I seem to recall that this
>>> current inability to migrate swap-backed pages is considered a flaw
>>> to be fixed, right?
>> Right, that's a good point. I was using failure (ASSERT_TRUE) here as a
>> way of detecting that at least some pages are swap-backed, because if no
>> pages end up being swap-backed the test is invalid.
>
> Yes. But "invalid" or "waived" is a much different test result than
> "failed".

True. Unfortunately our test framework needs some love as I don't think
it's possible to return a result of "invalid" or "waived". We can skip a
test though, so that might be the best option here.

>> I'm not really sure what to do about it though. It's likely the fix for
>
> Remove the assert. If the test framework allows and you prefer, you
> can print a warning.
>
>> swap-backed migration may make this bug impossible to hit anyway,
>> because the obvious fix is to just drop the pages from the swapcache
>> during migration which would force writeback during subsequent reclaim.
>> So I'm inclined to leave this here even if it only serves to remind us
>> about it when we do fix migration of swap-backed pages, because we will
>> of course run hmm-tests before submitting that fix :-) We can then
>> either fix the test or drop it if we think it's no longer possible to
>> hit.
>
> Oh no no no, please. This is not how to do tests. If you want a TODO
> list somewhere, there are other ways. But tests that require maintenance
> when you change something are an anti-pattern.

Fair enough, I think what you're asking for is a higher level test that
doesn't rely on implementation side-effects. I wrote this test mostly to
discover if we could hit problems with the current implementation hence
why it's a bit messy.

But I think I can fix this up without relying on implementation
side-effects - really I just want to confirm that at least some pages
got swapped to disk which I can do via looking at /proc/self/pagemap.

 - Alistair

> thanks,