Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7e64d472-fbce-6640-033a-51b8906b7924@intel.com>
Date:   Tue, 13 Sep 2022 10:30:43 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [RFC PATCH 9/9] kvm_main.c: handle atomic memslot update
Content-Language: en-US
To:     Emanuele Giuseppe Esposito <eesposit@redhat.com>,
        <kvm@vger.kernel.org>
CC:     Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        David Hildenbrand <david@redhat.com>,
        "Maxim Levitsky" <mlevitsk@redhat.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, <linux-kernel@vger.kernel.org>
References: <20220909104506.738478-1-eesposit@redhat.com>
 <20220909104506.738478-10-eesposit@redhat.com>
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <20220909104506.738478-10-eesposit@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTJ4b2IyRmc5WUtqRWNldllNOTQwREZQRU80K1pidEczak1sRXVkcW9vNVdj?=
 =?utf-8?B?MWZUSkx3WTI1TU9kMXh1VHQ2OUUxNlBVQ2hnSzFSaDNLWVhTemxsRVVNL1lG?=
 =?utf-8?B?bkdMMXljMzlXRVpWU2xsTk5Ja2c3R2hDTU5VVWFVeWhUK3FxdTk2anlaTGZj?=
 =?utf-8?B?SVVXV0diNXlIYjhtZ1czSFpLT1lCVkFMU28wQXVUVVpFcE4zVGVENHhyVGdr?=
 =?utf-8?B?eC96Z1E3RUFibXZUdGVwNTdrbW5vNDUrZVpGNUZEZVBYN2g4Y2cySDg0cjFW?=
 =?utf-8?B?MWJCOUhVYURzSXZUREk5OU9RQllKazVPZmFpaXlzeVVoNUgyeHhIc1E2YUZk?=
 =?utf-8?B?ZldDTitweUIreTJ1d214NlhCN0tmNEUxVXE5eUY4SWluRi8zWjJUd1hLWG1B?=
 =?utf-8?B?WnduWDRObmRRbnFMdUpnK3NqUExPdzN2MDRTdmxQSW9FRm94N0UvNWpmREZu?=
 =?utf-8?B?OHhOV3I3MmpTRFVFb2RUeEZrcHNWcUw1cFhmbGVRZTlrZ05QV2FvVXduc2xK?=
 =?utf-8?B?a3E1SUdGU3lzNi9IempKN2RPWHd1YzRyWkNnS2NpNzkxWkhLdUZlWEtacVRl?=
 =?utf-8?B?Rno3Qnl3VG9aTmR4ckcxOWlIMUZUWUNxNmlCM0JoejNSSmRKcVNyL0FpSkdk?=
 =?utf-8?B?b2JuZFB5OFlrOG5BKzRGZTBEdGpKWGZuM0FlU0JYTy94VjhYaitlYis0eTZ0?=
 =?utf-8?B?c3NLTHF4ZngzbGo5dEV3eTdEQnlwUkh2VlVwZlVRRDQ3M1p2TmJFd1dLL1JZ?=
 =?utf-8?B?bmFuNloxSnFQSWllazlhdmZVMkNaOUVqQ3RaMW55ZHdKbjdwSUVORWdsaitq?=
 =?utf-8?B?Vk1hbzBlaS8wc3JQSVUvL3V3Q3JyMTFCKy9SL09MRCt1NUxJdGl5L2daa2x6?=
 =?utf-8?B?RDZabFQxb3AwRHVsR0ZocWRMZm5IaUJDZGdWUHQzb2I4bmRxSGdjaHNuQnor?=
 =?utf-8?B?VTg3WHRZZUV3OUJscjVSVDhLcjVndldSMllIQUlvcFZma2NiNkk1aFhZOVBr?=
 =?utf-8?B?b2dvN1F3Ump4T1F6WG9mZXExd3d5SVdyemE2TjV4SFV1QjlqbURlUDJIOVJE?=
 =?utf-8?B?OUFNUmRURXpuc3h0M1MyOTV5YzZtdWpMRFd2cHpSS1J0UUxGMVM3clJIWGdy?=
 =?utf-8?B?SFFUaFU1ZmdMT1pJVUtpVzIrUkZoOEJqTmRZWEo3YWI0UmJMa0g3RGc4a3RM?=
 =?utf-8?B?b1crMENXclB5dXFBT2h1aVA2VXFzck96Mk13UnZQWWVqQ1VNMUdLVlgyallH?=
 =?utf-8?B?WU5HbHRXSXp4blRMZHVFTGFuOU03azNWNDBOV0QwVHhIa3I3OG9DeUJHVTE1?=
 =?utf-8?B?ZStBTjZNV3YrNzdqRnhTQm15SkZJWURicTUzdzF3VHhXdjFQUGFUNzQvNVRi?=
 =?utf-8?B?TTRaSW9oQXFQVGpGaXhUaEVXN3kvVEZ3TzIwYTJ0WE82TGppVkRobU91UjlN?=
 =?utf-8?B?UFJNNWxPaEJRU3FtbmhuRDE1cXF4UkgzYk55T2xHWVN0eUlqNGRSbHkxVGF3?=
 =?utf-8?B?MnZVOHpxZEdNRzdIWm05d1BBVC9DOVJqWmFqRjJlODdUaW1mbWd6bkc0V2lm?=
 =?utf-8?B?V00zNTBpbC9LT2Q0R2VQV0x0Z0FYT3NoL2Q4SGhDaHd4NUNUekczSEFybExm?=
 =?utf-8?B?aDF2anovZzRERHRiTitvUmEvVDRPcjJRdmozUnJSc2NucXJSMlhhZ21lTjg4?=
 =?utf-8?B?dEdhUEZRaCtYZGtoSkdjSDA5WUFLWC9NRmcram9RTjhCZXB0U2Z0S2JKVmtm?=
 =?utf-8?B?ZzE1WXJVVnlwZzEwV3lURDE0RFZDZFR6S2lIU2RXTjhpMHJ2QkxPUlExMVc4?=
 =?utf-8?B?NnBpSXZud3Nxb3Y3dkxqWmJKSVMzQ25SV2owRFJzOU5rMjZKc2pTazJxcU10?=
 =?utf-8?B?M2M5S1p5Tjl1V0dpSFlLZzVLbDYzMFYwSkxGazg2dFZpQW1oRkUyRldhUG9P?=
 =?utf-8?B?QTJ2aFNUZlh0ZWYzT2NHQmZCM3o4Nk8ydnBoWHJLSlI3YXY5Rk1yelR3NmJl?=
 =?utf-8?B?Z3NjTnV3VzJBbnZOU05Tbk04NXBaYkR1YlRqWDRhZURuWmRXUUpYT05NVkpq?=
 =?utf-8?B?emJZaEkwZWRZR05ZMWN4dkpkZDdEcm5tNHdqRzJBMWFXVVFWV0Y1TElhRjdh?=
 =?utf-8?B?L3J1WkFPWlpENE45d3ByVXFENmUzMTJkR2IvS1h2L29YbGVGYW5kNVhMeHhG?=
 =?utf-8?B?dEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 90ab848b-1aa3-43da-ce5d-08da952ffc7b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 02:30:55.9100
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gYBk7zxBmc3Z2E8xAn+evJF54B+nk3Y5bKN3WxJWZLiBQuptUDA6LApewYqKvNyQxXLRLS2xQu+W/WYavKOkng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6816
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/9/2022 6:45 PM, Emanuele Giuseppe Esposito wrote:
> When kvm_vm_ioctl_set_memory_region_list() is invoked, we need
> to make sure that all memslots are updated in the inactive list
> and then swap (preferreably only once) the lists, so that all
> changes are visible immediately.
[...]
> +static int kvm_vm_ioctl_set_memory_region_list(struct kvm *kvm,
> +		       struct kvm_userspace_memory_region_list *list,
> +		       struct kvm_userspace_memory_region_entry __user *mem_arg)
> +{
> +	struct kvm_userspace_memory_region_entry *mem, *m_iter;
> +	struct kvm_userspace_memory_region *mem_region;
> +	struct kvm_internal_memory_region_list *batch, *b_iter;
> +	int i, r = 0;
> +	bool *as_to_swap;
> +
> +	/* TODO: limit the number of mem to a max? */
> +
> +	if (!list->nent)
> +		return r;
> +
> +	mem = vmemdup_user(mem_arg, array_size(sizeof(*mem), list->nent));
> +	if (IS_ERR(mem)) {
> +		r = PTR_ERR(mem);
> +		goto out;
> +	}

IMO, it's more natural to dup the user memory at the first place, i.e., 
kvm_vm_ioctl,

it also makes the outlets shorter.


[...]