Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6090905rwn; Mon, 12 Sep 2022 21:13:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR5YzKa42rb28cnLyAFujzAwS4ZVLqMyEhzX0o4SqZAwCGHvn8fo1z8jzYKBLKExNDyV7/XK X-Received: by 2002:a65:6bd0:0:b0:434:a323:87ed with SMTP id e16-20020a656bd0000000b00434a32387edmr26398531pgw.19.1663042395243; Mon, 12 Sep 2022 21:13:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663042395; cv=none; d=google.com; s=arc-20160816; b=V+yI/HF2Cp/YMighA5d3Dw6llegwIJQEAjb/WJqKxN/RiRRFltg+6I4C9DnzOQ/RBU 6ZsNVYZck4WEP2esoDNr081GVdWyHKkJffYUjrCbPgJzUuUHdRs/hVSk26KXmTQoyprv sf08fPemTByQZ0KUfwQYzsq3CODkztFCDu5jZjhPnYZqJ4djsgfCtcHXevOY8hCs7ovc gX3wd5/oYDsYg5/UKJiI4PEIL1gT1Ct4D/BJ8HpeXtb2bq0sWdcfK+AA9Y/dauzrhQd7 Rl8bPCPNAJPhR6L4aZZLMquzJuABO1MLG/Lue2t7ErER4e7FayyvjKcHC21zh8crZSSK w0tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Yt5skMHD2obtBZgHbL1WkRT0xBXLr//+OulJfNwivRg=; b=zoP3Lp6mtWE8SCo/L4xW+gDNvvJWjoCD3zmcQ4V8dDWaCDDOMSQvXQZSaNw7xGb4py k7MY18B8wROfk528dq3eCapsqdAUN5nJFAK6kdKRRmJzDLvPo4lIH0Gij/yBt88HJN2W MZ6TnbzSUt2sFEZ5QeP8GvxUFCapp+h0rJEKXeMOStfr+7LnbP3zl7pnAOtNuDSTdTQc szWPjna0whZy8R1t39+lF/OEsMHBmypwejfb6ge6NVGceBDRAZE/I+YeuNdUn0YH3+WL uFDT63CpC2lZk/WyzUGKQonWAexik1+NDUi0TQzZ7vXcFRUAFX1PIvXM5ovnllqOf86c yoPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w6-20020a634746000000b0042b921fc051si4585345pgk.85.2022.09.12.21.13.02; Mon, 12 Sep 2022 21:13:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230137AbiIMDim (ORCPT + 99 others); Mon, 12 Sep 2022 23:38:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbiIMDib (ORCPT ); Mon, 12 Sep 2022 23:38:31 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAFA554653; Mon, 12 Sep 2022 20:38:28 -0700 (PDT) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MRTf16HnPzHntv; Tue, 13 Sep 2022 11:36:25 +0800 (CST) Received: from huawei.com (10.67.174.53) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 13 Sep 2022 11:38:25 +0800 From: Liao Chang To: , , , , , , , , , , CC: , , , Subject: [PATCH V2 2/3] csky/kprobe: Optimize the performance of patching single-step slot Date: Tue, 13 Sep 2022 11:34:53 +0800 Message-ID: <20220913033454.104519-3-liaochang1@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220913033454.104519-1-liaochang1@huawei.com> References: <20220913033454.104519-1-liaochang1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.174.53] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Single-step slot would not be used until kprobe is enabled, that means no race condition occurs on it under SMP, hence it is safe to pacth ss slot without stopping machine. Signed-off-by: Liao Chang --- arch/csky/kernel/probes/kprobes.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/csky/kernel/probes/kprobes.c b/arch/csky/kernel/probes/kprobes.c index 3c6e5c725d81..4feb5ce16264 100644 --- a/arch/csky/kernel/probes/kprobes.c +++ b/arch/csky/kernel/probes/kprobes.c @@ -57,7 +57,11 @@ static void __kprobes arch_prepare_ss_slot(struct kprobe *p) p->ainsn.api.restore = (unsigned long)p->addr + offset; - patch_text(p->ainsn.api.insn, p->opcode); + memcpy(p->ainsn.api.insn, &p->opcode, offset); + dcache_wb_range((unsigned long)p->ainsn.api.insn, + (unsigned long)p->ainsn.api.insn + offset); + icache_inv_range((unsigned long)p->ainsn.api.insn, + (unsigned long)p->ainsn.api.insn + offset); } static void __kprobes arch_prepare_simulate(struct kprobe *p) -- 2.17.1