Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2607d08b-a10b-528b-83dc-c9c2029fca61@quicinc.com>
Date:   Mon, 12 Sep 2022 21:05:40 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] soc: qcom: apr: Add check for idr_alloc
Content-Language: en-US
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, <agross@kernel.org>,
        <bjorn.andersson@linaro.org>, <konrad.dybcio@somainline.org>
CC:     <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220913023003.1677467-1-jiasheng@iscas.ac.cn>
 <4dd3417e-59c0-be93-59f8-a04dfff20d49@quicinc.com>
In-Reply-To: <4dd3417e-59c0-be93-59f8-a04dfff20d49@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9/12/2022 8:51 PM, Jeff Johnson wrote:
> On 9/12/2022 7:30 PM, Jiasheng Jiang wrote:
>> As idr_alloc() can return negative numbers,
>> it should be better to check the return value and
>> deal with the exception.
>>
>> Fixes: 6adba21eb434 ("soc: qcom: Add APR bus driver")
>> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
>> ---
>>   drivers/soc/qcom/apr.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c
>> index b4046f393575..1b73ce9b4f9a 100644
>> --- a/drivers/soc/qcom/apr.c
>> +++ b/drivers/soc/qcom/apr.c
>> @@ -454,8 +454,12 @@ static int apr_add_device(struct device *dev, 
>> struct device_node *np,
>>       adev->dev.driver = NULL;
>>       spin_lock(&apr->svcs_lock);
>> -    idr_alloc(&apr->svcs_idr, svc, svc_id, svc_id + 1, GFP_ATOMIC);
>> +    ret = idr_alloc(&apr->svcs_idr, svc, svc_id, svc_id + 1, 
>> GFP_ATOMIC);
>>       spin_unlock(&apr->svcs_lock);
>> +    if (ret < 0) {
>> +        kfree(adev);
>> +        return ret;
>> +    }
> 
> for consistency suggest you follow the same error logic as the 
> device_register() failure just below, call dev_err() and put_device()
> 

in addition the of_property_read_string_index() that follows could also 
use error checking