Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>
CC:     Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] iommu/vt-d: Enable PASID during iommu device probe
Thread-Topic: [PATCH 1/1] iommu/vt-d: Enable PASID during iommu device probe
Thread-Index: AQHYxlL15aXn1csO5EOwQ10Vd62MPq3cr0Mg
Date:   Tue, 13 Sep 2022 03:13:58 +0000
Message-ID: <BN9PR11MB5276B65B2EAF97D53719D2FE8C479@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220912024826.1684913-1-baolu.lu@linux.intel.com>
In-Reply-To: <20220912024826.1684913-1-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bqjaTN33jlEa6RLZ1XnXUYEQG5ZHz0WdKDH6Jj972ohL0Eo/j3gVT9elSqYJ?=
 =?us-ascii?Q?WH/xBaw47QncUZm0p3GhfePrElW0WRP73P2OpxBIMGcq8qWtC6dSc+jarGuz?=
 =?us-ascii?Q?mIvu5hP4onnRIX4IO+vddC+RIFiVZ0sJpkc9VV3gJSXPAjMAzuA/jLZijicN?=
 =?us-ascii?Q?JB99ry2pZ6sz2gHBPAWLZ0nUdHgxhFrrUYFr3+5tEt6cvUR+c7DD+e0F45F2?=
 =?us-ascii?Q?5w7aGgUiQfRi7v6pNMhhYdB7EHPV8l1D78sqqSBeYyrwu5WUAmmVIaLuZQrk?=
 =?us-ascii?Q?G1sqNQtXscIrCK9RuUyvdq7PdgOzD3SWjirivYbw4NcqRjvnCKiKBYbZlJUc?=
 =?us-ascii?Q?Ye0nFWSaoLFSbCgcGq2DzgjGYZrgpe2Z/5gguEPY42f/weHba9YBufg/fHu7?=
 =?us-ascii?Q?jNOp6/6kct9K2yGTtH/UhyJ41SrADE+bhFQH+YrS2u5MMmKVzyRD0Ct3Tm74?=
 =?us-ascii?Q?U0o/pORdbyhyEasIdpXvu1uwL+XpyoQ4oLIKVFwUNll7rpxi+C7Xw/+LtFcL?=
 =?us-ascii?Q?f2x86IZ7ymTsRj4D0FsXdQb7G74l+G+M5nhK6rE/+Vo/hA9RPWguQx8f/KWY?=
 =?us-ascii?Q?ga8914yMXI73JDQOUwPUX7zcpFGXX9kc1S+tcp98eSF48kvC+w08rTdMW31u?=
 =?us-ascii?Q?FqskWwXo6kQPWZ/TAdctel0nBB6Evssu7e8yA9N5Cy7Z4rpA8nQTm0ZlMkOB?=
 =?us-ascii?Q?+CCtJcdUci/C/ffb7R4GEaQzRlZd81QCRYuX57sILnNI5S+Np5SD1KUiJb1o?=
 =?us-ascii?Q?gTr//38lA1IC2409AoIW9+J+xKdCzAspl2o2IFRa36o2HLycivGig0A9X/4b?=
 =?us-ascii?Q?Bt2N+mukH4NlNH5/VS4MvZq1WRook/n7eyKyu31Ucfq6xUlmgg05BNcCEm/J?=
 =?us-ascii?Q?zHxF3JaByosNLyEkwfxmpdfPOyHZ6UmpZMsoNrPQkGAg4tRcQHZ3/OkgVdC0?=
 =?us-ascii?Q?Vb0UFrH3p+Let4IwXkui5TesA/fQUMa/AENhFx9YpoTUm1BVf8YVUXKpkKQI?=
 =?us-ascii?Q?h3+tIkqU8YLwrfSS2PonGxT2ENzNyQhFxCCx3np1DzDyhThKC6fiaeCp/HfM?=
 =?us-ascii?Q?jM7j5+JhaiVdUz43p7M2HvBcVzIucT0DkCGAAKWIoZdKHwBx7ofjdR9j/ZAX?=
 =?us-ascii?Q?sbQmD3KOhLQM0uaEMDN4jH/aVGeqoQgdjsFNrccTd9y2aeRxts27JRJYQ5QM?=
 =?us-ascii?Q?UC7bYZEQwTcLS4iUA/D6XrFi0Vm9IA2IBJq9thrygxgDbSJbDQVUQwAJjt+M?=
 =?us-ascii?Q?I6IXMY/8koBptyaIBkLlvrrrbvpQ8zIjy1wa/T8bXwXPtekbtoOSx7b/YRwc?=
 =?us-ascii?Q?Afn3ItQDMNPJrE4A6u1nWwI2f4UiWhinfzIE2vMPl3OWDmDdBgV1thkX35sr?=
 =?us-ascii?Q?4go9k22pPqtrLw0w9P2/q+6xHKKJk4Q//9v1UCX6ZX5vyY+nJqqIIfaMtjjT?=
 =?us-ascii?Q?zFAFi0z+7VRJ+ldXY1ePXK59UQFiD5BUKtx1bRna5zUjvtoO68tTrWzCI7hh?=
 =?us-ascii?Q?BSvecKm4qd1SyhifP/fteqzqoZI1PaBSgxspf+XZQZX393NofndueEBBV8P3?=
 =?us-ascii?Q?G9lB7mzU/QTmFbwUXBwalTFSqC10sSSQX4brrIvf?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19330053-72be-428a-64a8-08da95360018
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Sep 2022 03:13:58.7936
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XS0JMO/dDFRK5gmCND0EAX7Mn1iCW9mZw2CMKI3JXm32W9DD71axn8Ht+w+LsyLVzmWoq3rqV1yE8bYyOTb2/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5139
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Monday, September 12, 2022 10:48 AM
>=20
> Previously PASID supports on both IOMMU and PCI devices are enabled in
> the
> iommu_dev_enable_feature(dev, IOMMU_DEV_FEAT_SVA) path. It's
> functionally
> correct as the SVA is the only feature that requires PASID setup. However=
,
> looking ahead, we will add more features that need to enable pasid (for
> example, kernel DMA with PASID, SIOV, VM guest SVA, etc.). It makes more
> sense to enable PASID during iommu probing device.
>=20
> This enables PASID during iommu probing device and deprecates the
> intel_iommu_enable_pasid() helper. This is safe because the IOMMU
> hardware
> will block any PCI TLP with a PASID prefix if there is no IOMMU domain
> attached to the PASID of the device.
>=20

IMHO it's better to enable something only when it's actually required,
e.g. does it make more sense to have a IOMMU_DEV_FEAT_PASID
instead?

What this patch does has one problem. It's an intel-iommu driver
internal policy. How can a device driver reliably tell that the pasid
capability has been enabled by the iommu driver?

Thanks
Kevin