Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6099646rwn; Mon, 12 Sep 2022 21:27:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR6y2P0C7xVBUErr3pJFsaYYHqhBfKgsctZgvRcJI62kHtOrcj230dzALcl2MV3qKcgngnmw X-Received: by 2002:a17:902:8643:b0:172:e067:d7ac with SMTP id y3-20020a170902864300b00172e067d7acmr30220371plt.164.1663043270007; Mon, 12 Sep 2022 21:27:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663043269; cv=none; d=google.com; s=arc-20160816; b=P/2gcTdlV0HS1qH2lTuiAPb2llW4OBtwE0Y9HUVtb9AXlVJJM2gmzCGCnt9mD+Kgfy ze4yW6loAFFAbYq2LA5fX7QDYNTTPQ2Qo7LhLvBq/H8ST4toio2LkG8JXspd4k1Z8b4r aN/BW8/t7vaBk1mtIC64elZImju1q9BYXWsV/VWXPFZr2y+fIk5kn3o6sPmejjsTFQnB giX5iSJbqOI2viT3HhBeYqGYAe6VD/T5BQyrqttl0py4PLsd3NIYfmeY7oAq5OP8ivdH BhH498R+TFQb37joyvCQGaWW+XuiCp2MD8v6JAVg3Puc/EOWkj0j4V9Vzn3jScziVh6J Pr1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=AQgj0KFBylq+vQVfjE/+4Kj0dSacR4LJgCX4BdkdPWc=; b=S4jlUPEmCsAQpWKwGPNSvWdfve9WZbPD9nyYwfbTZ6ht2YOdNTcBsqFdf/EcLtjJ6q IWpn4Ae6fnB7YLCPHgLOCglSnBrhpgRSC1Er50lWrwRVfjJoxxAp02NUjoySP4/+VjCF G4pFIZNTTjag90SHO7nTsGJwWYuMKRiV1udnwJUurRwyHElycPlj1dlxqyHwhwYkgFmS 5fEtGWLRRfIEhar01PkyrURfgcnoFIcgNnx1fIZizC8rcUF5qaAfxlBe29sp5qmGtYHF LoJDI008qBb7rSG5uiEBW8Kk8WRSFzEeZ+5818npDcoGDU6GlN0pcjmqRbhb3MMUYdnc 9OBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m187-20020a6326c4000000b0042b92636a4fsi5998014pgm.80.2022.09.12.21.27.38; Mon, 12 Sep 2022 21:27:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229935AbiIMDK7 (ORCPT + 99 others); Mon, 12 Sep 2022 23:10:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbiIMDKz (ORCPT ); Mon, 12 Sep 2022 23:10:55 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0BE821809; Mon, 12 Sep 2022 20:10:54 -0700 (PDT) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MRT1S3c5qznVFm; Tue, 13 Sep 2022 11:08:12 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 13 Sep 2022 11:10:52 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 13 Sep 2022 11:10:52 +0800 From: Yang Yingliang To: , , CC: , , Subject: [PATCH -next 1/2] clk: qcom: apcs-msm8916: Use dev_err_probe() helper Date: Tue, 13 Sep 2022 11:17:55 +0800 Message-ID: <20220913031756.983224-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dev_err() can be replace with dev_err_probe() which will check if error code is -EPROBE_DEFER. Signed-off-by: Yang Yingliang --- drivers/clk/qcom/apcs-msm8916.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/clk/qcom/apcs-msm8916.c b/drivers/clk/qcom/apcs-msm8916.c index 89e0730810ac..233885236409 100644 --- a/drivers/clk/qcom/apcs-msm8916.c +++ b/drivers/clk/qcom/apcs-msm8916.c @@ -83,12 +83,9 @@ static int qcom_apcs_msm8916_clk_probe(struct platform_device *pdev) a53cc->parent_map = gpll0_a53cc_map; a53cc->pclk = devm_clk_get(parent, NULL); - if (IS_ERR(a53cc->pclk)) { - ret = PTR_ERR(a53cc->pclk); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to get clk: %d\n", ret); - return ret; - } + if (IS_ERR(a53cc->pclk)) + return dev_err_probe(dev, PTR_ERR(a53cc->pclk), + "failed to get clk\n"); a53cc->clk_nb.notifier_call = a53cc_notifier_cb; ret = clk_notifier_register(a53cc->pclk, &a53cc->clk_nb); -- 2.25.1