Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Sep 2022 08:28:06 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     Raul E Rangel <rrangel@chromium.org>
Cc:     linux-acpi@vger.kernel.org, linux-input@vger.kernel.org,
        andriy.shevchenko@linux.intel.com, jingle.wu@emc.com.tw,
        mario.limonciello@amd.com, timvp@google.com,
        linus.walleij@linaro.org, hdegoede@redhat.com, rafael@kernel.org,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 07/13] i2c: acpi: Use ACPI wake capability bit to set
 wake_irq
Message-ID: <YyAxBtAD2wL91quT@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Raul E Rangel <rrangel@chromium.org>, linux-acpi@vger.kernel.org,
        linux-input@vger.kernel.org, andriy.shevchenko@linux.intel.com,
        jingle.wu@emc.com.tw, mario.limonciello@amd.com, timvp@google.com,
        linus.walleij@linaro.org, hdegoede@redhat.com, rafael@kernel.org,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220912221317.2775651-1-rrangel@chromium.org>
 <20220912160931.v2.7.I8af4282adc72eb9f247adcd03676a43893a020a6@changeid>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3UTJQ9CDOp2Ojq2j"
Content-Disposition: inline
In-Reply-To: <20220912160931.v2.7.I8af4282adc72eb9f247adcd03676a43893a020a6@changeid>
Precedence: bulk


--3UTJQ9CDOp2Ojq2j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Sep 12, 2022 at 04:13:11PM -0600, Raul E Rangel wrote:
> Device tree already has a mechanism to pass the wake_irq. It does this
> by looking for the wakeup-source property and setting the
> I2C_CLIENT_WAKE flag. This CL adds the ACPI equivalent. It uses the
> ACPI interrupt wake flag to determine if the interrupt can be used to
> wake the system. Previously the i2c drivers had to make assumptions and
> blindly enable the wake IRQ. This can cause spurious wake events. e.g.,
> If there is a device with an Active Low interrupt and the device gets
> powered off while suspending, the interrupt line will go low since it's
> no longer powered and wakes the system. For this reason we should
> respect the board designers wishes and honor the wake bit defined on the
> interrupt.

I'll let the I2C ACPI maintainers deal with the technical details
because they are the experts here, yet one minor thing hits my eye:

> +		irq_ctx.irq = acpi_dev_gpio_irq_get_wake(
> +			adev, 0, &irq_ctx.wake_capable);

That line split looks weird with the open parens at the end of line 1.


--3UTJQ9CDOp2Ojq2j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmMgMQYACgkQFA3kzBSg
KbYLBQ//Uku0QuXy5XdPydAmO+biFM9Altxe0Nc4C7FbC6F9L6ekiQHwSsPcOXCp
9YMprziLx5LQAkPzJI9dxxmmDzuYktPmtEKWidU8R5DB9M6PgRSg4wT+dKSFPrhA
n6+qIfOVHSC6Kvi4I3rV6tFwRKFTC3nN05eB3BeLrFTKbW9S1N1yFqYYwu2Ry7gr
BIIvJjgNeSZmuaFhYK92GGTD/2IuYNGCWdHuupBRIJxHM5ZNQv1SedLm7hfjBUvH
WcFUrDqJSgXf+7BF+YtC3jsyjPZmPpDeOWa0xyOItm3A9s7murjTyJNePQerzrYh
RKLiaiVVc+qhElONvHUcgJp3NqbelEMUfRJowkJXZcIhwzg/L1xQRN7kUCF+yKlZ
wEjk0VJ11ttx7QNoAawlgH4XZDrJcZgQVckYx7qv342HTvi8xO8PX9cTVz3X0fOG
66fXxAHJ0DkdTw7RIsQ0oB4ayTn/dpMqIu3JyF9a7O7pz3BCTA8QAkP7PXcmKH+0
t32XHXSQQaMn1V3GK7Ox2CUbR3ORG2gccP6wWbs2ymmI4hjigEvET86ISyEiSOT9
0mX+x839iQWeesDoCP47y7lYgAtwKXgcHSepWsW5rbwH6RGdeJck5leACyL3aFE0
zYF6RlmJ7NahEbVZOFo6QsuFhZ5yd7HkvU1h14CuaBfYWf/n9jg=
=xwNP
-----END PGP SIGNATURE-----

--3UTJQ9CDOp2Ojq2j--